From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 528253858D26 for ; Thu, 3 Nov 2022 10:47:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 528253858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,235,1661846400"; d="scan'208";a="86151324" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 03 Nov 2022 02:47:21 -0800 IronPort-SDR: 06QxlulC0xfm8JnPzIlj2y/557TGrb9GAAzonMXPlQFPfpjMvGFoCHZGNBYNdVed1bGYwc72Sh 9lWsbi/3QBGew2QIlCuFdMLoaZN7Qtz3vMQwTOxV/CMI6IY2E5J6Fl8IU+O7VX1K4lOsrykD9L 3fiIOWxGXG7wiq2TfznRbthp2yKbE71L4u/ii8JGNnRdO0imtGpnIJY+BkF2Tbja3slGMafYhT vLH/90aIZg4wUbTLbc1YOEn3Nur87lSwecNi9CkDrg4FPwZCp0Obowv73RocfD6a+AYEi+gKvX yGI= From: Thomas Schwinge To: Bernhard Reutner-Fischer CC: , Tobias Burnus Subject: Re: Add 'libgomp.oacc-fortran/declare-allocatable-1.f90' (was: [gomp4] add support for fortran allocate support with declare create) In-Reply-To: <1ECCE9C8-0CE9-46EA-A0F2-3F3FA50F4681@gmail.com> References: <86f51209-c59d-a4cf-297d-9a072823aa61@codesourcery.com> <877d0dktqv.fsf@euler.schwinge.homeip.net> <1ECCE9C8-0CE9-46EA-A0F2-3F3FA50F4681@gmail.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Thu, 3 Nov 2022 11:47:15 +0100 Message-ID: <874jvgqpqk.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! Let me add back CC: , so that others may comment, too. On 2022-11-03T01:37:10+0100, Bernhard Reutner-Fischer wrote: > On 2 November 2022 21:04:56 CET, Thomas Schwinge wrote: >>> --- /dev/null >>> +++ b/libgomp/testsuite/libgomp.oacc-fortran/declare-allocatable-1.f90 >>> @@ -0,0 +1,211 @@ >>> +! Test declare create with allocatable arrays. >> >>... is useful in a different (though related) context that I'm currently >>working on. Having applied the following changes: >> >> - Replace 'call abort' by 'error stop' (in spirit of earlier PR84381 >> changes). > > Please remind me why you don't stop N > but error stop? - Don't have to re-number if changing test case later on. - Prints a backtrace (where supported). > Re: https://gcc.gnu.org/legacy-ml/fortran/2018-09/msg00173.html > > You'd obviously tweak > sub(/call\s\s*abort/, "stop " i) > with error\s\s*stop > > Or is your output so br^W lacking that you cannot write but just return? = But then i think that error stop writes, too, so that cannot be the case, c= an it? Right. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955