From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 41F0C385734F; Tue, 9 Jan 2024 23:02:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41F0C385734F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41F0C385734F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704841361; cv=none; b=ccFLMjFks34JEfrLfqqwdNQfl8L9p6Iwlr09uQgvciaLK8E8Ek+lsay0dJnQkE0eVE6h8/0dgHeEACdJHkt7IUtey/C1202+d9zZH1mxwqobCOemwg8gcodeWMe4H8+8sZSsR1B024IbMYg+DtswrgPE8uN9j8HEwUyQ+cot1qM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704841361; c=relaxed/simple; bh=nZrTOokG3+rBP4mTW5uv3OCpd4n0ds0FIQcHY4WzlxU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=CaSwUm5He4GZ9JCtdjHrK/H/QGJgvAaK/oq68MbX81FEfVx3Sc13rN9RvEQKZ8KW95PcVSz+XSF8lDf8X076GvXqeTOLDKD/Zq+bK2/6ejwIP03+NLZ04CEhnH6lr40lbkPW3GwjATmXh2rcK6IJ1DZklD9+ezihhj+BBrq0v9A= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: wG7ONH7TRuu6BEGi5HiVsg== X-CSE-MsgGUID: sqg+MV45Slm83s0ox4guew== X-IronPort-AV: E=Sophos;i="6.04,184,1695715200"; d="scan'208";a="27592044" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 09 Jan 2024 15:02:36 -0800 IronPort-SDR: pYEFEu6DIxg1KkGpYnys9uJ33miUq5fmFXByH3ByXQEVZSOumZjzQyWaznsP8Dt9DgZuAYYi1y Vk2kE1+7Ke24/unw6PGskn4O+FbmeGkhaXythvR4Q2fnymCNpf9cC5AQUeNng0trt5lgpZBdsD ZlciOicIR8NCoYi4Y12JtkS/bE3ygKIjHZ+p53VjZrvoOMhdXClq/N1OuLFLRcaDFOHV7xyJ/v UmXMKe9R64YqGG2DBE5wisSM2L7WDrvT7ECfXRJyGZ3LE6Ita4OPJds517rhCHDS6gDj+wzeu2 t0A= From: Thomas Schwinge To: Julian Brown CC: Tobias Burnus , , , Subject: Re: [PATCH 1/8] OpenMP: lvalue parsing for map/to/from clauses (C++) In-Reply-To: <0f3ec635-a817-4fa8-b307-6f977cda8642@net-b.de> References: <9a497499-31d7-4bb2-afdd-815966b49406@codesourcery.com> <20240105122326.1f89c4d6@squid.athome> <0f3ec635-a817-4fa8-b307-6f977cda8642@net-b.de> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Wed, 10 Jan 2024 00:02:29 +0100 Message-ID: <877ckip0u2.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Julian! On 2024-01-07T16:04:37+0100, Tobias Burnus wrote: > Am 05.01.24 um 13:23 schrieb Julian Brown: >> Here's a rebased/retested version [...] > LGTM - [...] Got pushed as commit r14-7033-g1413af02d62182bc1e19698aaa4dae406f8f13bf "OpenMP: lvalue parsing for map/to/from clauses (C++)". Some (hopefully minor) tuning in the test cases is necessary; for example, for x86_64-pc-linux-gnu '-m32' testing, I see a few FAILs: +PASS: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[1\\] [len: x !=3D 0 ? [0-9]+ : [0-9]+\\]\\) map\\= (firstprivate:arr1 \\[pointer assign, bias: [0-9]+\\]\\)" +PASS: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[1\\] \\[len: x !=3D 0 \\? [0-9]+ : [0-9]+\\]\\) m= ap\\(firstprivate:arr1 \\[pointer assign, bias: [0-9]+\\]\\)" +FAIL: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: [0-9]+\= \]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &arr1= \\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +FAIL: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: [0-9]+\= \]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &arr1= \\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +FAIL: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: [0-9]+\= \]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &arr1= \\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +FAIL: g++.dg/gomp/array-section-1.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: [0-9]+\= \]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &arr1= \\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +PASS: g++.dg/gomp/array-section-1.C -std=3Dc++98 (test for excess err= ors) Etc. +PASS: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[0\\] \\[len: \\(sizetype\\) y \\* [0-9]+\\]\\) ma= p\\(firstprivate:arr1 \\[pointer assign, bias: 0\\]\\)" +PASS: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[0\\] \\[len: \\(sizetype\\) y \\* [0-9]+\\]\\) ma= p\\(firstprivate:arr1 \\[pointer assign, bias: 0\\]\\)" +FAIL: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: \\(40 - \\(sizetype\\) S= AVE_EXPR \\) \\* [0-9]+\\]\\) map\\(firstprivate:arr1 \\[pointer assign,= bias: \\(long int\\) &arr1\\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)= " +FAIL: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: \\(40 - \\(sizetype\\) S= AVE_EXPR \\) \\* [0-9]+\\]\\) map\\(firstprivate:arr1 \\[pointer assign,= bias: \\(long int\\) &arr1\\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)= " +FAIL: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: \\(sizetype\\) y \\* [0-= 9]+\\]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &= arr1\\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +FAIL: g++.dg/gomp/array-section-2.C -std=3Dc++98 scan-tree-dump orig= inal "map\\(tofrom:arr1\\[SAVE_EXPR \\] \\[len: \\(sizetype\\) y \\* [0-= 9]+\\]\\) map\\(firstprivate:arr1 \\[pointer assign, bias: \\(long int\\) &= arr1\\[SAVE_EXPR \\] - \\(long int\\) &arr1\\]\\)" +PASS: g++.dg/gomp/array-section-2.C -std=3Dc++98 (test for excess err= ors) Etc. +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 15 (tes= t for errors, line 14) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 16 (tes= t for errors, line 14) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 17 (tes= t for errors, line 14) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 22 (tes= t for warnings, line 21) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 36 (tes= t for errors, line 35) +FAIL: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 37 (tes= t for warnings, line 35) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 38 (tes= t for errors, line 35) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 39 (tes= t for errors, line 35) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 at line 44 (tes= t for warnings, line 43) +PASS: g++.dg/gomp/bad-array-section-4.C -std=3Dc++98 (test for excess= errors) Etc. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955