From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33807 invoked by alias); 6 Apr 2017 09:05:21 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 33784 invoked by uid 89); 6 Apr 2017 09:05:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Apr 2017 09:05:18 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1cw3Lx-0005gG-BM from Thomas_Schwinge@mentor.com ; Thu, 06 Apr 2017 02:05:17 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Thu, 6 Apr 2017 02:05:16 -0700 Received: by tftp-cs (Postfix, from userid 49978) id 7AE06C2316; Thu, 6 Apr 2017 02:05:16 -0700 (PDT) From: Thomas Schwinge To: Cesar Philippidis CC: "gcc-patches@gcc.gnu.org" , Fortran List , Chung-Lin Tang Subject: Re: [gomp4] add support for fortran allocate support with declare create In-Reply-To: <86f51209-c59d-a4cf-297d-9a072823aa61@codesourcery.com> References: <86f51209-c59d-a4cf-297d-9a072823aa61@codesourcery.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 06 Apr 2017 09:05:00 -0000 Message-ID: <87bms9hpof.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-04/txt/msg00014.txt.bz2 Hi Cesar! On Wed, 5 Apr 2017 08:23:58 -0700, Cesar Philippidis wrote: > This patch implements the OpenACC 2.5 behavior of fortran allocate on > variables marked with declare create as defined in Section 2.13.2 in the > OpenACC spec. Thanks! > While working on adding support for allocate, I noticed that OpenACC > declare has a number of quirks. For starters, the fortran FE wasn't > lowering them properly, so there was no way for omplower to utilize them > inside acc parallel regions. > There is still some unimplemented functionality. > [...] File (at least some of these?) as separate issues, I guess? > I've applied this patch to gomp-4_0-branch. Not reviewed, but I noticed: > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 > @@ -0,0 +1,25 @@ > +! Verify that OpenACC declared allocatable arrays have implicit > +! OpenACC enter and exit pragmas at the time of allocation and > +! deallocation. > + > +! { dg-additional-options "-fdump-tree-original" } > +[...] > +! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_a= llocate" 1 "gimple" } } > +! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_de= allocate" 1 "gimple" } } UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90 -O scan-tre= e-dump-times gimple "pragma acc enter data map.declare_allocate" 1 UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90 -O scan-tre= e-dump-times gimple "pragma acc exit data map.declare_deallocate" 1 PASS: gfortran.dg/goacc/declare-allocatable-1.f90 -O (test for exces= s errors) "original" vs. "gimple" -- which one should it be? Gr=C3=BC=C3=9Fe Thomas