From: Thomas Schwinge <thomas@codesourcery.com>
To: Harald Anlauf <anlauf@gmx.de>,
Rimvydas Jasinskas <rimvydasjas@gmail.com>, <fortran@gcc.gnu.org>,
<gcc-patches@gcc.gnu.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: nvptx: Adjust 'scan-assembler' in 'gfortran.dg/weak-1.f90' (was: Support for NOINLINE attribute)
Date: Tue, 14 Feb 2023 10:35:29 +0100 [thread overview]
Message-ID: <87h6vo8u8u.fsf@euler.schwinge.homeip.net> (raw)
In-Reply-To: <0115618b-059b-fd11-a813-33374f16af78@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]
Hi!
On 2023-02-13T18:50:23+0100, Harald Anlauf via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> Pushed as:
>
> commit 086a1df4374962787db37c1f0d1bd9beb828f9e3
> On 2/12/23 22:28, Harald Anlauf via Gcc-patches wrote:
>> There is one thing I cannot test, which is the handling of weak symbols
>> on other platforms. A quick glance at the C testcases suggests that
>> someone with access to either an NVPTX or MingGW target might tell
>> whether that particular target should be excluded.
Indeed nvptx does use a different assembler syntax; I've pushed to
master branch commit 8d8175869ca94c600e64e27b7676787b2a398f6e
"nvptx: Adjust 'scan-assembler' in 'gfortran.dg/weak-1.f90'", see
attached.
And I'm curious, is '!GCC$ ATTRIBUTES weak' meant to be used only for
weak definitions (like in 'gfortran.dg/weak-1.f90'), or also for weak
declarations (which, for example, in the C world then evaluate to
zero-address unless actually defined)? When I did a quick experiment,
that didn't seem to work? (But may be my fault, of course.)
And, orthogonally: is '!GCC$ ATTRIBUTES weak' meant to be used only for
subroutines (like in 'gfortran.dg/weak-1.f90') and also functions (I
suppose; test case?), or also for weak "data" in some way (which, for
example, in the C world then evaluates to a zero-address unless actually
defined)?
Could help to at least add a few more test cases, and clarify the
documentation?
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-nvptx-Adjust-scan-assembler-in-gfortran.dg-weak-1.f9.patch --]
[-- Type: text/x-diff, Size: 1130 bytes --]
From 8d8175869ca94c600e64e27b7676787b2a398f6e Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Tue, 14 Feb 2023 10:11:19 +0100
Subject: [PATCH] nvptx: Adjust 'scan-assembler' in 'gfortran.dg/weak-1.f90'
Fix-up for recent commit 086a1df4374962787db37c1f0d1bd9beb828f9e3
"Fortran: Add !GCC$ attributes NOINLINE,NORETURN,WEAK".
gcc/testsuite/
* gfortran.dg/weak-1.f90: Adjust 'scan-assembler' for nvptx.
---
gcc/testsuite/gfortran.dg/weak-1.f90 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/gfortran.dg/weak-1.f90 b/gcc/testsuite/gfortran.dg/weak-1.f90
index d9aca686775a..9ec1fe74053e 100644
--- a/gcc/testsuite/gfortran.dg/weak-1.f90
+++ b/gcc/testsuite/gfortran.dg/weak-1.f90
@@ -1,6 +1,7 @@
! { dg-do compile }
! { dg-require-weak "" }
-! { dg-final { scan-assembler "weak\[^ \t\]*\[ \t\]_?impl" } }
+! { dg-final { scan-assembler "weak\[^ \t\]*\[ \t\]_?impl" { target { ! nvptx-*-* } } } }
+! { dg-final { scan-assembler-times "\\.weak \\.func impl" 2 { target nvptx-*-* } } }
subroutine impl
!GCC$ ATTRIBUTES weak :: impl
end subroutine
--
2.39.1
next prev parent reply other threads:[~2023-02-14 9:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 5:42 Support for NOINLINE attribute Rimvydas Jasinskas
2023-02-10 8:24 ` Steve Kargl
2023-02-10 8:38 ` Rimvydas Jasinskas
2023-02-10 18:53 ` Steve Kargl
2023-02-10 21:07 ` Harald Anlauf
2023-02-10 21:16 ` Steve Kargl
2023-02-10 22:16 ` Rimvydas Jasinskas
2023-02-11 21:26 ` Harald Anlauf
2023-02-12 6:59 ` Rimvydas Jasinskas
2023-02-12 21:28 ` Harald Anlauf
2023-02-13 17:50 ` Harald Anlauf
2023-02-14 9:35 ` Thomas Schwinge [this message]
2023-02-14 19:55 ` nvptx: Adjust 'scan-assembler' in 'gfortran.dg/weak-1.f90' (was: Support for NOINLINE attribute) Harald Anlauf
2023-02-15 20:58 ` Support for WEAK attribute, part 2 Rimvydas Jasinskas
2023-02-16 21:50 ` Harald Anlauf
2023-02-23 13:55 ` Rimvydas Jasinskas
2023-02-23 20:53 ` Harald Anlauf
2023-02-24 5:16 ` Rimvydas Jasinskas
2023-02-24 22:03 ` Harald Anlauf
2023-03-28 21:06 ` Enable 'gfortran.dg/weak-2.f90' for nvptx target (was: Support for WEAK attribute, part 2) Thomas Schwinge
2023-02-18 20:35 ` Support for NOINLINE attribute Bernhard Reutner-Fischer
2023-02-24 7:19 ` Bernhard Reutner-Fischer
2023-02-24 12:02 ` Rimvydas Jasinskas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6vo8u8u.fsf@euler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=rimvydasjas@gmail.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).