From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130427 invoked by alias); 19 Apr 2018 09:19:53 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 130272 invoked by uid 89); 19 Apr 2018 09:19:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=backwards X-Spam-User: qpsmtpd, 3 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Apr 2018 09:19:42 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1f95j9-00059J-NY from Thomas_Schwinge@mentor.com ; Thu, 19 Apr 2018 02:19:39 -0700 Received: from hertz.schwinge.homeip.net (137.202.0.87) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 19 Apr 2018 10:19:36 +0100 From: Thomas Schwinge To: Jakub Jelinek CC: Thomas =?utf-8?Q?K=C3=B6nig?= , "fortran@gcc.gnu.org" , gcc-patches , Subject: Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets) In-Reply-To: <20180419091438.GX8577@tucnak> References: <751060e1-67cb-d290-4fd1-46b15b77fc1a@tkoenig.net> <87in8nsgz9.fsf@euler.schwinge.homeip.net> <20180419091438.GX8577@tucnak> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 19 Apr 2018 09:19:00 -0000 Message-ID: <87muxzbljw.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-04/txt/msg00100.txt.bz2 Hi! On Thu, 19 Apr 2018 11:14:38 +0200, Jakub Jelinek wrote: > On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote: > > On Wed, 4 Apr 2018 11:30:34 +0200, Thomas K=C3=B6nig w= rote: > > > the recent patch to make the gfortran and libgomp testsuites more > > > standard conforming, by replacing CALL ABORT() with STOP N, led > > > to numerous testsuite failures on nvptx because stop_numeric > > > was not implemented in minimal.c. > > >=20 > > > I have committed the patch below in r259072 as obvious after Tom > > > de Vries had confirmed that it solves the problem. > >=20 > > ... for some meaning of "solves the problem"; see below. ;-) Which you > > couldn't know, of course. (So, definitely thanks anyway, for promptly > > addressing the issue raised!) >=20 > My preference would be just to revert the call abort to stop n changes > in target regions. That seems backwards to me -- having "exit" (as well as Fortran language "stop" and "error stop") inside offloaded regions do the right thing is something we wanted to do anyway, eventually. > Mapping exit to abort is weird Sure, that's why PR85463 is still open, and has some (initial) comments/ideas regarding that. > and making exit terminate whole process even > when called from offloaded regions might be too expensive. In what way "too expensive"? Gr=C3=BC=C3=9Fe Thomas