From: Thomas Schwinge <thomas@codesourcery.com>
To: Ilmir Usmanov <me@ilmir.us>
Cc: <gcc-patches@gcc.gnu.org>, <i.usmanov@samsung.com>,
<fortran@gcc.gnu.org>, <cesar@codesourcery.com>
Subject: Re: [gomp4, fortran] Patch to fix continuation checks of OpenACC and OpenMP directives
Date: Mon, 27 Jul 2015 14:14:00 -0000 [thread overview]
Message-ID: <87r3ntr8li.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <5591E54E.90509@ilmir.us>
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
Hi!
On Tue, 30 Jun 2015 03:39:42 +0300, Ilmir Usmanov <me@ilmir.us> wrote:
> 08.06.2015, 17:59, "Cesar Philippidis" <cesar@codesourcery.com>:
> > On 06/07/2015 02:05 PM, Ilmir Usmanov wrote:
> >> 08.06.2015, 00:01, "Ilmir Usmanov" <me@ilmir.us>:
> >>>> This patch fixes checks of OpenMP and OpenACC continuations in
> >>>> case if someone mixes them (i.e. continues OpenMP directive with
> >>>> !$ACC sentinel or vice versa).
Thanks for working on this!
> >>>> OK for gomp branch?
The same applies to GCC trunk, as far as I can tell -- any reason not to
apply the patch to trunk?
> > Thanks for working on this. Does this fix PR63858 by any chance?
> No problem. I had a feeling that something is wrong in the scanner since
> I've committed an initial support of OpenACC ver. 1.0 to gomp branch
> (more than a year ago).
> Now it does fix the PR, because I've added support of fixed form to the
> patch. BTW, your test in the PR has a wrong continuation. Fixed test
> added to the patch.
I understand correctly that your patch does fix
<https://gcc.gnu.org/PR63858>, right? In that case, please assign the PR
to yourself, and close it as fixed, once it is fixed in trunk.
> --- a/gcc/fortran/ChangeLog.gomp
> +++ b/gcc/fortran/ChangeLog.gomp
> @@ -1,3 +1,13 @@
> +2015-06-30 Ilmir Usmanov <me@ilmir.us>
> +
> + PR/63858
The format to use is PR [component]/[number], so here: PR fortran/63858.
> --- a/gcc/testsuite/ChangeLog.gomp
> +++ b/gcc/testsuite/ChangeLog.gomp
> @@ -1,3 +1,10 @@
> +2015-06-30 Ilmir Usmanov <me@ilmir.us>
> +
> + PR/63858
Same.
> --- /dev/null
> +++ b/gcc/testsuite/gfortran.dg/goacc/omp-fixed.f
> @@ -0,0 +1,32 @@
> +! { dg-do compile }
> +! { dg-additional-options "-fopenmp" }
For C, C++, we have a goacc-gomp directory, where both OpenACC and OpenMP
are enabled -- does that make sense to have for Fortran, too?
Grüße,
Thomas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-07-27 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3008431435623821@web14j.yandex.ru>
2015-06-30 0:43 ` Ilmir Usmanov
[not found] ` <650751436268444@web22m.yandex.ru>
2015-07-14 21:20 ` Ilmir Usmanov
2015-07-14 21:24 ` Cesar Philippidis
2015-07-27 14:14 ` Thomas Schwinge [this message]
2015-10-09 10:15 ` [PR fortran/63858] Fix mix of OpenACC and OpenMP sentinels in continuations Thomas Schwinge
2015-10-19 17:09 ` Thomas Schwinge
2015-10-20 9:37 ` Jakub Jelinek
2015-11-25 14:33 ` Cesar Philippidis
2015-11-25 19:10 ` Bernhard Reutner-Fischer
[not found] <6770611433710899@web6g.yandex.ru>
2015-06-07 21:06 ` [gomp4, fortran] Patch to fix continuation checks of OpenACC and OpenMP directives Ilmir Usmanov
2015-06-08 14:59 ` Cesar Philippidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3ntr8li.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=cesar@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=i.usmanov@samsung.com \
--cc=me@ilmir.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).