From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 85EBD3858C83; Sun, 13 Nov 2022 08:51:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85EBD3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4N95lX3mMJz1r0mT; Sun, 13 Nov 2022 09:51:36 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4N95lX1Jmnz1qqlR; Sun, 13 Nov 2022 09:51:36 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id FDhNr9x0B9tI; Sun, 13 Nov 2022 09:51:35 +0100 (CET) X-Auth-Info: mbeiJiy+u1Nb8P6coktql6k7t/1+fQea3AkHLZbbCEsVILDSkJMcvbFCUgvzW+tR Received: from tiger.home (aftr-82-135-86-4.dynamic.mnet-online.de [82.135.86.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 13 Nov 2022 09:51:35 +0100 (CET) Received: by tiger.home (Postfix, from userid 1000) id C0BF9130867; Sun, 13 Nov 2022 09:51:34 +0100 (CET) From: Andreas Schwab To: Harald Anlauf via Gcc-patches Cc: fortran , Harald Anlauf Subject: Re: [PATCH] Fortran: fix treatment of character, value, optional dummy arguments [PR107444] References: X-Yow: CONGRATULATIONS! Now should I make thinly veiled comments about DIGNITY, self-esteem and finding TRUE FUN in your RIGHT VENTRICLE?? Date: Sun, 13 Nov 2022 09:51:34 +0100 In-Reply-To: (Harald Anlauf via Gcc-patches's message of "Thu, 10 Nov 2022 22:56:48 +0100") Message-ID: <87sfinutih.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 10 2022, Harald Anlauf via Gcc-patches wrote: > Dear Fortranners, > > the attached patch is a follow-up to the fix for PR107441, > as it finally fixes the treatment of character dummy arguments > that have the value,optional attribute, and allows for checking > of the presence of such arguments. > > This entails a small ABI clarification, as the previous text > was not really clear on the argument passing conventions, > and the previously generated code was inconsistent at best, > or rather wrong, for this kind of procedure arguments. > (E.g. the number of passed arguments was varying...) > > Testcase cross-checked with NAG 7.1. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? This breaks aarch64: $ /opt/gcc/gcc-20221113/Build/./gcc/xgcc -B/opt/gcc/gcc-20221113/Build/./gc= c/ -B/usr/aarch64-suse-linux/bin/ -B/usr/aarch64-suse-linux/lib/ -isystem /= usr/aarch64-suse-linux/include -isystem /usr/aarch64-suse-linux/sys-include= -fchecking=3D1 ../../../../libgomp/testsuite/libgomp.fortran/is_device_ptr= -2.f90 -mabi=3Dlp64 -B/opt/gcc/gcc-20221113/Build/aarch64-suse-linux/./libg= omp/ -B/opt/gcc/gcc-20221113/Build/aarch64-suse-linux/./libgomp/.libs -I/op= t/gcc/gcc-20221113/Build/aarch64-suse-linux/./libgomp -I../../../../libgomp= /testsuite/../../include -I../../../../libgomp/testsuite/.. -fmessage-lengt= h=3D0 -fno-diagnostics-show-caret -fdiagnostics-color=3Dnever -fopenmp -O -= fdump-tree-original -B/opt/gcc/gcc-20221113/Build/aarch64-suse-linux/./libg= omp/../libgfortran/.libs -fintrinsic-modules-path=3D/opt/gcc/gcc-20221113/B= uild/aarch64-suse-linux/./libgomp -L/opt/gcc/gcc-20221113/Build/aarch64-sus= e-linux/./libgomp/.libs -L/opt/gcc/gcc-20221113/Build/aarch64-suse-linux/./= libgomp/../libgfortran/.libs -lgfortran -foffload=3D-lgfortran -lm -o ./is_= device_ptr-2.exe during GIMPLE pass: omplower ../../../../libgomp/testsuite/libgomp.fortran/is_device_ptr-2.f90:66:77: in= ternal compiler error: in gfc_omp_check_optional_argument, at fortran/trans= -openmp.cc:137 0x8acb63 gfc_omp_check_optional_argument(tree_node*, bool) ../../gcc/fortran/trans-openmp.cc:137 0xd29fc3 lower_omp_target ../../gcc/omp-low.cc:13632 0xd314b3 lower_omp_1 ../../gcc/omp-low.cc:14523 0xd314b3 lower_omp ../../gcc/omp-low.cc:14662 0xd31283 lower_omp_1 ../../gcc/omp-low.cc:14436 0xd31283 lower_omp ../../gcc/omp-low.cc:14662 0xd318a3 lower_omp_1 ../../gcc/omp-low.cc:14452 0xd318a3 lower_omp ../../gcc/omp-low.cc:14662 0xd377fb execute_lower_omp ../../gcc/omp-low.cc:14701 0xd377fb execute ../../gcc/omp-low.cc:14755 Please submit a full bug report, with preprocessed source (by using -frepor= t-bug). --=20 Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."