From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 566A23858C50; Tue, 29 Mar 2022 18:48:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 566A23858C50 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([79.251.15.188]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MdNY2-1o8be80jz6-00ZOLP; Tue, 29 Mar 2022 20:48:44 +0200 Message-ID: <886bfd00-2ffb-8568-0920-ee48434c92ef@gmx.de> Date: Tue, 29 Mar 2022 20:48:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] PR fortran/50549 - should detect different type parameters in structure constructors Content-Language: en-US To: Tobias Burnus , fortran , gcc-patches Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <5a7fa9f6-7155-9dc6-d847-e44ccccb447a@codesourcery.com> <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com> From: Harald Anlauf In-Reply-To: <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SWz2419uyL37OB7vTHJWox1gM+/Lk6y2QXJ682xh6qaWuI0CX+5 saMSzhdCbYLK2aH8oPnd/NT4+/Xu4O0X7NdphlA4TjpLu5oHdxnBa2AYbQHi226XCsw2wCu 825NgV6er4snI9ANquS8buXKAuI5xVYh9OAOp7V3p00p2u8LLyKjJdGuLlIFxiXzKDN3Yuv E9+1x6az5cLRCdozG0i/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:WgwRPCT/od0=:qlqMCsr4xeDaiNVPgbcXm2 wahC/TTxmK93O7ZBAEPopp8j3KnHu8w1e7Edtp4aBtLRfezlJq4nfzdZ3h6Sg/vRjURBS9y95 WGUWZ7NMLA3HYWIhsJVcXw40oAWNqUJNAalXRTk0cHQuNUT9AmssO3z+ysbOVyq2ib3bo3Hh4 ZynZBMBhG6V1hHyvON/pnbbVPAHrv4YQ3hUvmEwNMcA/PbQv37YstTyeFpc/YeNAEydce/za7 QlV5yxAQ5JqY2fCnCVaZteZeMWIZL1eUfyE2ptm2RP8qRKjcMUx66n/vHMrmcf3q9yWwaR/Di 0S6mjgI9t399J5iuKlwf3ntrfXoUDxgqjLY625UwTXaf1htZZTptAfbNu6tftkQdf+8HJGsNj pXTWXfX+4rY1pv/lhpAUOg0dJtEvRjpxVXOHiZsh9bLdGcDh578dGZYwQvslxDlc7nCwLEIQf maytNmNgn8X7GbWw22k3H19TIkKUgSgb/nE6kkUhSMykaynHKDvyfJ5MeYvaNvwULAjC+Mx/p yUwGTxConUaARTVURq4+jxfiYyvaNgvY4L5oISn2+Cv2f4NSeNex4Y5kdtH9zPk5CXLJWuace zunXqq9lKmHRsdEexK2Q7wfUv4FBjzZQhrGUA+dw0e9R39xuqBH6HDs8ktQtMqprpUpAk3iz9 AabTQDhpVvY0hKDR4U4L5OB4QH8w9/ZE0IrbDmG6uTApjHBL3+p8A130gHVHgbEvNHIq5/tDo dGRF/NlxFY+p2v+j8rZeNt5z8576/dcgXe2AqAjJb5tDxzYD5QTuVIHX2/NtwQaTq0PJhiuI5 rqZ75Mhz9VciwUg6l9igA10ulwuegpeEkFzewoL4D95UJsTwnskPn5t4jD/I4pEZ90mEchWCj 2TWehd7IQwLSyP7uIcHvLR+GZB6XS3iSzJkRNDPOQTwcPkelKOby9u4m/9DkmKpCigz4Dmi0V 2sEUasL7TDksycnR4LrPI18GCKgEVom7KPMQPKOR9oP14qiLGE41FYLctPxetxVvupVXzBT5Y VEsShPyQTKwONuNOvpWaD2ESp1FIQAl+zheSHqpH1pzVL5UPfsnTPPlcLqvvuSifkPnEneK7s qZi3eGm/jCM8+U= X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 18:48:51 -0000 Hi Tobias, Am 29.03.22 um 09:14 schrieb Tobias Burnus: > Hi Harald, > > On 28.03.22 22:03, Harald Anlauf via Fortran wrote: >> All current cases of printing a HOST_WIDE_INT in gcc/fortran/ use >> 'sprintf', and I did not find any other use of %wd/%wu.=C2=A0 So the >> mentioned implementation is not really stressed yet... ;-) > > That's all your fault ;-) true; I'm pleading guilty for that one. > (Your commit > https://gcc.gnu.org/r12-3273-ge4cb3bb9ac11b4126ffa718287dd509a4b10a658 > did remove the only user.) I've now made good for it. ;-) > That's only a warning. Have you tried whether it works at runtime? > My bet is that it does! Yes, it did work, it was just the warning alerting me ... > Question: Do you build with --disable-bootstrap ? Or do you do a proper > bootstrap? ... because I did build with --disable-bootstrap to save on time for building the compiler on my local machine, and the system's default gcc is older. > Can you check & try again?=C2=A0 I don't mind getting a format warning w= ith > GCC < GCC 12. But with GCC 12 compiled (either installed compiler or > when bootstrapping) it should compile without errors. > > If you can confirm my suspicion, the patch LGTM. I've just pushed that version as https://gcc.gnu.org/g:0712f356374c2cf26015cccfa3141537e42cbb12 Sorry for the noise, and thanks for the review! Harald > Tobias From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 6DDDD3888821 for ; Tue, 29 Mar 2022 18:48:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6DDDD3888821 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nZGtd-0002rv-Ey for fortran@gcc.gnu.org; Tue, 29 Mar 2022 20:48:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PATCH] PR fortran/50549 - should detect different type parameters in structure constructors Date: Tue, 29 Mar 2022 20:48:42 +0200 Message-ID: <886bfd00-2ffb-8568-0920-ee48434c92ef@gmx.de> References: <5a7fa9f6-7155-9dc6-d847-e44ccccb447a@codesourcery.com> <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US In-Reply-To: <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2022 18:48:54 -0000 Message-ID: <20220329184842.aXd896C7IkIjCnRxYIOwnPCTrApPQSFpnfi7OFAtcfU@z> Hi Tobias, Am 29.03.22 um 09:14 schrieb Tobias Burnus: > Hi Harald, > > On 28.03.22 22:03, Harald Anlauf via Fortran wrote: >> All current cases of printing a HOST_WIDE_INT in gcc/fortran/ use >> 'sprintf', and I did not find any other use of %wd/%wu.  So the >> mentioned implementation is not really stressed yet... ;-) > > That's all your fault ;-) true; I'm pleading guilty for that one. > (Your commit > https://gcc.gnu.org/r12-3273-ge4cb3bb9ac11b4126ffa718287dd509a4b10a658 > did remove the only user.) I've now made good for it. ;-) > That's only a warning. Have you tried whether it works at runtime? > My bet is that it does! Yes, it did work, it was just the warning alerting me ... > Question: Do you build with --disable-bootstrap ? Or do you do a proper > bootstrap? ... because I did build with --disable-bootstrap to save on time for building the compiler on my local machine, and the system's default gcc is older. > Can you check & try again?  I don't mind getting a format warning with > GCC < GCC 12. But with GCC 12 compiled (either installed compiler or > when bootstrapping) it should compile without errors. > > If you can confirm my suspicion, the patch LGTM. I've just pushed that version as https://gcc.gnu.org/g:0712f356374c2cf26015cccfa3141537e42cbb12 Sorry for the noise, and thanks for the review! Harald > Tobias