From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 6192E3858C83; Wed, 15 Mar 2023 19:36:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6192E3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678909002; i=anlauf@gmx.de; bh=7vrh7u2jr6VEyeOVhF+ldrJ4t8XjFNLq7WOt03ZayPA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Iupn2LuC1OBO0p2p8nFxJQM1rPhb5Hc6Dx11qnkvpePff0/Oj3hg8/shsQZV3XJ/0 t9BjBiBa03F1wv4v5Xec9dOhQWM3KkPgkzoY2R52Hp6/fsSVJ9WTI5vCvHWKx34ini AIKadMBrT2VqLTGaJtMHpQNH/f28X0q+Kel9yB7Yglh+bT+1H0GvryEMX2jGtVbxxk XSZPOq1sj7KdJBOqbDtrQDIpG9YUMRvwkGBOXAwUPG3aotS8v8d+h1osT/gWK4vmhx tgnSvH+FrO+igEeB/ZV3E6D8ZkcytQijuWh0DSl7avzh8JKvOVTZt2u8/XymmF2wpp bRoaGLBJvEsSQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.80.197]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMXUD-1pv17F2zxP-00JdOe; Wed, 15 Mar 2023 20:36:42 +0100 Message-ID: <89b856a2-5e90-5858-44ae-ba22c8903697@gmx.de> Date: Wed, 15 Mar 2023 20:36:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Fortran: rank checking with explicit-/assumed-size arrays and CLASS [PR58331] To: Tobias Burnus , fortran Cc: gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <099717a7-2de0-c71a-f9fa-58095e691898@codesourcery.com> Content-Language: en-US From: Harald Anlauf In-Reply-To: <099717a7-2de0-c71a-f9fa-58095e691898@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:W3vHbj7j4VR7USkrxRkfxuyI6z/KY8xxjTbF9arUGP/XZ/pXx9r H/N9D/GMKFP47GtA0f3aAYn2H3s7LG0/uJsRhr9r6z9l+HTh18K/gRyWQqwacD7mG/X0+pM GgE+xtlvo7ZCz+s+vj2cApEIOl96xuP9Xv/8tb2La+ZPOhJ3SWNVs2JWTw+x+wesSF4JzX9 prLupopoAIEGZwuIgAhcg== UI-OutboundReport: notjunk:1;M01:P0:e1PZTcNVQjs=;pNx5K22Ef3ks5H3AO0/pxN1GOH3 ln0+IVx5RO6CCgdTJGEHW4Qznsg9bUh+7NG4cIfqsI3O7gW9fez9JMjqJ8FdXvKZVsXgeGL5x g24IQntrRcgdSw64Tfykab2gjHVZvKIgceHTt+5G/qZymaaxP/Mu8a8U0OJDdxiyyH3Heg1jK KoZheCBWC6nOhxc954I0l5q+/Xi69NdXU9CeR0SsJ/5dIiL13O9lxGtA6KS9DjIv1a+cKpZTz wj+c/fTWQlNm3KX4VT8fHe04DpUSPfTp+dMYQbmlmlGGXMLuJjQrvMe+Gtn7UOCGXVQ7OLBGm uWaDoLypOSJEBoaX+5GROHjFKt4+5UqsSKCZBDxE1h7xp7rWwtAhFEFzCGb7dozp3rpIPI+LD cNidZLHqol2YCUEYchc1UX/cNMyMRbAeCDV50XVVYd7sLJSXHUQCyctj36EhtUfvTtDkp7AfM ooVPn4w0rwIvCjBKUJvoYwQ5FTtebpVAFBMrbKk3DZu61jz+x+XZFcICQ7QlcH3yLMyb87D9U dOZjegRfWl4qHuMxMyCtI3SAS3SM8FWCK86Awh+SNw5rF4MrE8dIHKO1sV8RxNbQCrmUoTOqY qu5Peb/A48ZVrJsP32EkrOGAFL4VWq6GDKNpqYE0Kx+uyDIHsaeFLU+h4ltPPReII88idII68 gsiHdZtQTPR7rHBffYUC7EQlN1eyolmdtM1KDuwb4Di9bGUP/+nwoi967yn1nte8spF8d+5b0 sPvV5E4/57Eg8wFgpTP8nx5xQ1b+QcBbFieRJxSw5s24Iu9kCotWUkAlYFOYCTXeKNx/Hi83t twWQTsfUo+azU5xCLfaI858bc8AZJjecJYCm11NXoHsm4OuY3ljR91ZpTeanEK/iwHMp/ebLq 7EZ5D17zeNDqgiOtk9upRdG3vXLs0d/39SWQxS2//Uwh0JTcgauRz57rhnUzclBpPA+h4UagC M0HXcfLMRECmKG4LnE0+o1ivb+8= X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tobias, Am 15.03.23 um 10:10 schrieb Tobias Burnus: > Hi Harald, > > On 14.03.23 20:38, Harald Anlauf wrote: >> The testcase covers only non-coarray cases, as playing with >> coarray variants hit pre-exisiting issues in gfortran that >> are very likely unrelated to the interface checks. > I concur (but would not rule out additional interface issues). More testing seems to mostly uncover issues later on in trans*.cc, e.g. when passing type to class. I'll open a PR on this as a followup. >> I consider this rather as post 13-release stuff. > In any case, the coarray issue can be fixed separately. And I think > post-GCC-13 makes sense. Good. >> Regtested on x86_64-pc-linux-gnu.=C2=A0 OK for mainline? > Thanks =E2=80=93 LGTM! >> +=C2=A0 formal_as =3D formal->ts.type =3D=3D BT_CLASS ? CLASS_DATA (for= mal)->as >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 : formal->as; >> + > > (Jakub remarks for such code that some editor (emacs?), he does not use, > mis--auto-indent such a code - and proposes to add a parentheses > around the right-hand side of the assignment.) Ah, adding parentheses helps! I've reformatted this block accordingly. Pushed as: https://gcc.gnu.org/g:901edd99b44976b3c2b13a7d525d9e315540186a > * * * > > I also wonder whether we need some run-time testcase. The interface > check now works and I also tend to write dg-do-compile testcases, but > given what can go wrong with all the array descriptor, class etc > handling, we may want to ensure it works at run time. =E2=80=93 Thoughts= ? If you comment out the lines with dg-error, the code compiles and seems to run fine here. I've even found cases where passing array sections works correctly here and with current Intel it does not ;-) I'd prefer to postpone more elaborate run-time tests until we have more non-ICEing related code. Thanks, Harald > (That's independent of the patch it and could be done as follow up, if > it deemed reasonable. The included testcase is surely compile-only as it > has dg-error checks.) > > Tobias > > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955 >