From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id D8CD93858D39; Sat, 20 Jan 2024 19:52:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D8CD93858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D8CD93858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705780363; cv=none; b=lWw8chaGPDAn263h4I27dhDaQ0JJV9zi3iAIj1od0P8dssjuXfQyUG+WmbswhRwQa8IQe0p/jSe0/W0Maaf+Q/t8DaDiBMI3n4tBNDhWjGzO/r0j46eKGmVnXc6KtzuxWco1+to4YPTvbIO+MqbCh52cSUrMbk7SE6mdWVmAXYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705780363; c=relaxed/simple; bh=/YqnoBa9Vdg56SrqG5x5Im96EeRl68tTC/8eqGFFT6g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=LhoplM4+EISM9RrnVZ5Guc0IzwEqYTXkEX97SoJPU51mOD3IJP30whCCGgg0TV4DL26RiOSTJFhScE6kmZ0RGvuzUtVP7OHhh9V8cVo9BNC66FENUMA13yAdpUYC0+n/gxynMaI76sIskSCLlqABu0W03QxwVWcHcYI18+vgy6g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d740488b47so81585ad.1; Sat, 20 Jan 2024 11:52:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705780360; x=1706385160; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=dYiKamvxrz+myyJdMjl7j8/CUF9o79orjWmt1Y1+kok=; b=RjnPlZouox5VCSVB5odaSd1aALnsjJt20anyzE7Vb+0GQTbr/HKcijuaSt9ci1tWVu XSlWY6kmPJXMRfOQGHAf3Ziqts1epkMtYob+YVUeCtcBmsLuq4zoZuyJqDgaIQaYahTs GJE2ArHV4fAsa7hAsb1YUMl6xrjNfzdi/z3S9Vao/v+5H2ssADMA2yU8kPnnPFjm4cql eErOWNFhxr3PnZrFRBGoh87VSvZK9a1haINms5M8doijBfIFIMRuoLuI5jOdCWz09odu q2RiV75sZ2OZcAV/CS8AZJiNW/Dynl2mI2WlDdTeftxiXeJwarmexRuEojHxVsG4wJKF JO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705780360; x=1706385160; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dYiKamvxrz+myyJdMjl7j8/CUF9o79orjWmt1Y1+kok=; b=eLOJ/Vi55UNx1yPYvCVcxlKG/bK0ZZLS8GR72Z4bFvYdcs7wmT7MYQS0A+H2Fqbmu6 PpEuc7NLMwC5ajiEX2FBiwrE8ZDRJEoHd3zx6cKN8JzJaEUqgh4+NHG2d/ilALqd1gOm SnBjn0CoiVv9u/HKTEUWH0Ng9QwCjAg9mjD3TIS6G1ahW/8Uq5b1hbXhHiTR0e30clRb RF9OnErC3aR7odMy/7fA0fiIubSfxezeOBRe8WXjUBAS3Ir4wu2Ywtutj//DtEOosP+/ l14navKuuESZlL7yJLiM66OW583NB177h9CnaBcozPe1cwxmN00pysE4BUswtzls3Y92 FsUw== X-Gm-Message-State: AOJu0Yy63T074rUEi2VbmvS6e2VHHAXYNgEVpQUvbPH2n6RKxHGTVURL SX3anEHi4dvbnNeQuZBU/qdR+vOjFLX6/5DmFnNl/RbB4bIlK7uG X-Google-Smtp-Source: AGHT+IGYx50wuL4l49joP0DouJUpbkwFkqsusM1DZRbTrzh9VYFXKP7SGANaUV935vgb8qe0sel3QA== X-Received: by 2002:a17:902:ee84:b0:1d4:3abc:29e2 with SMTP id a4-20020a170902ee8400b001d43abc29e2mr4039261pld.0.1705780359658; Sat, 20 Jan 2024 11:52:39 -0800 (PST) Received: from [192.168.1.24] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id sw15-20020a17090b2c8f00b0028c1a5aafe5sm6402640pjb.14.2024.01.20.11.52.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jan 2024 11:52:39 -0800 (PST) Message-ID: <8ca389a5-ab1b-434d-9e99-bee22b132fe1@gmail.com> Date: Sat, 20 Jan 2024 11:52:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: PR82943 - Suggested patch to fix Content-Language: en-US From: Jerry D To: Alexander Westbrooks , Harald Anlauf Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <55ac674d-468c-d4f5-e45e-190b25202412@gmx.de> <300b5533-685e-45a0-af07-c37884ba604f@gmail.com> Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: <300b5533-685e-45a0-af07-c37884ba604f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/20/24 11:08 AM, Jerry D wrote: > On 1/20/24 10:46 AM, Alexander Westbrooks wrote: >> Hello and Happy New Year! >> >> I wanted to follow up on this patch I made to address PR82943 for >> GFortran. Has anyone had a chance to review it? >> >> Thanks, >> >> Alexander Westbrooks >> > > Inserting myself in here just a little bit.  I will apply and test today > if I can. Paul is unavailable for a few weeks. Harald can chime in. > > Do you have commit rights for gcc? > > Your efforts are appreciated. > > Regards, > > Jerry > > > I did send you an invite to our Mattermost workspace. I did apply your patch. Some comments. The ChangeLog files are auto generated so do not get manually changed with a patch. The push process to the gcc git repository will generate those from the git commit log. If the git commit log is not formatted correctly the push will be rejected. The patch attempts to create a PDT_33.f03 test case. There is one already there so probably rename that one. In resolve.cc There was a compile error that looked like an extra '&&' in the conditional. I deleted that and all compiled ok and all regression tested OK, including your new test cases and the existing PDT_33.f03 case. I did not try your new test case yet for PDT_33. So next steps are walk you through using the git scripts to make commits with the logs formatted correctly. (assuming no one else chimes in with any other comment about code changes themselves.. Regards, Jerry