From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 80F113858C5E; Wed, 18 Oct 2023 10:56:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80F113858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80F113858C5E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.180 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697626572; cv=none; b=XYXZIN/XwqCgJcyR8j/wPT63dzF18oHiiIGyymPs0C9iNi9mD4iH/nLQqNYwUXDVHAuQmK1SBTybZ4DjtAHUvGPosfTkg7F7oEhIR/XDMUjEC85CqZsGr6quApjc7tkqma15Fhd0uEhTcZ9XSqU0UTSHeyc0Xus+8bdjb4Purr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697626572; c=relaxed/simple; bh=nBOoeW4wU76fUrr1Hy9NVue1IeDl9HxJZDSRFQILU+o=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=wA7HNptqqIKSPs3KF/MBn1ked5sqvNZqPEA6JRfJJEY1YasvZtwadqn87qy4Cx++ZdEwRkzQJp24BKR3dFVNGM3YpAc26tscPkxki3r4gZyxSP8Fo1GjEWMjpdetDFfoAZWPDXGju7ubxxPTiGKn/xKRBhX1rDF2rUYTSU49cE0= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: fRPms5tKR3GjqizeYAj8nA== X-CSE-MsgGUID: fBbxOk2ASay5ukcPDZuHyQ== X-IronPort-AV: E=Sophos;i="6.03,234,1694764800"; d="diff'?scan'208";a="19984684" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 18 Oct 2023 02:56:08 -0800 IronPort-SDR: ERMm3dQ7rq5D3gM+3EsC0nkR88p3Ei2lIH6wEYeUVs3Slif4/XsIB8Y/XRxqnisETXGqUbtoiN AQu+ugJwbtRnf3bFYKvuTtLqoQmV9np/399U1JYRoRHg7ZN45fl3vzzdu5VLWF8cnRjsPI889B LYP90KyUdGH77htPOec/ho86CIA+iMFwxclT9efXYN7B3GLYxFomBZKfG5CluFXJ978QiqcvLD zCqu9T2uxYCL+G4uYsxMHvtm5+cTS8ZENSD+c0qtkLBfUi/HHpXEjx12AfACtenkibOa65J4Mp KJ4= Content-Type: multipart/mixed; boundary="------------QWCnQxBPoCfVsykWbmCQD0RN" Message-ID: <8d407d7b-c546-4454-92c1-707ef00f0ba0@codesourcery.com> Date: Wed, 18 Oct 2023 12:56:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [Patch] OpenMP: Avoid ICE with LTO and 'omp allocate (was: [Patch] Fortran: Support OpenMP's 'allocate' directive for stack vars) Content-Language: en-US To: Jakub Jelinek , CC: , Thomas Schwinge References: <457ea120-5cca-48e0-89d6-c3eab4234b61@codesourcery.com> <7f16971c-ff06-4e48-85e2-5b38828b7bc2@codesourcery.com> <87wmvkuwdv.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------QWCnQxBPoCfVsykWbmCQD0RN Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 18.10.23 11:36, Jakub Jelinek wrote: > On Wed, Oct 18, 2023 at 11:12:44AM +0200, Thomas Schwinge wrote: >> +FAIL: gfortran.dg/gomp/allocate-13.f90 -O (internal compiler er= ror: tree code 'statement_list' is not supported in LTO streams) > Any references to GENERIC code in clauses etc. should have been gimplifie= d > or cleared during gimplification, we shouldn't support STATEMENT_LIST > in LTO streaming. We only needed the statement list as aid during the gimplify.cc handling of GOMP_alloc/GOMP_free for Fortran. How about just remove_attribute it in that case? As discussed, as DECL_ATTRIBUTE gets added from the left to the DECL_CHAIN, there shouldn't be a problem of introducing shared trees; note that 'omp allocate' itself is added per DECL, i.e. it does not introduce sharing itself, either. Tested with x86-64-gnu-linux. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------QWCnQxBPoCfVsykWbmCQD0RN Content-Type: text/x-patch; charset="UTF-8"; name="fix-lto.diff" Content-Disposition: attachment; filename="fix-lto.diff" Content-Transfer-Encoding: base64 T3Blbk1QOiBBdm9pZCBJQ0Ugd2l0aCBMVE8gYW5kICdvbXAgYWxsb2NhdGUnCgpnY2MvQ2hh bmdlTG9nOgoKCSogZ2ltcGxpZnkuY2MgKGdpbXBsaWZ5X2JpbmRfZXhwcik6IFJlbW92ZSAi b21wIGFsbG9jYXRlIiBhdHRyaWJ1dGUKCXRvIGF2b2lkIHRoYXQgYXV4aWxsYXJ5IHN0YXRl bWVudCBsaXN0IHJlYWNoZXMgdG8gTFRPLgoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VMb2c6CgoJ KiBnZm9ydHJhbi5kZy9nb21wL2FsbG9jYXRlLTEzYS5mOTA6IE5ldyB0ZXN0LgoKIGdjYy9n aW1wbGlmeS5jYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTggKysrKysr KystLS0tLQogZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9nb21wL2FsbG9jYXRlLTEzYS5m OTAgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDQ1 IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ2NjL2dpbXBs aWZ5LmNjIGIvZ2NjL2dpbXBsaWZ5LmNjCmluZGV4IDljNjE3YzIxMzgxLi4yMmZmMTA3NWFi YiAxMDA2NDQKLS0tIGEvZ2NjL2dpbXBsaWZ5LmNjCisrKyBiL2djYy9naW1wbGlmeS5jYwpA QCAtMTQyNiw3ICsxNDI2LDggQEAgZ2ltcGxpZnlfYmluZF9leHByICh0cmVlICpleHByX3As IGdpbXBsZV9zZXEgKnByZV9wKQogCQkgICAgICBERUNMX0FUVFJJQlVURVMgKHYpCiAJCQk9 IHRyZWVfY29ucyAoZ2V0X2lkZW50aWZpZXIgKCJvbXAgYWxsb2NhdGUgdmFyIiksCiAJCQkJ ICAgICBidWlsZF90cmVlX2xpc3QgKE5VTExfVFJFRSwgdCksCi0JCQkJICAgICBERUNMX0FU VFJJQlVURVMgKHQpKTsKKwkJCQkgICAgIHJlbW92ZV9hdHRyaWJ1dGUgKCJvbXAgYWxsb2Nh dGUiLAorCQkJCQkJICAgICAgIERFQ0xfQVRUUklCVVRFUyAodCkpKTsKIAkJICAgICAgdG1w ID0gYnVpbGRfZm9sZF9pbmRpcmVjdF9yZWYgKHYpOwogCQkgICAgICBUUkVFX1RISVNfTk9U UkFQICh0bXApID0gMTsKIAkJICAgICAgU0VUX0RFQ0xfVkFMVUVfRVhQUiAodCwgdG1wKTsK QEAgLTE0NzMsNyArMTQ3NCwxMiBAQCBnaW1wbGlmeV9iaW5kX2V4cHIgKHRyZWUgKmV4cHJf cCwgZ2ltcGxlX3NlcSAqcHJlX3ApCiAJCQkgYXQgdGhlIHRvcCwgdW5sZXNzIGFuIGFsbG9j YXRvciBvciBzaXplIGV4cHJlc3Npb24KIAkJCSByZXF1aXJlcyB0byBwdXQgaXQgYWZ0ZXJ3 YXJkOyBub3RlIHRoYXQgdGhlIHNpemUgaXMKIAkJCSBhbHdheXMgbGF0ZXIgaW4gZ2VuZXJh dGVkIGNvZGU7IGZvciBzdHJpbmdzLCBubwotCQkJIHNpemUgZXhwciBidXQgc3RpbGwgYW4g ZXhwciBtaWdodCBiZSBhdmFpbGFibGUuICAqLworCQkJIHNpemUgZXhwciBidXQgc3RpbGwg YW4gZXhwciBtaWdodCBiZSBhdmFpbGFibGUuCisJCQkgQXMgTFRPIGRvZXMgbm90IGhhbmRs ZSBhIHN0YXRlbWVudCBsaXN0LCAnc2wnIGhhcworCQkJIHRvIGJlIHJlbW92ZWQ7IGRvbmUg c28gYnkgcmVtb3ZpbmcgdGhlIGF0dHJpYnV0ZS4gICovCisJCSAgICAgIERFQ0xfQVRUUklC VVRFUyAodCkKKwkJCT0gcmVtb3ZlX2F0dHJpYnV0ZSAoIm9tcCBhbGxvY2F0ZSIsCisJCQkJ CSAgICBERUNMX0FUVFJJQlVURVMgKHQpKTsKIAkJICAgICAgdHJlZSBzbCA9IFRSRUVfUFVS UE9TRSAoVFJFRV9DSEFJTiAoVFJFRV9WQUxVRSAoYXR0cikpKTsKIAkJICAgICAgdHJlZV9z dG10X2l0ZXJhdG9yIGUgPSB0c2lfc3RhcnQgKHNsKTsKIAkJICAgICAgdHJlZSBuZWVkbGUg PSBOVUxMX1RSRUU7CkBAIC0xNjMxLDE2ICsxNjM3LDE0IEBAIGdpbXBsaWZ5X2JpbmRfZXhw ciAodHJlZSAqZXhwcl9wLCBnaW1wbGVfc2VxICpwcmVfcCkKIAkgICYmICFpc19nbG9iYWxf dmFyICh0KQogCSAgJiYgREVDTF9DT05URVhUICh0KSA9PSBjdXJyZW50X2Z1bmN0aW9uX2Rl Y2wpCiAJewotCSAgdHJlZSBhdHRyOwogCSAgaWYgKGZsYWdfb3Blbm1wCiAJICAgICAgJiYg REVDTF9IQVNfVkFMVUVfRVhQUl9QICh0KQogCSAgICAgICYmIFRSRUVfVVNFRCAodCkKLQkg ICAgICAmJiAoKGF0dHIgPSBsb29rdXBfYXR0cmlidXRlICgib21wIGFsbG9jYXRlIiwKLQkJ CQkJICAgIERFQ0xfQVRUUklCVVRFUyAodCkpKSAhPSBOVUxMX1RSRUUpCi0JICAgICAgJiYg VFJFRV9DSEFJTiAoVFJFRV9WQUxVRSAoYXR0cikpID09IE5VTExfVFJFRSkKKwkgICAgICAm JiBsb29rdXBfYXR0cmlidXRlICgib21wIGFsbG9jYXRlIiwgREVDTF9BVFRSSUJVVEVTICh0 KSkpCiAJICAgIHsKIAkgICAgICAvKiBGb3IgRm9ydHJhbiwgVFJFRV9DSEFJTiAoVFJFRV9W QUxVRSAoYXR0cikpIGlzIHNldCwgd2hpY2gKLQkJIGNhdXNlcyB0aGF0IHRoZSBHT01QX2Zy ZWUgY2FsbCBpcyBhbHJlYWR5IGFkZGVkIGFib3ZlLiAgKi8KKwkJIGNhdXNlcyB0aGF0IHRo ZSBHT01QX2ZyZWUgY2FsbCBpcyBhbHJlYWR5IGFkZGVkIGFib3ZlOworCQkgYW5kICJvbXAg YWxsb2NhdGUiIGlzIHJlbW92ZWQgZnJvbSBERUNMX0FUVFJJQlVURVMuICAqLwogCSAgICAg IHRyZWUgdiA9IFRSRUVfT1BFUkFORCAoREVDTF9WQUxVRV9FWFBSICh0KSwgMCk7CiAJICAg ICAgdHJlZSB0bXAgPSBidWlsdGluX2RlY2xfZXhwbGljaXQgKEJVSUxUX0lOX0dPTVBfRlJF RSk7CiAJICAgICAgdG1wID0gYnVpbGRfY2FsbF9leHByX2xvYyAoZW5kX2xvY3VzLCB0bXAs IDIsIHYsCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2dvbXAvYWxs b2NhdGUtMTNhLmY5MCBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZ29tcC9hbGxvY2F0 ZS0xM2EuZjkwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi40YjI5 N2NkYjRhYQotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcv Z29tcC9hbGxvY2F0ZS0xM2EuZjkwCkBAIC0wLDAgKzEsMzQgQEAKKyEgeyBkZy1kbyBjb21w aWxlIHsgdGFyZ2V0IGx0byB9IH0KKyEgeyBkZy1hZGRpdGlvbmFsLW9wdGlvbnMgIi1mbHRv IiB9CisKKyEgU2FtZSBhcyBhbGxvY2F0ZS0xMy5mOTAgYnV0IGNvbXBpbGVkIHdpdGggLWZs dG8uCisKKyEgVGhpcyB3YXMgZmFpbGluZyBiZWZvcmUgYXMgdGhlIHN0YXRlbWVudCBsaXN0 LAorISB1c2VkIGZvciBwbGFjaW5nIHRoZSBHT01QX2FsbG9jL0dPTVBfZnJlZSBsZWFrZWQK KyEgdGhyb3VnaCB0byBMVE8uCisKK21vZHVsZSBtCisgIGltcGxpY2l0IG5vbmUKKyAgISRv bXAgcmVxdWlyZXMgZHluYW1pY19hbGxvY2F0b3JzCitjb250YWlucworc3Vicm91dGluZSBm ICgpCisgICEkb21wIGRlY2xhcmUgdGFyZ2V0CisgIGludGVnZXIgOjogdmFyCisgICEkb21w IGFsbG9jYXRlKHZhcikKKyAgdmFyID0gNQorZW5kCisKK3N1YnJvdXRpbmUgaCAoKQorICAh JG9tcCB0YXJnZXQKKyAgICEkb21wIHBhcmFsbGVsCisgICAgISRvbXAgc2luZ2xlCisgICAg ICBibG9jaworICAgICAgIGludGVnZXIgOjogdmFyMig1KQorICAgICAgICEkb21wIGFsbG9j YXRlKHZhcjIpCisgICAgICAgdmFyMigxKSA9IDcKKyAgICAgIGVuZCBibG9jaworICAgICEk b21wIGVuZCBzaW5nbGUKKyAgICEkb21wIGVuZCBwYXJhbGxlbAorICAhJG9tcCBlbmQgdGFy Z2V0CitlbmQKK2VuZCBtb2R1bGUK --------------QWCnQxBPoCfVsykWbmCQD0RN--