From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 942163857702 for ; Mon, 19 Jun 2023 21:34:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 942163857702 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687210466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNEdy8GIPNBM0Zv/XSp6WDZuTqBKfHTKFCQJUPeCMag=; b=afC5zQkS7HL0wNFe8RKSwfs+vMamHsAcTlbjsxV45OqhfmbiYD++vtzR3HHtfNazBcvfOw frpblIHVNOIdsbPz5td6W2Lads6EyGLYQZPGY6kRlTyzoLqZoEzD8unNuZLR34TVLMuERy LqriUKazsK99J1LpgOdwOoHj9FV/wC4= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-YoprBipWMlWqIN4vQvOkBw-1; Mon, 19 Jun 2023 17:34:24 -0400 X-MC-Unique: YoprBipWMlWqIN4vQvOkBw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-763aba47570so30758785a.3 for ; Mon, 19 Jun 2023 14:34:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687210464; x=1689802464; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PNEdy8GIPNBM0Zv/XSp6WDZuTqBKfHTKFCQJUPeCMag=; b=TJT2CnBO6QHSYgkKvFWS4YDORoFxHOsC49n1JyuaUuyFjdOIzGc7fEhnH3gFu34pcW oNViUsE1qtTwvsoIvTSSOxzBU9aYSJ3b7OBC7a4hAe077jLjp5z2VLAcAX5KCC1zuGvl iDySxA23IlSZOanwlDlr0zXBgTWC/u8N7RiYXB/UcN8z+UOXlfsvaDtWMwNdu4YQj+Zp waTRUWxM4ebSLd1JE83JhHJGlkrtcRR1VxgIYKPwLJqGqfIVUIr9v5s2225ZUYpYmuob t65NkmbqnEHOlWrHLSaHsgmnnGiEHUN8jCGdXt5iYLShei8RHYq7sv+8SW4wKknSf9EP +Zig== X-Gm-Message-State: AC+VfDyt0goz+xl+ie4aiB6dq0leME3JlHq65sq7Zp4vldLIXl0TQ5pd K6B822TcJLS/o7LtSPrqVhHmnCc39koaE4jF1OrgMZ2hAEh4C7TGthHNPL0DDexYUzHDsBozuFc sSjUvaHcJ8Q9o X-Received: by 2002:a05:620a:4889:b0:763:9bca:5ced with SMTP id ea9-20020a05620a488900b007639bca5cedmr3315904qkb.20.1687210464346; Mon, 19 Jun 2023 14:34:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6iarr2PrICXjaRn1SnESBWtYvz/gHFAwZgMCjdIuGAYYubAr7+PV4pcd85HLqogR3uTL7HUg== X-Received: by 2002:a05:620a:4889:b0:763:9bca:5ced with SMTP id ea9-20020a05620a488900b007639bca5cedmr3315890qkb.20.1687210464115; Mon, 19 Jun 2023 14:34:24 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id i28-20020a05620a145c00b0075edc88457asm319777qkl.135.2023.06.19.14.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 14:34:23 -0700 (PDT) Message-ID: <8e347f55-8102-a2a0-a98d-7d3155d1ea8a@redhat.com> Date: Mon, 19 Jun 2023 17:34:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 1/4] libcpp: reject codepoints above 0x10FFFF To: Ben Boeckel , gcc-patches@gcc.gnu.org Cc: nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230606205025.3164738-1-ben.boeckel@kitware.com> <20230606205025.3164738-2-ben.boeckel@kitware.com> From: Jason Merrill In-Reply-To: <20230606205025.3164738-2-ben.boeckel@kitware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/6/23 16:50, Ben Boeckel wrote: > Unicode does not support such values because they are unrepresentable in > UTF-16. Pushed. > libcpp/ > > * charset.cc: Reject encodings of codepoints above 0x10FFFF. > UTF-16 does not support such codepoints and therefore all > Unicode rejects such values. > > Signed-off-by: Ben Boeckel > --- > libcpp/charset.cc | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/libcpp/charset.cc b/libcpp/charset.cc > index d7f323b2cd5..3b34d804cf1 100644 > --- a/libcpp/charset.cc > +++ b/libcpp/charset.cc > @@ -1886,6 +1886,13 @@ cpp_valid_utf8_p (const char *buffer, size_t num_bytes) > int err = one_utf8_to_cppchar (&iter, &bytesleft, &cp); > if (err) > return false; > + > + /* Additionally, Unicode declares that all codepoints above 0010FFFF are > + invalid because they cannot be represented in UTF-16. > + > + Reject such values.*/ > + if (cp >= 0x10FFFF) > + return false; > } > /* No problems encountered. */ > return true;