From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id E654B386CE72; Thu, 30 Jun 2022 09:58:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E654B386CE72 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.92,233,1650960000"; d="scan'208";a="80763993" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 30 Jun 2022 01:58:12 -0800 IronPort-SDR: OC7G/ep6Zle2u/4fXYLvwJ4R2eQe5KCoEvqHW/Sr3hYNLrTCAaeO/ozD7+C9gkRVyP2KaC3yE5 hp3L7qlfWSNpZ5bhBj/PmxGyqNbOQiqGuSByTap9PXE7rW3vGrTXOYe2hy0nOzydMY1Wov7+gc x8/+se1nXHOqkkK+TeZL1MEMRloIsFgPLXOVa+vCh58EJ/EXlgpH9u4C9H1/fvmMXolaqi7uZB 2Q0hrh84+/44L8MffVVtlpso6S63G7hiw7GPH7sqfkhjtMPjgrRYA6bqw7pmW5/DrAW+abyzdw JHk= Message-ID: <95dd0895-4c93-5f69-cfc0-aa054e7f18bb@codesourcery.com> Date: Thu, 30 Jun 2022 11:58:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Fortran: error recovery on invalid CLASS(), PARAMETER declarations [PR105243] Content-Language: en-US To: Harald Anlauf , fortran , gcc-patches References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 09:58:17 -0000 Dear Harald, dear all, On 29.06.22 21:54, Harald Anlauf via Fortran wrote: > a CLASS entity cannot have the PARAMETER attribute. > This is detected in some situations, but in others > we ICE because we never reach the existing check. > Adding a similar check when handling the declaration > improves error recovery. > > The initial patch is by Steve. I adjusted and moved > it slightly so that it also handles CLASS(*) > (unlimited polymorphic) at the same time. Shouldn't you then also acknowledge him, e.g. via Co-authored-by? > Regtested on x86_64-pc-linux-gnu. OK for mainline? OK. Thanks for the patch! > This patch actually addresses multiple PRs, some of > which are marked as regressions. As I consider the > patch safe, I would like to backport to open branches > as far as it seems appropriate. Fine with me. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955