From: Jerry D <jvdelisle2@gmail.com>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: fix ICE in compare_bound_int [PR108527]
Date: Sat, 28 Jan 2023 11:26:07 -0800 [thread overview]
Message-ID: <96e7e25c-7653-2a30-e3e8-21b75bb3f1d3@gmail.com> (raw)
In-Reply-To: <trinity-17ca0330-53b9-466e-b5f4-dcc7526b27bb-1674596893254@3c-app-gmx-bs66>
On 1/24/23 1:48 PM, Harald Anlauf via Fortran wrote:
> Dear all,
>
> when checking expressions for array sections, we need to ensure
> that these use only type INTEGER. However, it does not make sense
> to generate an internal error when encountering wrong types,
> but rather take the ordinary route of error recovery.
>
> The initial fix was provided by Steve.
>
> While working on the same PR, I found that the comments related
> to the logic needed a minor adjustment, and the logic could be
> cleaned up to actually match the intended comment.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
> Thanks,
> Harald
>
Harald, this looks OK to me. Good for Mainline.
prev parent reply other threads:[~2023-01-28 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 21:48 Harald Anlauf
2023-01-28 17:13 ` *PING* " Harald Anlauf
2023-01-28 19:26 ` Jerry D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96e7e25c-7653-2a30-e3e8-21b75bb3f1d3@gmail.com \
--to=jvdelisle2@gmail.com \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).