From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 371803858D1E; Wed, 1 Nov 2023 20:12:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 371803858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 371803858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698869577; cv=none; b=bnoH0LsnMhA5yx5AVAQ5zcvCJRsqTIQkldxwot6BUFI/9Z7ERptbkcXeI11XOcxdZLDMEPBGo8iRCnp3ulADSZuF2tzY7QCv63wG+FiueLSnhixNo9RLWgWJC+Wlh9kOp4PgVPKsmiFtQeiHrKDfcOJdWj+KL3zmT5TR3GWKn2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698869577; c=relaxed/simple; bh=ubuv0W7Jk2/CkpXQbeZWP4OhrpDar3JEsSNquiR7RsM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=iwZ7WpqgWOxhfdlA26h8YVcGR/S2A9sD0ErmC/U+FRuu5y+ikQ4mAnnUA56GQaYkx9ZoRGloCC1Pl6VjE7RVySFjeBwf+XX0d7Ns0S7JGJhVlN3bvSJc2DoUIY451nzt1U4y4XmBfZNGu4TZ6bg9+KhaPWe6CYlf8c2y7RQM/68= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1698869565; x=1699474365; i=anlauf@gmx.de; bh=ubuv0W7Jk2/CkpXQbeZWP4OhrpDar3JEsSNquiR7RsM=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=qkWG1auCXxvc1ogL3M2Z5F0RgdEIw9baRfi60w4Xu6j7fk+VJokj4Ow2q+Tv7s2y y942Ah14KIelmIYxBfwsv88uXj8RAQP0AatWznMJOg/2g6Ojg/xy+tWkBmizx2DIo wdUDxsWURsLY21gTRutGO1yWtWQSXj6uFn+X5Yl5vBYebVaa8BTfKr4rBEhLeU+iT mimBf55OFL2ErSww+qVuABbJ/I5xamXNyUucsSsnzwYW7cAFNJ4wIBC/dM5WgmSS4 87bfhH3Y3ftlrOBYMHK7VLdFBlBK4B9s79kbRVPg68BOw4GkpRADvpYswiPn7RCbq 8JxA22TcTdON2ZlCww== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.89.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MOA3P-1qncLU14Lx-00OWRu; Wed, 01 Nov 2023 21:12:45 +0100 Message-ID: <97147ff1-9d5b-4f0c-8a28-22d454d0476c@gmx.de> Date: Wed, 1 Nov 2023 21:12:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch, fortran] PR98498 - Interp request: defined operators and unlimited polymorphic To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:b6L+c3ayLHPyKesptIcYh2/SlCme3G46cJLrDN3tsi3aqza74B6 hEqKIpjCFKpGGoLS//dj01bfmKWIDUkbz+plvDkOUWTXCUPm6oiVp5qQAP859w+JiHfADHR 1YHZJV56gZ+Xlo5k8pZ2XCv8UEtQdkzBTI9Ha+xv+NYm+Od8VdZMv7FrWv0ZBSigLGlZPf8 bwtaxaTEwHPUM9O730lXA== UI-OutboundReport: notjunk:1;M01:P0:WvxmcP6iCLo=;vzB8uA2H5LCEhdp6xQbmfb89qDU H3aT9IlmigiWPO4Ah6WGALDp9IASF4lO2gLEm1B07RZIQ4hF3EOhKag7a24UORDA/30zuHmuz RoPcRLexIUSEyAqaFHMjAjXkfp5Y7zvoX+9PDc7RxIT8wnPnpI2LdkxU5DTQ3a/aAt7tvfGOH aq2AmEEtEmPuk2I7vw5DZ8OmoQrjeEIlIaHR8XBuT3VKysy9sd23vSQwMsvRjWas21DQU0F9E QFNL9w27icKFFOgp+OozAz+eCzNRizRfA7tNjFPEizfSapt9YMogLtlFEHkfLNNnhEZOtK8mc D80SQOFdte/ehtTR+qlX2ufwfCnsyRhlaKtbN+irBOz7amkQ/rNG8C/59FqdbztUgxfwIt7Q5 XXlhvUHnI4bJ6njEbxOwnHBw8nCusQkeESuFNtAllTOvwRiPTc9oaqxFwXLquleNhSqEDUJvI EhVB+orBBReMbuMmqDcIUkGth+9onTGUf7u14en9eMvcsiY0lh6vJD4lHJgO6Xo+vfmaOXOPs WDBODduTvorLkBCBTbvu2YqYWxl0oPmYD9/nyB98IhLQn/1rZMkzZ7vUxGEoYHOpbDUUbXgmu Q5uwMJOKDM9H7sIz2IiPp9Ax4I12Rxd00Kpp0R5JOFeTtHDU6eVsWwHpPxjxXcmSFzq5tmp94 s94RfoNuSX2Y1/CWWjHaMQnOvGNldkjoZ08qwYvjzxeX/+wJZUBOgoWooqJQesushigfvlGcd MF7UXGSXCB2MnwSOviq2zuXrcUKARwCHNg4pWEthw/c2fa7eIpLKfMbl6QF7HOBsEDUhKioJM WklZPavMKFooHHSvXRwVNox80lIJsKyYhsfuyhnW2bVYLKeRIwEQLj9Byddj1OvI/nYb5hEVs GBAipvL1tz8ttHMsyrMniKAYppAjrJI+DuGfXjbg576xBhVobI3LowfgPIhrAGMNAWADtcokv HABumdXhVkPQoCGfYiejAGFIAkY= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, Am 01.11.23 um 19:02 schrieb Paul Richard Thomas: > The interpretation request came in a long time ago but I only just got > around to implementing it. > > The updated text from the standard is in the comment. Now I am writing > this, I think that I should perhaps use switch(op)/case rather than usin= g > if/else if and depending on the order of the gfc_intrinsic_op enum being > maintained. Thoughts? the logic is likely harder to parse with if/else than with switch(op)/case. However, I do not think that the order of the enum will ever be changed, as the module format relies on that very order. > The testcase runs fine with both mainline and nagfor. I think that > compile-only with counts of star-eq and star_not should suffice. I found other cases that are rejected even with your patch, but which are accepted by nagfor. Example: print *, ('a' =3D=3D c) Nagfor prints F at runtime as expected, as it correctly resolves this to star_eq. Further examples can be easily constructed. Can you have a look? Thanks, Harald > Regtests with no regressions. OK for mainline? > > Paul > > Fortran: Defined operators with unlimited polymorphic args [PR98498] > > 2023-11-01 Paul Thomas > > gcc/fortran > PR fortran/98498 > * interface.cc (upoly_ok): New function. > (gfc_extend_expr): Use new function to ensure that defined > operators using unlimited polymorphic formal arguments do not > override their intrinsic uses. > > gcc/testsuite/ > PR fortran/98498 > * gfortran.dg/interface_50.f90: New test. >