public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Toon Moene <toon@moene.org>
To: gfortran <fortran@gcc.gnu.org>
Subject: Fwd: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 05 Sep 2018 16:57:00 -0000	[thread overview]
Message-ID: <994a9ec6-2494-9a83-cc84-bd8a551142c5@moene.org> (raw)
In-Reply-To: <2ba94a85fe9c01c57e474a4cc6b7171cc0adb351.1536144068.git.ams@codesourcery.com>

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]




-------- Forwarded Message --------
Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 5 Sep 2018 12:51:19 +0100
From: ams@codesourcery.com
To: gcc-patches@gcc.gnu.org


Fortran STOP and ERROR STOP use a different function to print the "STOP" 
string
and the message string.  On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".

This patch fixes the problem by making estr_write use the proper Fortran 
write,
not C printf, so both parts are now output the same way.  This also ensures
that both parts are output to STDERR (not that that means anything on GCN).

2018-09-05  Kwok Cheung Yeung  <kcy@codesourcery.com>

	libgfortran/
	* runtime/minimal.c (estr_write): Define in terms of write.
---
  libgfortran/runtime/minimal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)



[-- Attachment #2: 0018-Fix-interleaving-of-Fortran-stop-messages.patch --]
[-- Type: text/x-patch, Size: 492 bytes --]

diff --git a/libgfortran/runtime/minimal.c b/libgfortran/runtime/minimal.c
index 8940f97..b6d26fd 100644
--- a/libgfortran/runtime/minimal.c
+++ b/libgfortran/runtime/minimal.c
@@ -196,7 +196,7 @@ sys_abort (void)
 #undef st_printf
 #define st_printf printf
 #undef estr_write
-#define estr_write printf
+#define estr_write(X) write(STDERR_FILENO, (X), strlen (X))
 #if __nvptx__
 /* Map "exit" to "abort"; see PR85463 '[nvptx] "exit" in offloaded region
    doesn't terminate process'.  */


       reply	other threads:[~2018-09-05 16:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2ba94a85fe9c01c57e474a4cc6b7171cc0adb351.1536144068.git.ams@codesourcery.com>
2018-09-05 16:57 ` Toon Moene [this message]
2018-09-05 17:15   ` Bernhard Reutner-Fischer
2018-09-05 18:11   ` Janne Blomqvist
2018-09-12 13:55     ` Andrew Stubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=994a9ec6-2494-9a83-cc84-bd8a551142c5@moene.org \
    --to=toon@moene.org \
    --cc=fortran@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).