From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4F76E3858404 for ; Tue, 19 Sep 2023 21:33:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F76E3858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695159219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H0KCA/ebLsj342P9JS8CxGN7zL52YLuOyXx1j6zUhWY=; b=ITt0IhvR04XpM9Fa3/kaqYpVw7ht0f4+dYviIRa+7I1rEoFFeWQ2QH2STbiX2/+Y4Feex3 CYLL6H4ggP/jQjY8Fu6HXowGWYUdh49gb3u2FfvH8CSUtJyBM+z73WCPKEFQs2oCAAnSC8 ouju2hzCzFwsHQg+oaOvzz+FKFXUsq8= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-a_N8TMG1Or68UGdUXvedPg-1; Tue, 19 Sep 2023 17:33:37 -0400 X-MC-Unique: a_N8TMG1Or68UGdUXvedPg-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6562692f945so60813486d6.0 for ; Tue, 19 Sep 2023 14:33:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695159216; x=1695764016; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H0KCA/ebLsj342P9JS8CxGN7zL52YLuOyXx1j6zUhWY=; b=ojHN2Mhnrmzylt5/aZ9ILuiqSn6uMfFs6m8PCUMNU8nPj40Qsyn712+YL+l3swHZnN sUQqy1VBvhfWyQpZBkIy2cieuaxCnDuUC3E7XS2gcJ7vygk/FbTRJaMwRSGJFa9OZMON tR6aiyB5FGm5G5Egr0LhFH42eVTYAqy+9KocQNOLecJ4c+FDafAzRek8SBxH7ZlRAPSp EHzMeX0KM0nhEdaV7egDEtSK+E8Rrnt6yuUZmbqdQ5j0ik2MoFfyfc8BWx3kpSMoNV3b g5n+KnjsQDWKAes+owzvAgsDQoUU3aGIuZYpmjU5GAJWDhIge+0+Bj5Yi6B1pYylo63W kCAQ== X-Gm-Message-State: AOJu0Yy3QS97uuYi1itzT7g7N7Zt5Fqy4LOF9eMKZHMMzdmXitYPpa5g aoJ4anXh3K7JIYtHb3gWVERlTuFWgI/pMede6bomoLfm1tgphIwr1D1rMA/s/OL8I+Mx/fn9z/k blTBfy7AEze0S X-Received: by 2002:a05:6214:4507:b0:656:4ff8:691e with SMTP id oo7-20020a056214450700b006564ff8691emr639756qvb.46.1695159216461; Tue, 19 Sep 2023 14:33:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJgJesoBX/6/PH/F4oV66vbd71jhTvNm5R5RKfOrnTYxjQQ42P1wlubqLor+ps3z/ppcB9jA== X-Received: by 2002:a05:6214:4507:b0:656:4ff8:691e with SMTP id oo7-20020a056214450700b006564ff8691emr639742qvb.46.1695159216185; Tue, 19 Sep 2023 14:33:36 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id r28-20020a0cb29c000000b0063d038df3f3sm4694171qve.52.2023.09.19.14.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 14:33:35 -0700 (PDT) Message-ID: <99ce75f4-a654-581c-30f7-7fce16b8106e@redhat.com> Date: Tue, 19 Sep 2023 17:33:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v8 0/4] P1689R5 support To: Ben Boeckel , gcc-patches@gcc.gnu.org Cc: nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230901130407.259768-1-ben.boeckel@kitware.com> From: Jason Merrill In-Reply-To: <20230901130407.259768-1-ben.boeckel@kitware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/1/23 09:04, Ben Boeckel wrote: > Hi, > > This patch series adds initial support for ISO C++'s [P1689R5][], a > format for describing C++ module requirements and provisions based on > the source code. This is required because compiling C++ with modules is > not embarrassingly parallel and need to be ordered to ensure that > `import some_module;` can be satisfied in time by making sure that any > TU with `export import some_module;` is compiled first. > > [P1689R5]: https://isocpp.org/files/papers/P1689R5.html > > I've also added patches to include imported module CMI files and the > module mapper file as dependencies of the compilation. I briefly looked > into adding dependencies on response files as well, but that appeared to > need some code contortions to have a `class mkdeps` available before > parsing the command line or to keep the information around until one was > made. > > I'd like feedback on the approach taken here with respect to the > user-visible flags. I'll also note that header units are not supported > at this time because the current `-E` behavior with respect to `import > ;` is to search for an appropriate `.gcm` file which is not > something such a "scan" can support. A new mode will likely need to be > created (e.g., replacing `-E` with `-fc++-module-scanning` or something) > where headers are looked up "normally" and processed only as much as > scanning requires. > > FWIW, Clang as taken an alternate approach with its `clang-scan-deps` > tool rather than using the compiler directly. > > Thanks, > > --Ben > > --- > v7 -> v8: > > - rename `DEPS_FMT_` enum variants to `FDEPS_FMT_` to match the > associated flag > - memory leak fix in the `join` specfunc implementation (also better > comments), both from Jason > - formatting fix in `mkdeps.cc` for `write_make_modules_deps` assignment > - comments on new functions for P1689R5 implementation Pushed, thanks! Jason