public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Jerry D <jvdelisle2@gmail.com>, gfortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [libgfortran, patch] PR113223 NAMELIST internal write missing leading blank character
Date: Sun, 7 Jan 2024 20:28:55 +0100	[thread overview]
Message-ID: <9a1810ae-020a-47ed-bf41-42bd3903c0a6@gmx.de> (raw)
In-Reply-To: <647441f1-5c81-4ed2-a0bf-9e2f76b38969@gmail.com>

Hi Jerry!

On 1/7/24 19:40, Jerry D wrote:
> Committed as simple and obvious. Initial patch thanks to Steve.
>
> When using git gcc-commit-mklog how does one add in the coauthor?

% git help gcc-commit-mklog
...
   --co CO               Add Co-Authored-By trailer (comma separated)

However, I usually add this line manually later.

Regarding the format, have a look at existing log messages.

Cheers,
Harald

> The master branch has been updated by Jerry DeLisle
> <jvdelisle@gcc.gnu.org>:
>
> https://gcc.gnu.org/g:add995ec117d756e61d207041cd32f937c1a1cd9
>
> commit r14-6986-gadd995ec117d756e61d207041cd32f937c1a1cd9
> Author: Jerry DeLisle <jvdelisle@gcc.gnu.org>
> Date:   Sun Jan 7 10:22:19 2024 -0800
>
>      libgfortran: Emit a space at beginning of internal unit NML.
>
>      PR libgfortran/113223
>
>      libgfortran/ChangeLog:
>
>              * io/write.c (namelist_write): If internal_unit precede
> with space.
>
>      gcc/testsuite/ChangeLog:
>
>              * gfortran.dg/dtio_25.f90: Update.
>              * gfortran.dg/namelist_57.f90: Update.
>              * gfortran.dg/namelist_65.f90: Update.
>


      reply	other threads:[~2024-01-07 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07 18:40 Jerry D
2024-01-07 19:28 ` Harald Anlauf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a1810ae-020a-47ed-bf41-42bd3903c0a6@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jvdelisle2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).