From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from impout002.msg.chrl.nc.charter.net (impout002aa.msg.chrl.nc.charter.net [47.43.20.26]) by sourceware.org (Postfix) with ESMTPS id C02D2385481F; Fri, 19 Feb 2021 16:25:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C02D2385481F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=charter.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jvdelisle@charter.net Received: from [192.168.1.9] ([96.41.221.129]) by cmsmtp with ESMTPA id D8bIlX3fvrFe0D8bIlr5Dq; Fri, 19 Feb 2021 16:25:54 +0000 Authentication-Results: charter.net; none X-Authority-Analysis: v=2.3 cv=ObQs8SbY c=1 sm=1 tr=0 a=07pILqX15KmGv9ZXTMmBNA==:117 a=07pILqX15KmGv9ZXTMmBNA==:17 a=IkcTkHD0fZMA:10 a=TfjuIklQIUczQumsaRwA:9 a=QEXdDO2ut3YA:10 Subject: Re: *PING**2 Re: [Patch] Fortran: Fix coarray handling for gfc_dep_resolver [PR99010] (was: Re: [Patch] Fortran: Fix Array dependency with local coarrays [PR98913] To: Tobias Burnus , Thomas Koenig , Jorge D'Elia , Gfortran List , gcc-patches References: <121178681.597.1612108263047.JavaMail.zimbra@intec.unl.edu.ar> <9d298701-38a5-c2c5-1daf-7a2dad754369@netcologne.de> <4fc42e9c-676d-f3fc-57ab-f665a679bfbb@codesourcery.com> <7098734c-32bb-a5d0-1e72-015e33321dc9@netcologne.de> <5eab30e5-5322-bfee-349b-c6c7ec1fb47b@codesourcery.com> From: Jerry DeLisle Message-ID: <9a49eb49-fe5b-b624-d2fd-96ebba802048@charter.net> Date: Fri, 19 Feb 2021 08:25:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CMAE-Envelope: MS4wfMKWZkAGz/DbYqOEuNf5mdSup1t9v1miU2QZG/lc68Z41L1JLtEpm1OkwLnr7N+ezNGCioN/vMeb8lUtlSIfKAlhxBfKTzJm8syFL8ptCJkHzI93laBP TX859pHIjLfAWis6TlkGHrvaVNkyn3wk3NwX8RfwZv5EnmjgwqswtsVUbfZJuESqCXSP1W1TsQ2OzxkNcFaDAjWJStFP19FFBfWj6owv94htZBuoV5h50BdW BqO4gg6g9u5DxNroUJOAuCl144pafbweeNVVVYe92Ldi4YiR17Yn33DPnY9ED+4Snkij1AC2GZpk6GYtU/PPDQ== X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 16:25:56 -0000 On 2/19/21 1:33 AM, Tobias Burnus wrote: > > On 09.02.21 12:52, Tobias Burnus wrote: >> Hi all, hi Thomas, >> >> On 02.02.21 18:15, Tobias Burnus wrote: >>> I think I will do a combination: If 'identical' is true, I think I >>> cannot remove it. If it is false, it can be identical or nonoverlapping >>> – which makes sense. >> >> Well, it turned out that coarray scalars did not work; for them, >> the array ref consists only of the coindexed access: falling through >> then triggered as fin_dep == GFC_DEP_ERROR. >> >> To be more careful, I also removed the 'identical &&' check such that >> the first loop is now always triggered if coarray != SINGLE not only >> if identical – I am not sure whether it is really needed or whether >> falling though is the better solution (with updating the comment). >> >> I would be happy if someone could carefully check the logic – >> in the details, it is rather confusing. >> >> OK? >> Yes OK, thanks for patch. Jerry