Re: [Patch, fortran] PR97122 - Spurious FINAL ... must be in the specification part of a MODULE

[Harald Anlauf <anlauf@gmx.de>]

Hi Paul,

On 5/9/23 17:51, Paul Richard Thomas via Gcc-patches wrote:
> Hi All,
>
> Thanks to Steve Kargl for the fix. It caused finalize_8.f03 to fail because
> this testcase checked that finalizable derived types could not be specified
> in a submodule. I have replaced the original test with a test of the patch.
>
> Thanks also to Malcolm Cohen for guidance on this.
>
> OK for trunk?

the patch looks good to me.  However:

@@ -11637,8 +11637,9 @@ gfc_match_final_decl (void)
    block = gfc_state_stack->previous->sym;
    gcc_assert (block);

-  if (!gfc_state_stack->previous || !gfc_state_stack->previous->previous
-      || gfc_state_stack->previous->previous->state != COMP_MODULE)
+  if (gfc_state_stack->previous->previous
+      && gfc_state_stack->previous->previous->state != COMP_MODULE
+      && gfc_state_stack->previous->previous->state != COMP_SUBMODULE)
      {
        gfc_error ("Derived type declaration with FINAL at %C must be in
the"
                  " specification part of a MODULE");

I am wondering if we should keep the protection against a potential
NULL pointer dereference (i.e. gfc_state_stack->previous == NULL) for
possibly invalid code.  I have failed to produce a simple testcase,
but others may have "better" ideas.

I'll leave it to you to amend the patch or leave as is.

Thanks,
Harald


> Paul
>
> Fortran: Allow declaration of finalizable DT in a submodule [PR97122]
>
> 2023-05-09  Paul Thomas  <pault@gcc.gnu.org>
>     Steven G. Kargl  <kargl@gcc.gnu.org>
>
> gcc/fortran
> PR fortran/97122
> * decl.cc (variable_decl): Clean up white space issues.
> (gfc_match_final_decl): Declaration of finalizable derived type
> is allowed in a submodule.
>
> gcc/testsuite/
> PR fortran/97122
> * gfortran.dg/finalize_8.f03 : Replace testcase that checks
> declaration of finalizable derived types in submodules works.