From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 3FB333856DFB; Mon, 29 Aug 2022 20:49:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FB333856DFB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661806187; bh=lq2nc2V8oBlRE2LeXRDegqgH5ty1hM/ThxzIxy5Vqf8=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=VVlwZpOskGPH8o6cfqE+c65ymul7d3QWGvn2YNL9FAi918RvFXYMT5/GG3qGBr+03 Z8NXb3qiRhbMsQDsdchdn2aiQPPFcxDLosSi9vlXWdcJIO7iiLGF9tARiVlILIlrvW 6fzwAK5PUsuJzj7BtVLXw5vtaKVjMn8qv0nzxuxg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.81.4]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MysW2-1pOjiC3fYA-00vxFX; Mon, 29 Aug 2022 22:49:46 +0200 Message-ID: <9bd10855-42b9-c674-3cd5-4d0269ab213b@gmx.de> Date: Mon, 29 Aug 2022 22:49:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [Patch] OpenMP/Fortran: Permit end-clause on directive Content-Language: en-US To: Tobias Burnus , gcc-patches , Jakub Jelinek , fortran Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <821786f3-ac7b-01e3-a386-f7c082494022@codesourcery.com> From: Harald Anlauf In-Reply-To: <821786f3-ac7b-01e3-a386-f7c082494022@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wvgrV6wq5qJvmIEzmuFKKqTYODCjWPAAKf2YM0BynrgDTFsoiRe bSfhs6eMn7xC0L1BQXw5X6g6JTqjYTLfYuRV5+UodZGIF/gjK7yaIvBY5pCIBGX/Jb3HWgJ kLoRAZ61IbAPKVaFYrBML1ts9syz7hsy9B7+8iRW/eK6/t5D0LFkIPnDCBwHryyM97fE0vq AjTdkFW+ej9XaJwGXLBwg== X-UI-Out-Filterresults: notjunk:1;V03:K0:nqXy/2W0css=:CHN8/Drl+2gi9LptuuevfJ hXHWDTbJO2Lm38TsfkOXozvdB2YtdNz4xrQ2P9ND+XFJfDDzKkRJh4NNsDbxMrTY+ACyuppe3 8Kvejym9Tw4Iru11QEMAPF2KNrvF2vJY3uYm/X9rxWJPZe2t0VFPOAknF7pyQmoV9qdhXsz8T Kg8ugH3IpsQh5NTzV3a36Mv4NpDHFjO/mq+Ze2EZIT6aTjxIIHPR1kpqZs25gPXpDINRSbg0T Li0O7YbdFnsCvr3oH7tlU2KB2RwdoqSVDPQE4a50tc91apWgVMvA2KwZWC5uMrG0xh7bHm/4f 7iqxJr7Yh6u2bKgWLpLuATsJ146Lj4SHkfSm/W+bfl2RW7NtMHPBvdVM42yKL/Po8jE01o9xU fJ4ptIEuA8nHS3UcveYB7yO3350+bE1NtVbX6m3c7qAxk2t2VL1xe6R48dasJmJ4Ce0PA6xHX KdUx7BPXYSFRG0e8Ecenci60zK6HoJcuxCZyRiGrHzVtf9IJ4hjieCCSMB8AQb0X+YcSJT0ul fFxEz2SSDs2oRVjjYcft4c+2akrRtvE2SIHIieZIjDNpWizb89yaYAURj6sg+rFxFyVU0BGRa a9Jy0P+6B+Vv1nxNMwpEKpktIg1huKFJkakVPGR3M7V3m76RGzKYSiigf6OACTLFfJrNnegI7 ppHbLvO6J6KS7H0Mtf9g7QEmWUsqOkNMsGYTdEVjYRWKqJb1+O1PqoEBqOFSYTVjaMYdldg7X kX/E/6XLvc9Ujz2Hrg4e4e6nxrlexDzXqIuhdXJLV2YT85UmHEIAE5CmzZC7CTkjH44MIuE+6 tgtv56ecz73/Pj+dl8EmLKSi3re07vSVFJSS57kzeqBqbJyOzUmUs7CwrJsK6VX83+Em2+zbW gScG4WfJw/HJUmv9pJd2zhg0uXYQHwvbzcF7Y0EHVSZDgHzz4zkFcAJaXfVDLrNzyv0c3Jasv fc5Z5UDFjpnET1R7/Vov+rAdLxvscodsADqSwTt/skUVXtO9aOvRgyD4D5ZC6/4cgHykM8/rh X8rwvFj8svBJqIws+3n8A3negu3z6WLMtL5GuBUHSmbRHUz+EzpEaoFwgluTZdKbw67HwgiZ0 6GegmTdX1qg1m2GFQe4VCGWmydkZOqHj99K X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tobias, this is not really a review, but: Am 26.08.22 um 20:21 schrieb Tobias Burnus: > I did run into some issues related to this; those turned out to be > unrelated, but I end ended up implementing this feature. > > Side remark: 'omp parallel workshare' seems to actually permit 'nowait' > now, but I guess that's an unintended change due to the > syntax-representation change. Hence, it is now tracked as Spec Issue > 3338 and I do not permit it. > > OK for mainline? Regarding testcase nowait-4.f90: it has a part that tests for many formally correct uses, and a part that tests for many invalid nowait. Both parts seem to be giving reasonable coverage, so I wonder whether it would be beneficial to split this one into two subsets. It makes sense to have fewer but larger testcases in the testsuite, to keep the time for regtesting at bay, but I'm split here on this one - and yes, pun intended. Harald > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe = 201, > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > Registergericht M=C3=BCnchen, HRB 106955