public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Dominique d'Humières" <dominiq@lps.ens.fr>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: fortran@gcc.gnu.org, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
Date: Sat, 21 Nov 2015 20:22:00 -0000	[thread overview]
Message-ID: <A5584B50-6B18-4C81-9E89-800F7CDDA761@lps.ens.fr> (raw)

‘dm’ is actually not used, the building problem is fixed by the patch (I did not rearrange the nested ‘if’s)

--- ../_clean/gcc/fortran/simplify.c	2015-11-21 20:59:57.000000000 +0100
+++ gcc/fortran/simplify.c	2015-11-21 21:06:30.000000000 +0100
@@ -1792,7 +1792,6 @@ gfc_expr *
 gfc_simplify_cshift (gfc_expr *array, gfc_expr *shift, gfc_expr *dim)
 {
   gfc_expr *a, *result;
-  int dm;
 
   /* DIM is only useful for rank > 1, but deal with it here as one can
      set DIM = 1 for rank = 1.  */
@@ -1800,10 +1799,7 @@ gfc_simplify_cshift (gfc_expr *array, gf
     {
       if (!gfc_is_constant_expr (dim))
 	return NULL;
-      dm = mpz_get_si (dim->value.integer);
     }
-  else
-    dm = 1;
 
   /* Copy array into 'a', simplify it, and then test for a constant array.
      An unexpected expr_type causes an ICE.   */

Dominique

             reply	other threads:[~2015-11-21 20:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 20:22 Dominique d'Humières [this message]
2015-11-21 20:30 ` Steve Kargl
2015-11-22  8:51   ` Dominique d'Humières
2015-11-22 16:21     ` Steve Kargl
2015-11-22 18:06       ` Dominique d'Humières
  -- strict thread matches above, loose matches on Subject: below --
2015-11-20  0:58 Steve Kargl
2015-11-20  1:31 ` Steve Kargl
2015-11-20  3:16   ` Steve Kargl
2015-11-20 20:09 ` Steve Kargl
2015-11-21 10:41   ` Paul Richard Thomas
2015-11-21 16:27     ` Steve Kargl
2015-11-21 18:07       ` H.J. Lu
2015-11-21 18:20         ` Steve Kargl
2015-11-21 19:19           ` H.J. Lu
2015-11-21 19:26             ` Steve Kargl
2015-11-21 20:07               ` Steve Kargl
2015-11-21 22:26                 ` Eric Botcazou
2015-11-21 22:39                   ` Steve Kargl
2015-12-31 14:00                 ` Gerald Pfeifer
2015-12-31 16:13                   ` Steve Kargl
2015-11-21 18:23         ` Tim Prince

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A5584B50-6B18-4C81-9E89-800F7CDDA761@lps.ens.fr \
    --to=dominiq@lps.ens.fr \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).