From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 74EA4385800A; Wed, 12 Jan 2022 10:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74EA4385800A Received: by mail-wr1-x431.google.com with SMTP id q8so3242842wra.12; Wed, 12 Jan 2022 02:23:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=SXoPT6lLrmYozk3KS8ChFiRLcn57f4TFwCGQDrjSaKs=; b=6tdcqKCflZv9THpTeC2YqWwq6XyGLCq7+7VqfNle7WRbJM4KFV4PMjURF0qWaPyeV9 1e9Lgsbs8PSEptgxYFKabfLXhS8tOAAYP6ppFHyKnfjuLCihIZY4ow8Jc3J2PEiuIiDr SyOIaWz1oNO+pIsy0N3zKOVT6Gc9fpVB9yEHLCr7ZZtMDCKDeXfHmyqdEOoZysv/FNwV pLt8zP9o9chRM/0PkmKPqArmBkIDIWWAxsR3eGhRkl8fVTPLNetxGSomdTZlryMLg6e7 aLCO1RN+vYpA77pLccjTbmzFYW8j2Qo7fVow6Fu6i2Z0fsHleaUqT4sAlslLoa1AN4wL epOA== X-Gm-Message-State: AOAM531MYh7tpXWmheS/Q7sBk7I5kRqdXo6zU112KHXBEnDTQkHARNT6 XXEeCl0/+L/9AZKAyzTGLmuoW4uWM0I= X-Google-Smtp-Source: ABdhPJwEH3U+D2ChH2I7cppoErSYeAmErKbxriOfSqTT3kHltafv0ykkwN5oeCg//Avd2iv53nm+rw== X-Received: by 2002:a05:6000:14e:: with SMTP id r14mr1886574wrx.442.1641983028437; Wed, 12 Jan 2022 02:23:48 -0800 (PST) Received: from smtpclient.apple ([2a01:e34:ec28:8cb0:e1dd:9bbf:1db:ae3f]) by smtp.gmail.com with ESMTPSA id g5sm13107898wrd.100.2022.01.12.02.23.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jan 2022 02:23:43 -0800 (PST) From: FX Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_5EFF0F04-5A67-4AE7-8123-60A254DD9A26" Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [PATCH] Fortran: make IEEE_CLASS recognize signaling NaNs Date: Wed, 12 Jan 2022 11:23:43 +0100 In-Reply-To: <2AC9FA3C-2E70-4A5B-B612-FDF0E00BA845@gmail.com> Cc: Harald Anlauf , fortran@gcc.gnu.org, hjl.tools@gmail.com, schwab@suse.de To: gcc-patches@gcc.gnu.org References: <2F9F946D-C06C-4D3A-AD24-33913F040B3B@gmail.com> <2AC9FA3C-2E70-4A5B-B612-FDF0E00BA845@gmail.com> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jan 2022 10:23:50 -0000 --Apple-Mail=_5EFF0F04-5A67-4AE7-8123-60A254DD9A26 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, I can confirm that I don=E2=80=99t see this failure on a Debian = bullseye/sid (Linux 5.11.0-46, glibc 2.31-0ubuntu9.2) with a fresh = bootstrap of master: $ grep signaling testsuite/gfortran/gfortran.sum PASS: gfortran.dg/ieee/signaling_1.f90 -O0 (test for excess errors) PASS: gfortran.dg/ieee/signaling_1.f90 -O0 execution test PASS: gfortran.dg/ieee/signaling_1.f90 -O1 (test for excess errors) PASS: gfortran.dg/ieee/signaling_1.f90 -O1 execution test PASS: gfortran.dg/ieee/signaling_1.f90 -O2 (test for excess errors) PASS: gfortran.dg/ieee/signaling_1.f90 -O2 execution test PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -fomit-frame-pointer = -funroll-loops -fpeel-loops -ftracer -finline-functions (test for = excess errors) PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -fomit-frame-pointer = -funroll-loops -fpeel-loops -ftracer -finline-functions execution test PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -g (test for excess = errors) PASS: gfortran.dg/ieee/signaling_1.f90 -O3 -g execution test PASS: gfortran.dg/ieee/signaling_1.f90 -Os (test for excess errors) PASS: gfortran.dg/ieee/signaling_1.f90 -Os execution test It=E2=80=99s showing on some gcc-testresults for x86_64 and aarch64 = linux, so I=E2=80=99ll need someone (HJ, Andreas are in CC) to show me = what the error is. It may be related to the use of dg-options instead of = dg-additional-options in that testcase, so I pushed the attached fix. = I=E2=80=99ll check the test results mailing-list to see if it improved = things (or confirm when the error message is posted). FX --Apple-Mail=_5EFF0F04-5A67-4AE7-8123-60A254DD9A26 Content-Disposition: attachment; filename=test.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="test.patch" Content-Transfer-Encoding: 7bit commit 6b14100b9504800768da726dcb81f1857db3b493 Author: Francois-Xavier Coudert Date: 2022-01-12 11:19:37 +0100 Fortran: fix testcase compiler flags -fsignaling-nans is already passed by ieee.exp, so it's not needed. We must use dg-additional-options instead of dg-options, otherwise we override flags passed from ieee.exp. And we need to use -w because some options only make sense for the Fortran source. gcc/testsuite/ChangeLog: * gfortran.dg/ieee/signaling_1.f90: Adjust flags. diff --git a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 index a1403e6ce16..3d846fc1038 100644 --- a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 @@ -1,7 +1,9 @@ ! { dg-do run } ! { dg-require-effective-target issignaling } */ ! { dg-additional-sources signaling_1_c.c } -! { dg-options "-fsignaling-nans" } +! { dg-additional-options "-w" } +! the -w option is needed to make f951 not report a warning for +! the -fintrinsic-modules-path option passed by ieee.exp ! program test use, intrinsic :: iso_c_binding --Apple-Mail=_5EFF0F04-5A67-4AE7-8123-60A254DD9A26--