From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 7F7773858D33; Thu, 2 Mar 2023 00:39:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F7773858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso1064887pjs.3; Wed, 01 Mar 2023 16:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vvS1g8s/AcPt8Xr2rGM+nkieuB9kr3WfWIwHBu3VxB0=; b=S/i7XY+24PLR4DUieSqFwMRT4X3dPz/d2VKpfkiHSCGZ87u1I/wPFXmnDosGXJwfnU wk1LvqF4YxRe3xIr0u+YsWfG9EUuohiaWY9AUmmJ/U+YGFYVZ2sDCUQOIqDgKkBqWLqU EdxTARusdoeF/jf8MuwY4Yj4wmrs7NMG5NCwnxYjcXSKmVy5/Mcy1rGHtDRCioPZd3XE pBp9wdPA8rXOORir6G7HBwdDCblHOh3THqS42VHoNBFkFddYKcz4WJ6cLYpPl0g/eLnY LiKFV5ms93q7YLzw/gA22LHccZhKJw3CGWItkyWA5QWSQJCgA0I7byY7pe/lD0GRFdGA E8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vvS1g8s/AcPt8Xr2rGM+nkieuB9kr3WfWIwHBu3VxB0=; b=Atow/J3LdHT2TxFmfcA07YVz3EVsQvIPyk7EpypY/OmRN4yeNoMtbuLdrkzWtE3dU6 a7RoEBvYt4wTdNkkYLt22rhdKeQTCitigWBdKa2iWUnXSLOIb0gdETiNXSGvU3DP0HQ2 lVDkGuh2QZ2mXsWapMYallFsCqbtjqZpAiz49MSqTlBmtN+bEqPJnHU3jPyQGajtcXu5 vBueiv6oAxsMezbQhEcDSA2H1SCYeifcj3I7ym10hC7yRN5LOpwWPf9HdX5rzrhTCPbB yACsAv5UVxAUs7+Du5XNuhAFLNXDzHJqztDWsM2cl5nSQq9zY+Wq69Nx5oNb0yGcjNpK y81A== X-Gm-Message-State: AO0yUKVnQNI4u1VGLgOoGvS2KruysC0n5PIV+/9JYC/53jVvOW/Vbp0i /qfNGBDumL7f2Cz0kLuEOchdyIKMZNrWiwegSjw= X-Google-Smtp-Source: AK7set/Gp8SLxgxeJnsHZy2H5CYx/WiAVfn1teNlUJiWWOmcvrD6IoyJ5OrF6qiEYXQYp760krOCuP60CT9EUKDRVKM= X-Received: by 2002:a17:90a:39c8:b0:233:cc2c:7dae with SMTP id k8-20020a17090a39c800b00233cc2c7daemr3224273pjf.8.1677717555307; Wed, 01 Mar 2023 16:39:15 -0800 (PST) MIME-Version: 1.0 References: <20230301222856.12300c64@nbbrfq> <20230302005221.01a373d3@nbbrfq> In-Reply-To: <20230302005221.01a373d3@nbbrfq> From: Andrew Pinski Date: Wed, 1 Mar 2023 16:39:02 -0800 Message-ID: Subject: Re: [PATCH][stage1] Remove conditionals around free() To: Bernhard Reutner-Fischer Cc: gcc-patches@gcc.gnu.org, ian@airs.com, charlet@adacore.com, fortran@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 1, 2023 at 3:52=E2=80=AFPM Bernhard Reutner-Fischer wrote: > > On Wed, 1 Mar 2023 14:59:44 -0800 > Andrew Pinski wrote: > > > On Wed, Mar 1, 2023 at 1:31=E2=80=AFPM Bernhard Reutner-Fischer via For= tran > > wrote: > > > > > > Hi! > > > > > > Mere cosmetics. > > > > > > - if (foo !=3D NULL) > > > free (foo); > > > > > > With the caveat that coccinelle ruins replacement whitespace or i'm > > > uneducated enough to be unable to _not_ run the diff through > > > sed -e 's/^+\([[:space:]]*\)free(/+\1free (/' > > > at least. If anybody knows how to improve replacement whitespace, > > > i'd be interrested but didn't look nor ask. ISTM that leading > > > whitespace is somewhat ruined, too, so beware (8 spaces versus tab as > > > far as i have spot-checked). > > > > > > Would touch > > > gcc/ada/rtinit.c | 3 +-- > > > > > > It's funny how you apparently did not comment that hunk in the end ;) No, I was just trying to make it look seperate from the intl hunk really. > > > > intl/bindtextdom.c | 3 +-- > > > intl/loadmsgcat.c | 6 ++---- > > > intl/localcharset.c | 3 +-- > > > > intl is imported from glibc, though I don't know we have updated it in > > recent years from glibc. > > i don't think we did, overdue, as we (probably) all know. > OTOH i'm thankful that we don't have submodules but a plain, manageable > repo. Of course that comes with a burden, which is nil if ignored > throughout. Doesn't always pay out too well longterm if nobody > (voluntarily) is in due charge. I looked and nobody has filed a bug report about merging from recent glibc sources for intl. Most likely because not many folks use code from intl any more as glibc is main libc that people use for development these days in GCC world. > > > > zlib/contrib/minizip/unzip.c | 2 +- > > > zlib/contrib/minizip/zip.c | 2 +- > > > zlib/examples/enough.c | 6 ++---- > > > zlib/examples/gun.c | 2 +- > > > zlib/examples/gzjoin.c | 3 +-- > > > zlib/examples/gzlog.c | 6 ++---- > > > > zlib is definitely imported from zlib upstream. > > So it might be good to check if we could import a new version and see > > if it still works instead. updating zlib is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105404 . Thanks, Andrew > > From a meta POV, i wonder where the trailing space in the subject comes > from, looking at e.g.: > https://gcc.gnu.org/pipermail/gcc-patches/2023-March/date.html#613110 > I think and hope that the newer(?) ones by > https://inbox.sourceware.org/gcc-patches/?t=3Dxyz do not exhibit these > invented trailing blanks nobody ever wrote for real, does it. > > Thanks for reminding me of intl and it's outdatedness, although i > certainly don't have ambition to do anything about it for sure. > I didn't care 15 or 20 years ago and nowadays i'd call that attitude a > tradition, at least ATM ;) TBH i initially had only considered gcc/ but > somehow found that unfair. Great idea that inclusion was. > > thanks, > > > > 4) i most likely will not remember to split it apart and send proper > > > patches, tested patches, in stage 1 to maintainers proper, so if > > > anyone feels like pursuing this, be my guest. I thought i'd just > > > mention it. > > > > > > cheers, >