* Committed: io/async.h: Use __gthread_mutex_t, not pthread_mutex_t.
@ 2018-09-05 10:35 Hans-Peter Nilsson
2018-09-05 10:40 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 2+ messages in thread
From: Hans-Peter Nilsson @ 2018-09-05 10:35 UTC (permalink / raw)
To: gcc-patches, fortran
These pthread_mutex_t were obviously meant to be
__gthread_mutex_t. See other declarations. Not being that,
broke cris-elf build at r264070, restored with this patch. Also
regtested on native x86_64-pc-linux-gnu.
I'm not sure know why no other bare-iron target saw this, but
perhaps it's because my newlib is a bit dated (...looks... yes,
looks like newlib has grown pthreads since then, but that
doesn't excuse this flaw). Still, there may be other similar
flaws behind #ifdefs, this is just a build-fixing patch.
Committed as obvious.
libgfortran:
* io/async.h: Use __gthread_mutex_t, not pthread_mutex_t.
Index: libgfortran/io/async.h
===================================================================
--- libgfortran/io/async.h (revision 264070)
+++ libgfortran/io/async.h (working copy)
@@ -337,8 +337,8 @@ struct adv_cond
typedef struct async_unit
{
- pthread_mutex_t io_lock; /* Lock for doing actual I/O. */
- pthread_mutex_t lock; /* Lock for manipulating the queue structure. */
+ __gthread_mutex_t io_lock; /* Lock for doing actual I/O. */
+ __gthread_mutex_t lock; /* Lock for manipulating the queue structure. */
bool empty;
struct
{
brgds, H-P
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Committed: io/async.h: Use __gthread_mutex_t, not pthread_mutex_t.
2018-09-05 10:35 Committed: io/async.h: Use __gthread_mutex_t, not pthread_mutex_t Hans-Peter Nilsson
@ 2018-09-05 10:40 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 2+ messages in thread
From: Bernhard Reutner-Fischer @ 2018-09-05 10:40 UTC (permalink / raw)
To: hans-peter.nilsson; +Cc: GCC Patches, gfortran
On Wed, 5 Sep 2018 at 12:35, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>
> These pthread_mutex_t were obviously meant to be
> __gthread_mutex_t. See other declarations. Not being that,
> broke cris-elf build at r264070, restored with this patch. Also
> regtested on native x86_64-pc-linux-gnu.
>
> I'm not sure know why no other bare-iron target saw this, but
> perhaps it's because my newlib is a bit dated (...looks... yes,
> looks like newlib has grown pthreads since then, but that
> doesn't excuse this flaw). Still, there may be other similar
> flaws behind #ifdefs, this is just a build-fixing patch.
Thanks for the fix!
I mentioned the need to fix this in
https://gcc.gnu.org/ml/fortran/2018-09/msg00006.html
and i hope Thomas and Nicolas will take care of the rest of the
comments soonish.
cheers,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-05 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 10:35 Committed: io/async.h: Use __gthread_mutex_t, not pthread_mutex_t Hans-Peter Nilsson
2018-09-05 10:40 ` Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).