Fwd: [PATCH 18/25] Fix interleaving of Fortran stop messages

Fwd: [PATCH 18/25] Fix interleaving of Fortran stop messages

[Toon Moene]

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]




-------- Forwarded Message --------
Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 5 Sep 2018 12:51:19 +0100
From: ams@codesourcery.com
To: gcc-patches@gcc.gnu.org


Fortran STOP and ERROR STOP use a different function to print the "STOP" 
string
and the message string.  On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".

This patch fixes the problem by making estr_write use the proper Fortran 
write,
not C printf, so both parts are now output the same way.  This also ensures
that both parts are output to STDERR (not that that means anything on GCN).

2018-09-05  Kwok Cheung Yeung  <kcy@codesourcery.com>

	libgfortran/
	* runtime/minimal.c (estr_write): Define in terms of write.
---
  libgfortran/runtime/minimal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)



[-- Attachment #2: 0018-Fix-interleaving-of-Fortran-stop-messages.patch --]
[-- Type: text/x-patch, Size: 492 bytes --]

diff --git a/libgfortran/runtime/minimal.c b/libgfortran/runtime/minimal.c
index 8940f97..b6d26fd 100644
--- a/libgfortran/runtime/minimal.c
+++ b/libgfortran/runtime/minimal.c
@@ -196,7 +196,7 @@ sys_abort (void)
 #undef st_printf
 #define st_printf printf
 #undef estr_write
-#define estr_write printf
+#define estr_write(X) write(STDERR_FILENO, (X), strlen (X))
 #if __nvptx__
 /* Map "exit" to "abort"; see PR85463 '[nvptx] "exit" in offloaded region
    doesn't terminate process'.  */

Re: [PATCH 18/25] Fix interleaving of Fortran stop messages

[Bernhard Reutner-Fischer]

On Wed, 5 Sep 2018 at 18:57, Toon Moene <toon@moene.org> wrote:
>
>

Right. LGTM but i cannot approve it.

cheers,
>
>
> -------- Forwarded Message --------
> Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
> Date: Wed, 5 Sep 2018 12:51:19 +0100
> From: ams@codesourcery.com
> To: gcc-patches@gcc.gnu.org
>
>
> Fortran STOP and ERROR STOP use a different function to print the "STOP"
> string
> and the message string.  On GCN this results in out-of-order output, such as
> "<msg>ERROR STOP ".
>
> This patch fixes the problem by making estr_write use the proper Fortran
> write,
> not C printf, so both parts are now output the same way.  This also ensures
> that both parts are output to STDERR (not that that means anything on GCN).
>
> 2018-09-05  Kwok Cheung Yeung  <kcy@codesourcery.com>
>
>         libgfortran/
>         * runtime/minimal.c (estr_write): Define in terms of write.
> ---
>   libgfortran/runtime/minimal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>

Re: [PATCH 18/25] Fix interleaving of Fortran stop messages

[Janne Blomqvist]

On Wed, Sep 5, 2018 at 7:57 PM Toon Moene <toon@moene.org> wrote:

>
>
>
> -------- Forwarded Message --------
> Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
> Date: Wed, 5 Sep 2018 12:51:19 +0100
> From: ams@codesourcery.com
> To: gcc-patches@gcc.gnu.org
>
>
> Fortran STOP and ERROR STOP use a different function to print the "STOP"
> string
> and the message string.  On GCN this results in out-of-order output, such
> as
> "<msg>ERROR STOP ".
>
> This patch fixes the problem by making estr_write use the proper Fortran
> write,
> not C printf, so both parts are now output the same way.  This also ensures
> that both parts are output to STDERR (not that that means anything on GCN).
>
> 2018-09-05  Kwok Cheung Yeung  <kcy@codesourcery.com>
>
>         libgfortran/
>         * runtime/minimal.c (estr_write): Define in terms of write.
> ---
>   libgfortran/runtime/minimal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
>
Ok, thanks.

-- 
Janne Blomqvist

Re: [PATCH 18/25] Fix interleaving of Fortran stop messages

[Andrew Stubbs]

On 05/09/18 19:11, Janne Blomqvist wrote:
> Ok, thanks.

Committed, thanks.

Apologies again for missing the Fortran list.

Andrew