From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48561 invoked by alias); 7 Sep 2018 08:09:45 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 43730 invoked by uid 89); 7 Sep 2018 08:08:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=weekend, heads, appreciation, setups X-HELO: mail-oi0-f45.google.com Received: from mail-oi0-f45.google.com (HELO mail-oi0-f45.google.com) (209.85.218.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Sep 2018 08:08:09 +0000 Received: by mail-oi0-f45.google.com with SMTP id t68-v6so25674252oie.12; Fri, 07 Sep 2018 01:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J0816jSjyLNQRLKz/mJbnXj4Hy56sXIZyH/jnfRNpng=; b=cti8wLClQBqL9CsH2xetanTk4CeM218rG7b54MQnVCvJfNvwM7KJcBUob3l6RQVv62 MZ4B6G2cnxB64VAT2bA/dJvlEzz2TKvOKjGy8hCrQTAY5ERHgIr72pLlnrAG7rH9IpwF S2hZPJzar7YKImdpn6cR757mpw91R7tcHENR9DkD69IrmTSs38glZZ8ASZgRMrOTaw+S NAgnD1N7MQdPCtTRRasUTLgZ22uDoFC5wfPEuCtbRuNeiRAUVmYxlRE8dxZyIr81kUvj O7xrPGs6964CHBxXHyy/UFxuZPCuaeqNZW1mam6VIxbKvcgSIprUInlc3dqkS/q9jnd0 N7/A== MIME-Version: 1.0 References: <20180905145732.404-1-rep.dot.nop@gmail.com> In-Reply-To: From: Bernhard Reutner-Fischer Date: Fri, 07 Sep 2018 08:09:00 -0000 Message-ID: Subject: Re: [PATCH,FORTRAN 00/29] Move towards stringpool, part 1 To: Janne Blomqvist Cc: gfortran , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00076.txt.bz2 On Wed, 5 Sep 2018 at 20:57, Janne Blomqvist wr= ote: > > On Wed, Sep 5, 2018 at 5:58 PM Bernhard Reutner-Fischer wrote: >> Bootstrapped and regtested on x86_64-foo-linux. >> >> I'd appreciate if someone could double check for regressions on other >> setups. Git branch: >> https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dlog;h=3Drefs/heads/aldot/fortra= n-fe-stringpool >> >> Ok for trunk? > > > Hi, > > this is quite an impressive patch set. I have looked through all the patc= hes, and on the surface they all look ok. Thanks alot for your appreciation! > > Unfortunately I don't have any exotic target to test on either, so I thin= k you just have to commit it and check for regression reports. Though I don= 't see this set doing anything which would work differently on other target= s, but you never know.. > > I'd say wait a few days in case anybody else wants to comment on it, then= commit it to trunk. Upon further testing i encountered a regression in module writing, manifesting itself in a failure to compile ieee_8.f90 (and only this). f951: Fatal Error: Reading module =E2=80=98foo=E2=80=99 at line 4310 column= 25: Expected string where we write the following garbage: 366 ''''''''''''''''res'BLE IN UNKNOWN-PROC UNKNOWN UNKNOWN 0 0 End of last year when i wrote these patches i diffed each and every module in my regtests and all these were identical, so it must be some recent "regression" in that area. Sorry for that, I'll have another look during the weekend. thanks,