From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15273 invoked by alias); 1 Dec 2015 16:13:01 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 15243 invoked by uid 89); 1 Dec 2015 16:13:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ig0-f182.google.com Received: from mail-ig0-f182.google.com (HELO mail-ig0-f182.google.com) (209.85.213.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 01 Dec 2015 16:12:59 +0000 Received: by igl9 with SMTP id 9so90921192igl.0; Tue, 01 Dec 2015 08:12:58 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.150.69 with SMTP id ug5mr24579288igb.97.1448986377898; Tue, 01 Dec 2015 08:12:57 -0800 (PST) Received: by 10.36.200.70 with HTTP; Tue, 1 Dec 2015 08:12:57 -0800 (PST) In-Reply-To: <20151201150153.GA20747@troutmask.apl.washington.edu> References: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> <1448974501-30981-4-git-send-email-rep.dot.nop@gmail.com> <20151201150153.GA20747@troutmask.apl.washington.edu> Date: Tue, 01 Dec 2015 16:13:00 -0000 Message-ID: Subject: Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE From: Bernhard Reutner-Fischer To: Steve Kargl Cc: gfortran , GCC Patches , David Malcolm Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00009.txt.bz2 On 1 December 2015 at 16:01, Steve Kargl wrote: > On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote: >> >> David Malcolm nice Levenshtein distance spelling check helpers >> were used in some parts of other frontends. This proposed patch adds >> some spelling corrections to the fortran frontend. > What problem are you trying to solve here? The patch looks like The idea is to improve the programmer experience when writing code. See the testcases enclosed in the patch. I consider this a feature :) > unneeded complexity with the result of injecting C++ idioms into > the Fortran FE. What C++ idioms are you referring to? The autovec? AFAIU the light use of C++ in GCC is deemed OK. I see usage of std::swap and std::map in the FE, not to mention the wide-int uses (wi::). Thus we don't have to realloc/strcat but can use vectors to the same effect, just as other frontends, including the C frontend, do. I take it you remember that we had to change all "try" to something C++ friendly. If the Fortran FE meant to opt-out of being compiled with a C++ compiler in the first place, why were all the C++ clashes rewritten, back then? :) thanks,