From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id 13FC13858D33; Wed, 19 Apr 2023 15:14:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13FC13858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2f.google.com with SMTP id l5so11126936ybe.7; Wed, 19 Apr 2023 08:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681917293; x=1684509293; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9/k1cRJmZFyNnUHhx06CURwuyBH/I6Rfkh++6+YqkAM=; b=WOvY0axZqgHA1LiEHkamAi8LKDGUPLAmQtFfPUBNd7tSMMqKnACKox5d0ujdh7qBPl 2qNwtiZPLNF/bo8PchfZgn+2/smtxgaavx58BJH9Jekl6TtvyhCHwy1MeParmjvypWSk QMey6VaS1KB2lsRLup/NsFdatFcfdr80oCsTTIBZMMwHns46LPKfgPCFD5yYo1JuxNM9 tf7zswPxKFWIXqN1rZhfl+acnC8uaYs8FDZHlmE7EfVFm8U1sO5Gw9vXyovWyZeGcoUs YASleNrrjjpIl+qIREgSnwoaw9rTksYdy59VKp5VOe7oeuOX/XxJ4lmHEEA5bSewtFEt 9RyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681917293; x=1684509293; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9/k1cRJmZFyNnUHhx06CURwuyBH/I6Rfkh++6+YqkAM=; b=aM6EFLgdInk20YXz76HtTzwVz9ZTFmbhFqrd7D93h8W7yHecsYDZPbCSDbk9aKsWO6 KxT5fOE6n4ltJAFgARVonGC88AxZTH1yzRjzE4wznEEnmmXkGh+VI+J4MX3fhm/l6k5A a04VUU4i94CyOEoXB+nv5kKC/dtmZqxHec3QIiwlQ/Nrt8cNsQUahyPi+wjtI7zDIbjD 28TGl6MzAkMi4liEi/yivabNJDwvjc79TNduvsXKMAPB0TNWjTjhJtVR+pPDf05nxKxu pAGNOtg9Cspf87GQoKOi3epCd+4GOsQ9f1fQOrJ34K0R+ouGAXBqfk8aFQME8YKQDx3r TrlQ== X-Gm-Message-State: AAQBX9dfx0gjwWNl/fXAHpULZxNjT/s2jHrQuAv5yBNmXiiGCBQpWC4t /ZXkzYKz0XPFJVnQu+wIu5CkpnxFQmmu7HQlTZ8= X-Google-Smtp-Source: AKy350YoU64nynSY2bPdMIuMCvBpJoFcsfnKhZyw7E57wNRSvPoMPdnSaQL+AR4dsJkpQ12z0+6SMNLccxtxONWls28= X-Received: by 2002:a25:6984:0:b0:b96:b439:151f with SMTP id e126-20020a256984000000b00b96b439151fmr56076ybc.32.1681917293261; Wed, 19 Apr 2023 08:14:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bernhard Reutner-Fischer Date: Wed, 19 Apr 2023 17:14:42 +0200 Message-ID: Subject: Re: [PATCH] testsuite: fix scan-tree-dump patterns [PR83904, PR100297] To: Jerry D Cc: Harald Anlauf , fortran , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 19 Apr 2023 at 03:03, Jerry D via Fortran wrote: > > On 4/18/23 12:39 PM, Harald Anlauf via Fortran wrote: > > Dear all, > > > > the attached patch adjusts the scan-tree-dump patterns of the > > reported testcases which likely were run in a location such > > that a path in an error message showing in the tree-dump might > > have accidentally matched "free" or "data", respectively. > > > > For the testcase gfortran.dg/reshape_8.f90 I checked with a > > failing gfortran-11 that the pattern is appropriate. > > > > OK for mainline? > > > > Thanks, > > Harald > > > Yes, OK I'm certainly not opposed to this specific incarnation of such a fix. These failures are really unpleasant :) As proposed in https://inbox.sourceware.org/gcc-patches/20220426010029.2b476337@nbbrfq/ we could add a -fno-file to suppress the assembler .file output (whatever the prefix looks like depends on the assembler dialect). Or we could nuke the .file directives by a sed(1), but that would probably be cumbersome for remote targets. I don't have a better idea than -fno-file or -ffile=foo.c . Fixing them case-by-case does not scale all that well IMHO. Thoughts?