From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123304 invoked by alias); 19 Sep 2018 21:18:39 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 123282 invoked by uid 89); 19 Sep 2018 21:18:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Institute, institute, H*c:alternative, interest X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 21:18:37 +0000 Received: by mail-wr1-f67.google.com with SMTP id s14-v6so7218006wrw.6 for ; Wed, 19 Sep 2018 14:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceryinstitute.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Det9TH9BS+j37vPNI+JOX0W9TOZ9YOp+ahMTSeNkzQ4=; b=N1v4lCPLH4M2OzBQ6Fm8XWZUlizl//AGw2bF8FRN3w0pt+cdybWpQcdydl65uA9hz7 q0fBX6fq8KJIKfB50AVAelNL973ccnosBPzLA5lKKhRdqfTKkuMCbt/msEjrsFJrjLJH UwDkwIXC8VEkFnDEykfgD3dUnTrMxolRU+mH//lrdfC/i1nxMRK9+DOJKWrNz5WDkcus uIHH/qzknG8wDIX4vgSD+ZZLDIA0nmxumTZCwT+4WvlFQP/LG8DBtWIayqhSX9qbZEV7 hHLRoxU79i06nm7E9DNttPZ7Hpn4bwo4S+vLgq3cCbANmIp7IARWj54ku4Jc3+8ks4BC hbDQ== MIME-Version: 1.0 References: <024e798b9539b765a1259cfc9cb2f1dc480b24ca.1536144068.git.ams@codesourcery.com> <7f5064c3-afc6-b7b5-cade-f03af5b86331@moene.org> <9290b55e-b12a-838a-5943-0c72d040dc3f@codesourcery.com> In-Reply-To: <9290b55e-b12a-838a-5943-0c72d040dc3f@codesourcery.com> From: Damian Rouson Date: Wed, 19 Sep 2018 21:18:00 -0000 Message-ID: Subject: Re: [PATCH 08/25] Fix co-array allocation To: ams@codesourcery.com Cc: Janne Blomqvist , Toon Moene , gcc patches , gfortran Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00136.txt.bz2 Has this been tested in multi-image execution using OpenCoarrays? If not, I would be glad to assist with installing OpenCoarrays so that it can be part of the testing process. On a related note, two Sourcery Institute developers have attempted to edit the GCC build system to make the downloading and building of OpenCoarrays automatically part of the gfortran build process. Neither developer succeeded. If anyone has any interest in figuring out how to do this, it will prevent a lot of potential regressions when single-image testing doesn't expose issues that only arise with multi-image execution. Damian On Wed, Sep 19, 2018 at 9:25 AM Andrew Stubbs wrote: > On 05/09/18 19:07, Janne Blomqvist wrote: > > The argument must be of type size_type_node, not sizetype. Please instead > > use > > > > size = build_zero_cst (size_type_node); > > > > > >> * trans-intrinsic.c (conv_intrinsic_event_query): Convert > computed > >> index to a size_t type. > >> > > > > Using integer_type_node is wrong, but the correct type for calculating > > array indices (lbound, ubound, etc.) is not size_type_node but rather > > gfc_array_index_type (which in practice maps to ptrdiff_t). So please use > > that, and then fold_convert index to size_type_node just before > generating > > the call to event_query. > > > > > >> * trans-stmt.c (gfc_trans_event_post_wait): Likewise. > >> > > > > Same here as above. > > How is the attached? I retested and found no regressions. > > Andrew >