From: Fritz Reese <fritzoreese@gmail.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 86116: Ambiguous generic interface not recognised
Date: Tue, 14 Aug 2018 14:16:00 -0000 [thread overview]
Message-ID: <CAE4aFA=7TOD+bd9o6e8DY3EGMjVWKJ4UA46ji2OguyE4F6_hvg@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qhS7sPWv4n=X6+9s+UiT=2JSb8v5T2RXvr7LCGgoUm2XQ@mail.gmail.com>
Looks OK to me.
On Tue, Aug 14, 2018 at 4:12 AM Janus Weil <janus@gcc.gnu.org> wrote:
>
> ping!
>
>
> Am So., 5. Aug. 2018 um 15:23 Uhr schrieb Janus Weil <janus@gcc.gnu.org>:
> >
> > Hi all,
> >
> > the attached patch fixes PR 86116 by splitting up the function
> > 'compare_type' into two variants: One that is used for checking
> > generic interfaces and operators (keeping the old name), and one that
> > is used for checking dummy functions and procedure pointer assignments
> > ('compare_type_characteristics'). The latter calls the former, but
> > includes an additional check that must not be done when checking
> > generics.
> >
> > Regtests cleanly on x86_64-linux-gnu. Ok for trunk?
> >
> > Cheers,
> > Janus
> >
> >
> > 2018-08-05 Janus Weil <janus@gcc.gnu.org>
> >
> > PR fortran/86116
> > * interface.c (compare_type): Remove a CLASS/TYPE check.
> > (compare_type_characteristics): New function that behaves like the old
> > 'compare_type'.
> > (gfc_check_dummy_characteristics, gfc_check_result_characteristics):
> > Call 'compare_type_characteristics' instead of 'compare_type'.
> >
> > 2018-08-05 Janus Weil <janus@gcc.gnu.org>
> >
> > PR fortran/86116
> > * gfortran.dg/generic_34.f90: New test case.
next prev parent reply other threads:[~2018-08-14 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-05 13:24 Janus Weil
2018-08-14 8:12 ` Janus Weil
2018-08-14 14:16 ` Fritz Reese [this message]
2018-08-14 19:13 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4aFA=7TOD+bd9o6e8DY3EGMjVWKJ4UA46ji2OguyE4F6_hvg@mail.gmail.com' \
--to=fritzoreese@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).