public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Fritz Reese <fritzoreese@gmail.com>
To: Louis Krupp <louis.krupp@zoho.com>
Cc: fortran <fortran@gcc.gnu.org>
Subject: Re: Possible patch for fortran/68078
Date: Thu, 15 Sep 2016 12:49:00 -0000	[thread overview]
Message-ID: <CAE4aFA=Gs+crZzGn8pq_pUMR8XiB=P6a4RhTr1j0fGZcUuOJaw@mail.gmail.com> (raw)
In-Reply-To: <1572c78cd91.bdb209569142.7490991715096244405@zoho.com>

It might be worth filling in the right locations for the new blocks (?):

diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
@@ -7048,7 +7048,9 @@ cond_init (gfc_code *code, gfc_expr *e, int pointer, gfc_e
   init_st->expr2 = init_e;

   block = gfc_get_code (EXEC_IF);
+  block->loc = code->loc;
   block->block = gfc_get_code (EXEC_IF);
+  block->block->loc = code->loc;
   block->block->expr1 = cond;
   block->block->next = init_st;
   block->next = code->next;


Minor nit, trailing whitespace:

--- gcc/fortran/resolve.c       (revision 240152)
+++ gcc/fortran/resolve.c       (working copy)
...
+  block->block->expr1 = cond;
+  block->block->next = init_st;
+  block->next = code->next;
+  <<<<< Trailing whitespace.
+  code->next = block;

Otherwise it looks fine to me. So long as the system(s) to test
support(s) setrlimit() (which should be true for POSIX systems).

---
Fritz Reese

(P.S. I can't officially approve the patch, I'm just providing feedback.)

On Thu, Sep 15, 2016 at 2:11 AM, Louis Krupp <louis.krupp@zoho.com> wrote:
> Verify that allocation was successful before assigning default initialization values to components of the allocated object (or array of > objects or pointer to an object).   The change could probably have been made while parsing or at translation.  This patch does it in > the resolution phase.  It seemed like a good idea.
>

  reply	other threads:[~2016-09-15 12:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15  6:11 Louis Krupp
2016-09-15 12:49 ` Fritz Reese [this message]
2016-09-15 18:12   ` Louis Krupp
2016-09-17 19:38     ` Steve Kargl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE4aFA=Gs+crZzGn8pq_pUMR8XiB=P6a4RhTr1j0fGZcUuOJaw@mail.gmail.com' \
    --to=fritzoreese@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=louis.krupp@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).