From: Fritz Reese <fritzoreese@gmail.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions
Date: Tue, 17 Jul 2018 18:55:00 -0000 [thread overview]
Message-ID: <CAE4aFAnkWbkBDj3XC2r3r7pWazeWdHA2WJYtzj0mVxQ7N+qPQA@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qgtSBX1h9NFvCA6GggBnX_98gt1tY-69Z+kA=Kaznaxxg@mail.gmail.com>
On Tue, Jul 17, 2018 at 2:36 PM Janus Weil <janus@gcc.gnu.org> wrote:
>
> 2018-07-17 19:34 GMT+02:00 Thomas Koenig <tkoenig@netcologne.de>:
> > Am 17.07.2018 um 19:19 schrieb Janus Weil:
[...]
>
> I do hope that things have converged by now and that this will be the
> last incarnation of the patch. If there is no more feedback in the
> next 24 hours, I'll commit this tomorrow.
>
> Cheers,
> Janus
I hate to be pedantic but it is still worth fixing the style discrepancies:
$ ./contrib/check_GNU_style.sh pr85599_v7.diff
>
> Lines should not exceed 80 characters.
> 209:+ if (f != last && !gfc_pure_function (f, &name) && !gfc_implicit_pure_function (f))
>
> Blocks of 8 spaces should be replaced with tabs.
> 37:+ gfc_warning (OPT_Wfunction_elimination,
> 41:+ gfc_warning (OPT_Wfunction_elimination,
> 238:+ with impure function as second operand. */
>
> Dot, space, space, new sentence.
> 84:+expression, if they do not contribute to the final result. For logical
> 87:+result of the expression can be established without them. However, since not
My only other comment is I am not sure why you make
pure_function()/gfc_implicit_pure_function() public... but I have no
real problem with it. Just means rebuilding all of f951 instead of one
object. :-(
Otherwise if the patch does what it appears to do and passes tests
then it seems fine to me.
Fritz
next prev parent reply other threads:[~2018-07-17 18:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:06 Janus Weil
2018-07-12 19:43 ` Janus Weil
2018-07-13 8:03 ` Janus Weil
2018-07-15 20:39 ` Janus Weil
2018-07-15 20:57 ` Thomas Koenig
2018-07-16 8:07 ` Janus Weil
2018-07-16 19:51 ` Thomas Koenig
2018-07-17 5:08 ` Janus Weil
2018-07-17 7:52 ` Janus Weil
2018-07-17 14:32 ` Janus Weil
2018-07-17 15:19 ` Fritz Reese
2018-07-17 17:19 ` Janus Weil
2018-07-17 17:34 ` Thomas Koenig
2018-07-17 18:36 ` Janus Weil
2018-07-17 18:55 ` Fritz Reese [this message]
2018-07-17 19:21 ` Janus Weil
2018-07-18 18:43 ` Janus Weil
2018-07-12 11:17 Dominique d'Humières
2018-07-12 14:12 ` Janus Weil
2018-07-12 14:35 ` Dominique d'Humières
2018-07-12 14:55 ` Janus Weil
2018-07-12 19:53 ` Thomas Koenig
2018-07-12 20:03 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE4aFAnkWbkBDj3XC2r3r7pWazeWdHA2WJYtzj0mVxQ7N+qPQA@mail.gmail.com \
--to=fritzoreese@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).