From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 33D023858D37; Tue, 5 Apr 2022 06:28:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 33D023858D37 Received: by mail-ej1-x633.google.com with SMTP id yy13so24563005ejb.2; Mon, 04 Apr 2022 23:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TjTXpfCHetlVcz4VxJ6zkqqBOJKX+mgYkX8OEw3VLFg=; b=yFL5wR5MmRgNN9YORKoxc9JK0fcg3FGIS8Vmc51zh9dbmTbwmUapmp78+K1NYZDJTn JlhrWRQQf03P3UDAKwoThh/m8hnogm4eJolP2gDVTW4mR6N554oh8zp+JbFuHgOEDVz+ THgyAZc4485Qhn6+eI9nKdWwH+7t5KSNp2zZF2y1+L+WjXtUwb3RHx9Q9W7Rn7+JLxHI fQLhqFrhWQWYMlwfvtOTqhXecWGKmWdqZVB8iTUqz37cA/+/HzXJVqhndWMAb2cnuqIP MyIpBMtJnN+sU5MPBe2qivnJvBAnuJvOJFfODli04MMjKXya59TWx55ewCW74SuFKPgL 15qw== X-Gm-Message-State: AOAM532x+s5BMxjSeKd7U08VIzPH8Q2rePI7mv/ky5WlLmDd1oZoiIvQ iGoOanEoLCU3CFz4afgfqRI7ytcmns+TdFDKMTM= X-Google-Smtp-Source: ABdhPJzqlE3pYS6+DokUUnwB/fu6bfgEHE6M3IIoPJmb/CNUrNKzN0TWx0CKmkWTK7vf7hMyu+ywyxOkhqVOibh+6H8= X-Received: by 2002:a17:907:960f:b0:6e6:e4ab:b379 with SMTP id gb15-20020a170907960f00b006e6e4abb379mr1927717ejc.32.1649140082157; Mon, 04 Apr 2022 23:28:02 -0700 (PDT) MIME-Version: 1.0 References: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com> <8651a26f-7b51-a57c-d4a3-8aa5b2ddebb2@codesourcery.com> In-Reply-To: <8651a26f-7b51-a57c-d4a3-8aa5b2ddebb2@codesourcery.com> From: Richard Biener Date: Tue, 5 Apr 2022 08:27:51 +0200 Message-ID: Subject: Re: [PATCH] Fortran: Add location info to OpenMP tree nodes To: Sandra Loosemore Cc: "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 06:28:07 -0000 On Tue, Apr 5, 2022 at 6:12 AM Sandra Loosemore wrote: > > On 3/25/22 20:03, Sandra Loosemore wrote: > > I've got another patch forthcoming (stage 1 material) that adds some new > > diagnostics for non-rectangular loops during gimplification of OMP > > nodes. When I was working on that, I discovered that the Fortran front > > end wasn't attaching location information to the tree nodes > > corresponding to the various OMP directives, so the new errors weren't > > coming out with location info either. I went through trans-openmp.cc > > and fixed all the places where make_node was being called to explicitly > > set the location. > > > > I don't have a test case specifically for this change, but my test cases > > for the new diagnostics in the non-rectangular loops patch do exercise > > it. Is this OK for trunk now, or for stage 1 when we get there? > > Ping! Even a quick review and "this isn't suitable for GCC 12" answer > would be helpful. > > https://gcc.gnu.org/pipermail/fortran/2022-March/057706.html OK if nobody objects in 24h. Richard. > The definitely-stage-1 patch that exercises this is here: > > https://gcc.gnu.org/pipermail/fortran/2022-March/057707.html > > -Sandra