From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 9D67A3834850; Wed, 14 Dec 2022 08:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D67A3834850 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id x11so5895777ljh.7; Wed, 14 Dec 2022 00:21:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2CiK5cBkx11vns9P4KYuBlsU9rGt6KjlKyoMvwPwHNg=; b=o0JPl2P0DYuiijJtSGGNfSj/IVKv/Q1pAJL0oihoGoUEYA+YNGjggjTRfLKD7ERhCP 4X5YzIvsp6wF7Up8jitGzPenJVQNydwA0z1W0m7sCY0KXEFyOfIUJy0f8iR3WrtPamyx KMNWLBByezVXTiVVkQfiehqJHAwhKrsbiyjaL5L1sOX/8xS3b48OQ8VR7ct2TF2TGV9g VlQYy59Pe5AA9OEwnTmID+9JD7KxTQoEcnYCgHf/sMUdp9EFlS79qn9+XyM2fq1aXmMt Rn+W/YRvZBp2Gfx32J8ToRca4s26mo9Srkyiz0/rX13o/gMy9UOd5kRBQSnbcxKGGzZB nm1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2CiK5cBkx11vns9P4KYuBlsU9rGt6KjlKyoMvwPwHNg=; b=hN6L/jw82NbrukRWNROSFbfL3oJGhTfwkkDMetHsW+jowwTbwKW9Xri6+6/zhYJiRl 2qfvVy5KSu+0q5Ta8GaNmgUKrlRHHa5RBzLUGWEpDYLtjlYQv8zQJRwGTrcfcbywR83h Ni+/RQSsBoipAEtrf4ArIlWtzm6vQ0XJbNRn7SZwHftyRygA0A1TBC9hjxH/l3oIPO4Y DRMZpYCKA56LAce7YcS/BjPZKHIf+ODU9eLDoXiq71Qsh0gz5XA2g7KDeEQL0vcEq0D/ iD1L2PpyGAacFv9d135JfANSdIvqglE3RPBqmoxhIRJr6Mi1+mfrwfjUikj2yBlz5aGE AtHg== X-Gm-Message-State: ANoB5plFSxcr8DibyFRxgQi3j7OTAWnq1Pp204OZ8SwEJv0MJ9GQuYdQ lcL4rbglZ3fA9sxoXKPZddE01z92a8XyABcBfvIuB+xF X-Google-Smtp-Source: AA0mqf4jUkFUBgjoAgusCGP3s9OQ8eDrkN2G4X2ya/F7xSaIdVhzbzDy6Sel/rwzgoG5QU5ao5ILRIlMEOpVwxsuhzw= X-Received: by 2002:a2e:a0cc:0:b0:27a:34ed:9427 with SMTP id f12-20020a2ea0cc000000b0027a34ed9427mr1148687ljm.253.1671006091211; Wed, 14 Dec 2022 00:21:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 14 Dec 2022 09:21:18 +0100 Message-ID: Subject: Re: [Patch, Fortran] libgfortran's ISO_Fortran_binding.c: Use GCC11 version for backward-only code [PR108056] To: Tobias Burnus Cc: gcc-patches , fortran Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 13, 2022 at 5:29 PM Tobias Burnus wro= te: > > This is a 12/13 regression as come changes to fix the GFC/CFI descriptor > that went into GCC 12 fail with the (bogus) descriptor passed via by a > GCC-11-compiled program. > > As later GCC 12 changes moved the descriptor to the front end, those > functions are only in libgomp.so to cater for old program. Richard > suggested in the PR that the best way is to move to the GCC 11 version, > such that libgfortran.so won't regress. > > I now did so - except for three fixes (cf. changelog). See also > PR: https://gcc.gnu.org/PR108056 > > There is no testcase as it needs to be compiled by GCC <=3D 11 and then > run with linking (dynamically) to a GCC 12 or 13 libgfortran. > > OK for mainline and GCC 12? OK for the branch if approved for trunk. Richard. > * * * > > Note: It is strongly recommended to use GCC 12 (or 13) with array-descrip= tor > C interop as many issues were fixed. Like for the testcase in the PR; in = GCC 11 > the type arriving in libgomp is BT_ASSUME ('type(*)'). But as the effecti= ve > argument is passed as array descriptor through out, the 'float' (real(4))= type > info is actually preservable (as GCC 12 cf. testcase of comment 0 and my = comment > in the PR for the C part of the testcase).(*) > > Tobias > > ((*) This is not possible if using a scalar 'type(*)' or a non-array-desc= riptor > array in between. I think GCC 12 uses 'CFI_other' in the information-is-l= ost case.) > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955