From: Richard Biener <richard.guenther@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: MATMUL broken with frontend optimization.
Date: Thu, 18 Mar 2021 13:35:38 +0100 [thread overview]
Message-ID: <CAFiYyc3kfoKsqhn2zJWsMzqOZ3-Z3OYoORcJC9mJtpt=Ogm3Vg@mail.gmail.com> (raw)
In-Reply-To: <20210318074849.GA22541@troutmask.apl.washington.edu>
On Thu, Mar 18, 2021 at 8:49 AM Steve Kargl via Fortran
<fortran@gcc.gnu.org> wrote:
>
> It seems that gfortran will inline MATMUL with optimization.
> This produce very poor performance. In fact, gfortran will
> inline MATMUL even if one specifies -fexternal-blas. This is
> very bad.
>
> % cat a.f90
> program main
>
> implicit none
>
> integer, parameter :: imax = 20000, jmax = 10000
> real, allocatable :: inVect(:), matrix(:,:), outVect(:)
> real :: start, finish
>
> allocate(invect(imax), matrix(imax,jmax), outvect(jmax))
>
> call random_number(inVect)
> call random_number(matrix)
>
> call cpu_time(start)
> outVect = matmul(inVect, matrix)
> call cpu_time(finish)
>
> print '("Time = ",f10.7," seconds. – First Value = ",f10.4)',finish-start,outVect(1)
> end program main
>
> % gfcx -o z -O0 a.f90 && ./z
> Time = 0.2234111 seconds. – First Value = 4982.6362
> % nm z | grep matmul
> U _gfortran_matmul_r4@@GFORTRAN_8
> % gfcx -o z -O1 a.f90 && ./z
> Time = 0.3295890 seconds. – First Value = 4971.0962
> % nm z | grep matmul
> % gfcx -o z -O2 a.f90 && ./z
> Time = 0.3299561 seconds. – First Value = 5025.4902
> % nm z | grep matmul
> % gfcx -o z -O2 -fexternal-blas a.f90 && ./z
> Time = 0.3295580 seconds. – First Value = 5022.8291
>
> This last one is definitely broken. I did not link with
> an external BLAS library. Please fix before 11.1 is
> released.
Since the libgfortran MATMUL should be vectorized
I think it's not reasonable to inline any but _very_ small
MATMUL at optimization levels that do not enable vectorization.
Richard.
>
> --
> Steve
next prev parent reply other threads:[~2021-03-18 12:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 7:48 Steve Kargl
2021-03-18 12:35 ` Richard Biener [this message]
2021-03-18 14:48 ` Tobias Burnus
2021-03-18 15:05 ` Richard Biener
2021-03-18 16:13 ` Steve Kargl
2021-03-18 18:16 ` Thomas Koenig
2021-03-18 18:24 ` Thomas Koenig
2021-03-18 20:22 ` Steve Kargl
2021-03-18 20:55 ` Thomas Koenig
2021-03-18 22:07 ` Steve Kargl
2021-03-19 6:19 ` Thomas Koenig
2021-03-19 6:36 ` Thomas Koenig
2021-03-19 19:12 ` Steve Kargl
2021-03-19 7:03 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc3kfoKsqhn2zJWsMzqOZ3-Z3OYoORcJC9mJtpt=Ogm3Vg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).