From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 281DB3858D28; Mon, 17 Jul 2023 15:56:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 281DB3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-992b66e5affso658192366b.3; Mon, 17 Jul 2023 08:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689609371; x=1692201371; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vXTF2MOZkxVA23u4ermPX5bh6FCEaL7doj6m/nh+77U=; b=MvGdLMPybc3IEDJdPo9eKKd0SShhbS5H+avTYnu/VqMVWDqKGz320lGNuPCef08LrP PfgMbmanwPjUBbxWBjt7FoHUojTHIgdE5mhv1prqdQUSFlY2Xw3lYWdhsUIDDUk3UE/S PHJRFS3E0ChVA71WOUhBPney+15Cs6g4BNZK7ggRZ8JQDJzChjopg8gV8kAYOOPnji3n +NSZAKaiasKZT8K5EeGlBIuCu0NX3PzfvMKM5aMzIQfLxLEKi37OYm4Ur/H1yf4XQx1y arYmVdgxDxnWCN1VnAvRphl1VAyGdCEXnx6PmeXGlpUDrFcvgJWzW7w8aKTEqlTrChNE xLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689609371; x=1692201371; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vXTF2MOZkxVA23u4ermPX5bh6FCEaL7doj6m/nh+77U=; b=NN2szhMyEb5y1reNtcHk5cY5YC2dOG+yq5e2Igpjqy0AgwEqveJHMH+l2Z5XM6UKob m0LXulzD7S/HohL8R/ymD8JEc91/475Fd2azrf0fwILIT5xKPzbSiJ1b6ByGXYPaNgeZ bOhKEytxXv1c0xsHd6RzSg4yfavw4CwPoUMRued1dFu93AghOJRfl8n7hquQws73RNYY Mign2bGZfWvvH2hml25QKzqrse5uy1l/lvP4bwFLDx3uoEEXDyMZrxg8SssCUJLEZLex pX9qB5yg2mzxa7Gwk2Slv1VSEvSB9iro3itJiSLYAIcltqA4oJRLl6dwPjxEfbJUV69U 96DA== X-Gm-Message-State: ABy/qLaWAik2+GcexlrTv9oVucjXR8xuHiCDmTtQ+nhAsKhnXs0qb/lF hWxhE4TpbxdICKJjTzmm0pj2Lrdyb8DFpO+kYCQ= X-Google-Smtp-Source: APBJJlH2wNVwLCVlGrwANzk9glZh6Ocr0JsWZT9CNXUPmNFG3kU2b34GvAk+Krr9YbsUbh1t6Ocp4NmFYQH9EFScv7M= X-Received: by 2002:a17:906:1d8:b0:993:d7c4:1a78 with SMTP id 24-20020a17090601d800b00993d7c41a78mr10422283ejj.10.1689609371367; Mon, 17 Jul 2023 08:56:11 -0700 (PDT) MIME-Version: 1.0 References: <55ac674d-468c-d4f5-e45e-190b25202412@gmx.de> In-Reply-To: From: Alexander Westbrooks Date: Mon, 17 Jul 2023 10:56:00 -0500 Message-ID: Subject: Re: PR82943 - Suggested patch to fix To: Harald Anlauf Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="00000000000063c48f0600b0d6aa" X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000063c48f0600b0d6aa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I wanted to follow up on this, and ask what the next steps would be to incorporate this patch? Thanks, Alexander Westbrooks On Thu, Jun 29, 2023 at 10:38 PM Alexander Westbrooks wrote: > Hello, > > I have finished my testing, and updated my patch and relevant Changelogs. > I added 4 new tests and all the existing tests in the current testsuite > for gfortran passed or failed as expected. Do I need to attach the test > results here? > > The platform I tested on was a Docker container running in Docker Desktop, > running the "mcr.microsoft.com/devcontainers/universal:2-linux" image. > > I also made sure that my code changes followed the coding standards. > Please let me know if there is anything else that I need to do. I don't > have write-access to the repository. > > Thanks, > > Alexander > > On Wed, Jun 28, 2023 at 4:14=E2=80=AFPM Harald Anlauf wro= te: > >> Hi Alex, >> >> welcome to the gfortran community. It is great that you are trying >> to get actively involved. >> >> You already did quite a few things right: patches shall be sent to >> the gcc-patches ML, but Fortran reviewers usually notice them only >> where they are copied to the fortran ML. >> >> There are some general recommendations on the formatting of C code, >> like indentation, of the patches, and of the commit log entries. >> >> Regarding coding standards, see https://www.gnu.org/prep/standards/ . >> >> Regarding testcases, a recommendation is to have a look at >> existing testcases, e.g. in gcc/testsuite/gfortran.dg/, and then >> decide if the testcase shall test the compile-time or run-time >> behaviour, and add the necessary dejagnu directives. >> >> You should also verify if your patch passes regression testing. >> For changes to gfortran, it is usually sufficient to run >> >> make check-fortran -j >> >> where is the number of parallel tests. >> You would need to report also the platform where you tested on. >> >> There is also a legal issue to consider before non-trivial patches can >> be accepted for incorporation: https://gcc.gnu.org/contribute.html#legal >> >> If your patch is accepted and if you do not have write-access to the >> repository, one of the maintainers will likely take care of it. >> If you become a regular contributor, you will probably want to consider >> getting write access. >> >> Cheers, >> Harald >> >> >> >> On 6/24/23 19:17, Alexander Westbrooks via Gcc-patches wrote: >> > Hello, >> > >> > I am new to the GFortran community. Over the past two weeks I created a >> > patch that should fix PR82943 for GFortran. I have attached it to this >> > email. The patch allows the code below to compile successfully. I am >> > working on creating test cases next, but I am new to the process so it >> may >> > take me some time. After I make test cases, do I email them to you as >> well? >> > Do I need to make a pull-request on github in order to get the patch >> > reviewed? >> > >> > Thank you, >> > >> > Alexander Westbrooks >> > >> > module testmod >> > >> > public :: foo >> > >> > type, public :: tough_lvl_0(a, b) >> > integer, kind :: a =3D 1 >> > integer, len :: b >> > contains >> > procedure :: foo >> > end type >> > >> > type, public, EXTENDS(tough_lvl_0) :: tough_lvl_1 (c) >> > integer, len :: c >> > contains >> > procedure :: bar >> > end type >> > >> > type, public, EXTENDS(tough_lvl_1) :: tough_lvl_2 (d) >> > integer, len :: d >> > contains >> > procedure :: foobar >> > end type >> > >> > contains >> > subroutine foo(this) >> > class(tough_lvl_0(1,*)), intent(inout) :: this >> > end subroutine >> > >> > subroutine bar(this) >> > class(tough_lvl_1(1,*,*)), intent(inout) :: this >> > end subroutine >> > >> > subroutine foobar(this) >> > class(tough_lvl_2(1,*,*,*)), intent(inout) :: this >> > end subroutine >> > >> > end module >> > >> > PROGRAM testprogram >> > USE testmod >> > >> > TYPE(tough_lvl_0(1,5)) :: test_pdt_0 >> > TYPE(tough_lvl_1(1,5,6)) :: test_pdt_1 >> > TYPE(tough_lvl_2(1,5,6,7)) :: test_pdt_2 >> > >> > CALL test_pdt_0%foo() >> > >> > CALL test_pdt_1%foo() >> > CALL test_pdt_1%bar() >> > >> > CALL test_pdt_2%foo() >> > CALL test_pdt_2%bar() >> > CALL test_pdt_2%foobar() >> > >> > >> > END PROGRAM testprogram >> >> --00000000000063c48f0600b0d6aa--