From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fortran-return-51183-listarch-fortran=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 112984 invoked by alias); 11 Oct 2018 13:56:40 -0000
Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <fortran.gcc.gnu.org>
List-Subscribe: <mailto:fortran-subscribe@gcc.gnu.org>
List-Post: <mailto:fortran@gcc.gnu.org>
List-Help: <mailto:fortran-help@gcc.gnu.org>, <http://sourceware.org/lists.html#faqs>
Sender: fortran-owner@gcc.gnu.org
Received: (qmail 112956 invoked by uid 89); 11 Oct 2018 13:56:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=3.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GARBLED_SUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1271, H*f:sk:c0ed507, H*f:sk:4c9f65b, H*f:sk:oGjak1j
X-HELO: mail-wm1-f50.google.com
Received: from mail-wm1-f50.google.com (HELO mail-wm1-f50.google.com) (209.85.128.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 13:56:38 +0000
Received: by mail-wm1-f50.google.com with SMTP id 185-v6so9595571wmt.2;        Thu, 11 Oct 2018 06:56:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=UZkZlz+0NYUzTXF5QAUGXIZexUBGusK3AnyutFoD8nQ=;        b=SVfcPaHGTok3CK3aMuzGkY5S31O3QH3AytTcnQlXY6cBobCXWASLXArTJDg/PcNBrZ         m8wiuA+3NhASA8DG21rRI7Su3Lox2UzqHdMyPi/AxhBAObyIvLuvAJtgETfFlsvNvqGS         13tWswUFWZwx8Tz+lSn2IY/I5iLkKT0n9BRAtUb6kByJlSODS1Wz8suq08STmirVb+dj         OVfcnv6SCsBssh5aYtS1j4e1gu3JG6Yh+7JE8LyC/RlBR3uF+tUCzCeFCDK+S2zoAmAq         cxPQ1rx+015L66uMAvBdLlYn6AU4XCXk0bOC81vTtc6WKx15CpYHfLKgeAYP8oZhBBRM         IBog==
MIME-Version: 1.0
References: <c0ed507e-bf17-ea71-6715-906c10ee054d@net-b.de> <4c9f65bf-4878-baa0-f3e5-d3943e4eb985@netcologne.de> <CAGkQGiKPgo81h6=-oGjak1j3Y99FMwc6UbXw4g6_Wf1-soRtMQ@mail.gmail.com>
In-Reply-To: <CAGkQGiKPgo81h6=-oGjak1j3Y99FMwc6UbXw4g6_Wf1-soRtMQ@mail.gmail.com>
From: David Edelsohn <dje.gcc@gmail.com>
Date: Thu, 11 Oct 2018 13:56:00 -0000
Message-ID: <CAGWvnykOLsiw-XNrDuQeoGLaB648f-MCD-7J=zRL4JL1=XLfJQ@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BPatch=2C_Fortran=5D_PR_fortran=2F83522_=E2=80=93_reject_arr?=	=?UTF-8?Q?ay=2Dvalued_substrings?=
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Cc: Thomas Koenig <tkoenig@netcologne.de>, Fortran List <fortran@gcc.gnu.org>, 	GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-SW-Source: 2018-10/txt/msg00045.txt.bz2

Apparently this change also breaks CPU SPEC (465.tonto?).

Is this really a correct change?  Even if the testcases really are
wrong, it seems that this change is going to break a lot of code in
the wild.  This seems like a very bad choice, even if it pedantically
is correct.

Thanks, David

On Wed, Oct 10, 2018 at 7:12 PM Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
>
> This seems to have caused errors in the testsuite. I guess that the
> problem is that the testcases are invalid :-(
>
> From David Edelsohn:
> Error: Substring reference of nonscalar not permitted at (1)
>
> arrayio_11.f90
> arrayio_12.f90
> associate_23.f90
> data_char_1.f90
> deferred_character_2.f90
> deferred_character_22.f90
> deferred_character_23.f90
> deferred_character_8.f90
> deferred_type_component_3.f90
>
> Cheers
>
> Paul
>
> On Mon, 8 Oct 2018 at 23:16, Thomas Koenig <tkoenig@netcologne.de> wrote:
> >
> > Hi Tobias,
> >
> > nice to hear from you again!
> >
> > > Build and regtested on x86_64-linux.
> > > OK for the trunk?
> >
> > OK. Thanks for the patch!
> >
> > Regards
> >
> >         Thomas
>
>
>
> --
> "If you can't explain it simply, you don't understand it well enough"
> - Albert Einstein