From: David Edelsohn <dje.gcc@gmail.com>
To: Janus Weil <janus@gcc.gnu.org>
Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>,
Janne Blomqvist <blomqvist.janne@gmail.com>,
Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 82143: add a -fdefault-real-16 flag
Date: Tue, 26 Sep 2017 14:54:00 -0000 [thread overview]
Message-ID: <CAGWvnymyGFM=qS+=mc_tFyRN+Qz5frVsS8hejSv-=4uG-X03yg@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qi2N4LCiMzv1obi5t53YiFn6eABecNFHWYfsWkRp=YE+Q@mail.gmail.com>
On Tue, Sep 26, 2017 at 4:44 AM, Janus Weil <janus@gcc.gnu.org> wrote:
> 2017-09-25 23:23 GMT+02:00 Steve Kargl <sgk@troutmask.apl.washington.edu>:
>> On Mon, Sep 25, 2017 at 11:14:42PM +0200, Janus Weil wrote:
>>> 2017-09-25 17:07 GMT+02:00 David Edelsohn <dje.gcc@gmail.com>:
>>> > promotion_3.f90 and promotion_4.f90 are failing on at least PowerPC
>>> > and AArch64. Are these new tests limited to x86 or some long double
>>> > assumptions?
>>>
>>> These tests require the availability of a 10- or 16-byte-wide REAL
>>> type, respectively. I have to admit that I do not have a complete
>>> overview of which targets in GCC's wide portfolio provide such a type.
>>>
>>> It seems that REAL(16) is supported via libquadmath on 32-bit x86,
>>> x86-64 and Itanium at least. I'm not sure about REAL(10).
>>>
>>> Targets that do not support such a type probably need to be XFAILed.
>>>
>>
>> Janus, I think you can control with a dg option
>>
>> dg-require-effective-target fortran_large_real
>>
>> See, for example, gfortran.dg/random_3.f90
>
> Thanks for the pointer, Steve.
>
> However, it seems that "fortran_large_real" only requires some real
> type that is larger than 8 byte, but makes no assumptions on its
> actual size (10 or 16 byte). Therefore it's probably not very useful
> for promotion_{3,4}.
>
> But: I found that there's also a "fortran_real_16", which should be
> suitable for promotion_3. Can someone verify if the following fixes
> the problem on the failing targets:
>
> Index: promotion_3.f90
> ===================================================================
> --- promotion_3.f90 (revision 253134)
> +++ promotion_3.f90 (working copy)
> @@ -1,5 +1,6 @@
> ! { dg-do run }
> ! { dg-options "-fdefault-real-16" }
> +! { dg-require-effective-target fortran_real_16 }
> !
> ! PR 82143: add a -fdefault-real-16 flag
> !
>
>
> If it does, I'll be happy to commit that. For promotion_4, we probably
> need to add an effective target "fortran_real_10" (which does not seem
> to exists yet).
Testing fortran_real_16 fixes promotion_3.f90 on AIX. I expect that
the new dg test will work for promotion_4.f90.
Thanks, David
next prev parent reply other threads:[~2017-09-26 14:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 15:07 David Edelsohn
2017-09-25 21:14 ` Janus Weil
2017-09-25 21:23 ` Steve Kargl
2017-09-26 8:44 ` Janus Weil
2017-09-26 9:03 ` Janus Weil
2017-09-26 9:12 ` Rainer Orth
2017-09-26 9:47 ` Janus Weil
2017-09-26 14:54 ` David Edelsohn [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-18 9:38 Dominique d'Humières
2017-09-18 9:31 Dominique d'Humières
2017-09-18 18:13 ` Janus Weil
2017-09-22 10:06 ` Dominique d'Humières
2017-09-22 11:21 ` Janus Weil
2017-09-22 14:37 ` Steve Kargl
2017-09-22 22:46 ` Dominique d'Humières
2017-09-22 23:47 ` Steve Kargl
2017-12-03 17:36 ` Gerald Pfeifer
2017-09-17 20:42 Janus Weil
2017-09-18 4:51 ` Steve Kargl
2017-09-18 7:02 ` Janus Weil
2017-09-18 14:08 ` Steve Kargl
2017-09-18 17:57 ` Janus Weil
2017-09-21 7:10 ` Janus Weil
2017-09-21 20:38 ` Steve Kargl
2017-09-22 5:03 ` Janus Weil
2017-09-22 7:12 ` Janne Blomqvist
2017-09-22 9:44 ` Janus Weil
2017-09-22 19:32 ` Janus Weil
2017-09-23 13:19 ` Janus Weil
2017-09-22 14:06 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWvnymyGFM=qS+=mc_tFyRN+Qz5frVsS8hejSv-=4uG-X03yg@mail.gmail.com' \
--to=dje.gcc@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).