From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id E18EF3858D1E; Tue, 4 Apr 2023 05:34:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E18EF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62c.google.com with SMTP id z19so30261961plo.2; Mon, 03 Apr 2023 22:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680586449; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GnbUovNhiSU1CTMM9M1shye/47WB1I/xVdj4PkmW3O4=; b=GVbNT68mrznfmeurtjeTEumLH4/En+vk6FtCxIbbAKNiX2E73eCllO1n/HTnP11t1R /korObG/Xi2mnSmDN71C62ZBIxrN7sdsiTHF+TpJBgseTfzGANDwMEmOo0KGJY3IK715 +kHodjycTZWsKupH0Jqsy6Nc6Xcu4eR6MTBbedyn4qobdJpmAJGRSVUN5QKygAq0t1qy trONHRRInUdmb+cifdmbrkkLTX2PpDOEt3v+LHzPikb/5Sod2y1W9zWemdJXFWzA/NNO 30SHKNLdJ3F+pJt5u5Mo0qngMIlL38Ll0YrYmjxBVHEorgEj/QC4P+Qr9VEFAesXfczA Bc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680586449; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GnbUovNhiSU1CTMM9M1shye/47WB1I/xVdj4PkmW3O4=; b=vWDVEHjn4p1E1dumFR8sXQIcZXs6r8h6cfCErBzFFdwxz3W473rwqcVVk3M6tWHS/h OM0DwRyU++q/qnm4bJOmxXEWlflOEf0gLG7bL+wgqs4MrR1C5Iv3ss2l8LaD4IGKo7R3 Nk/bTmz/g0GgoiuaZgzmXTH9t5go68RsEF8C/opldNZ2yT3d00GAfVEsK0xxe1yDRJkg iBbYLrSCekcwAVjuqegESpt/ZCMpH6wNBVjqCPkVPheGs9E56L38cXou1TyuMz9AWS+n ZCnXa8Xi3cDhba3xzuvGBrkWxLBaF6yMk3sqh2TQC6cJbb00QWsJbpj0/H+Y9CvEo9IA BBkg== X-Gm-Message-State: AAQBX9eH8NFcxCC24VQMWy5LC9Q4bHRGpdDHWTL4g4B3YpdIJZFxuh4n SeP+2YEzc29DO/xF0ooLeFEjLFPolVHyuxVBy8o= X-Google-Smtp-Source: AKy350ZMgyuY7wGB8Mp8hJBs9GEAsAqoSx06cRZLkwfuJfmYyPPLAT9g+c5sy4gDQZZL/wSDsVNmH+mX99xj7bzH60c= X-Received: by 2002:a17:902:82c9:b0:19f:2c5a:5786 with SMTP id u9-20020a17090282c900b0019f2c5a5786mr525150plz.8.1680586448676; Mon, 03 Apr 2023 22:34:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Tue, 4 Apr 2023 06:33:57 +0100 Message-ID: Subject: Re: [PATCH] Fortran: reject module variable as character length in PARAMETER [PR104349] To: Harald Anlauf Cc: fortran , gcc-patches Content-Type: multipart/alternative; boundary="00000000000049ae1405f87c0649" X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000049ae1405f87c0649 Content-Type: text/plain; charset="UTF-8" Hi Harald, OK for mainline. It is sufficiently small that, if there is any fallout in the next weeks, it can easily be reverted without great impact. Thanks for the patch. Paul On Mon, 3 Apr 2023 at 20:46, Harald Anlauf via Fortran wrote: > Dear all, > > the attached patch fixes an ICE-on-invalid for a PARAMETER expression > where the character length was a MODULE variable. The ICE seemed > strange, as we were catching related erroneous code for declarations in > programs or subroutines. Removing a seemingly bogus check of restricted > expressions is the simplest way to fix this. (We could also catch this > differently in decl.cc). > > Besides, this also fixes an accepts-invalid, see testcase. :-) > > Regtested on x86_64-pc-linux-gnu. OK for mainline (13) or rather wait? > > Thanks, > Harald > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein --00000000000049ae1405f87c0649--