From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 1821D3858D20; Wed, 17 Apr 2024 16:43:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1821D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1821D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1031 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713372231; cv=none; b=TTB2ydmE1HlsWvqR9FxAexY85SVP3FRI0WHKBu6yUEI5wmDRuYZxhwkNfgqx0BHZSQreuAliEakBKuup965lyc9vQO06LYu8qEYjv2ahxhz0JvvAVshMyGlqUxxPU47EeI92C8Hohb+uTK5/bGfbopyyAi6reMHLFDizmtKZ0bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713372231; c=relaxed/simple; bh=XcIr/rVaBha2PbKaHl9qkBHPj68uFW6VPbKujdixHHs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=OT+xyyzupD82r/wEYhGD5vkilIXo/s1MxWaU0sT2qTFkX5Mxou2nmYV2YG+7Ap+WE2ixKBZVazwW/E+j9vdG+15yGarVecKnfrWqaRAeKZbX859bhNIGTqJ3CTn0XL0rF7ha+T11fED2Rw8R4FUISs/5l2bNJtsM74jYe+5i9vk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2a53b331400so3609336a91.1; Wed, 17 Apr 2024 09:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713372226; x=1713977026; darn=gcc.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=IGoWGQQoafY7PnrdsxI0AqadFUwH6xC9KJI2+7kb5VI=; b=k1wKMronV+qtn9oQqnv1diwQEeYrb/AxCN8S+sTjf6GfEXmulPR9w+BtpQBkBb3dJ1 vE/j5huxb9bxTcBSbX0QL/oyG+KBsV6EAmWUx7L51BV2pWidf5XT1E+przZB8JSxOfoa VxP3I1+gSBiBupny99sFM1xfpOo0Ub7BRoqMVGzBfBqVIeLyvHhQ+bcYUQrWeSRZ3z5A UqIkLr+xNUtZzDPKYDcwAQ6vACyYcJ0kn7UcZXZCBHGMTZmwrX3aJ3WtNLf8IHgr1+lJ v+bbXnE+PbBMH0M88wc+UtGAdg07k79YTZsMbQA5PlQ/2LW/jN1dVrfHa2GBwDL8CWU+ dQDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713372226; x=1713977026; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IGoWGQQoafY7PnrdsxI0AqadFUwH6xC9KJI2+7kb5VI=; b=K9Z2eCgh7ifsQxSMnlpsTjPcPWd+dC6Galr5sJcoOn+lGcPMTmGu0Z1PoC+qwKB1Oi XmHw8XfmhVbOXSBgQbqN2fNphHuySHTq2jKzV1CRRjTphXIa0JKPCZqAm2v/JaMcEM08 LY1jGOkvUYtH0G/vGhldLzKOov+MuWdpbeZKHn2DET9Eda4nUHu2lxWEfMb/CjXUp9ys 8+Eh6R5l/tyY2l8grM1Kvg4HFQLCdfEsYUVq4mZJCs03khmjjG3JAVyP9gV9FcNVjcc9 EKAvZOym9OdJKpTGIoACHhP97X4SokLmAKiKLUjJYQ3aoiD7EFfODgAmXWp6J6khutyO n8OA== X-Forwarded-Encrypted: i=1; AJvYcCUBJENzv5EgVJx+AIUKBTqwRBMlJSSDviOyBpI4KfNOtppFv5yv+27zssAlcHJBNp0OTlTcOBmQvdCDrWwiqJXBpiITD4kkeA== X-Gm-Message-State: AOJu0YzsLy0gwGzppQr/jo4VSx/4FNAj7eNW/y+lSfuWLbi/LaqUcQYc RyfPYxhDKgVIpHjXL0w5ndM5yyRAVd35E/jIVj8el9R6fwRGd9GRqdDN+FIc7cE0+WcbQXXYXKW byG3UQQz8nx8tT1vTyCnKvIpHJ+pScqS2 X-Google-Smtp-Source: AGHT+IFj3mz0F3yB8CLK4JVCAo0SZ+G7HiP7tVr2vNVT/6FNf09rTWi+p0DXRA6KIT3EzbfCH4+UcXm4yzLtQM8JI+E= X-Received: by 2002:a17:90a:8cf:b0:2a4:f53d:e6bc with SMTP id 15-20020a17090a08cf00b002a4f53de6bcmr15222661pjn.15.1713372225393; Wed, 17 Apr 2024 09:43:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Wed, 17 Apr 2024 17:43:33 +0100 Message-ID: Subject: [Patch, fortran] PR114739 [14 Regression] ice in gfc_find_derived_types, at fortran/symbol.cc:2458 To: "fortran@gcc.gnu.org" , gcc-patches Content-Type: multipart/mixed; boundary="000000000000dd1d6d06164d8e2e" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dd1d6d06164d8e2e Content-Type: multipart/alternative; boundary="000000000000dd1d6a06164d8e2c" --000000000000dd1d6a06164d8e2c Content-Type: text/plain; charset="UTF-8" This ICE was caused by my patch r14-9489-g3fd46d859cda10. However, the ICE hid a wrong error going back to at least 6.4.1 20180703. The patch fixes both and exposed incorrect error messages in existing tests in gfortran.dg. The fix for these was to add 'IMPLICIT NONE' in call cases so that there really is no implicit type. Regtests OK - I will commit in 24 hours time, if there are no objections and will backport in a couple of weeks. Paul Fortran: Fix ICE in gfc_match_varspec and error messages [PR114739] 2024-04-17 Paul Thomas gcc/fortran PR fortran/114739 * primary.cc (gfc_match_varspec): Check for default type before checking for derived types with the right component name. gcc/testsuite/ PR fortran/114739 * gfortran.dg/pr114739.f90: New test. * gfortran.dg/derived_comp_array_ref_8.f90: Add 'implicit none' for consistency with expected error message. * gfortran.dg/nullify_4.f90: ditto * gfortran.dg/pointer_init_6.f90: ditto * gfortran.dg/pr107397.f90: ditto * gfortran.dg/pr88138.f90: ditto --000000000000dd1d6a06164d8e2c-- --000000000000dd1d6d06164d8e2e Content-Type: text/x-patch; charset="US-ASCII"; name="submit.diff" Content-Disposition: attachment; filename="submit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lv41kl110 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL3ByaW1hcnkuY2MgYi9nY2MvZm9y dHJhbi9wcmltYXJ5LmNjCmluZGV4IDVkZDY4NzVhNGE2Li4zYzY0ZmE3M2Rm YSAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vcHJpbWFyeS5jYworKysgYi9n Y2MvZm9ydHJhbi9wcmltYXJ5LmNjCkBAIC0yMjM2LDYgKzIyMzYsMTUgQEAg Z2ZjX21hdGNoX3ZhcnNwZWMgKGdmY19leHByICpwcmltYXJ5LCBpbnQgZXF1 aXZfZmxhZywgYm9vbCBzdWJfZmxhZywKICAgICAgIG1hdGNoIG1tOwogICAg ICAgb2xkX2xvYyA9IGdmY19jdXJyZW50X2xvY3VzOwogICAgICAgbW0gPSBn ZmNfbWF0Y2hfbmFtZSAobmFtZSk7CisKKyAgICAgIC8qIENoZWNrIHRvIHNl ZSBpZiB0aGlzIGlzIGRlZmF1bHQgY29tcGxleC4gICovCisgICAgICBpZiAo c3ltLT50cy50eXBlID09IEJUX1VOS05PV04gJiYgdGd0X2V4cHIgPT0gTlVM TAorCSAgJiYgZ2ZjX2dldF9kZWZhdWx0X3R5cGUgKHN5bS0+bmFtZSwgc3lt LT5ucyktPnR5cGUgIT0gQlRfVU5LTk9XTikKKwl7CisJICBnZmNfc2V0X2Rl ZmF1bHRfdHlwZSAoc3ltLCAwLCBzeW0tPm5zKTsKKwkgIHByaW1hcnktPnRz ID0gc3ltLT50czsKKwl9CisKICAgICAgIC8qIFRoaXMgaXMgYSB1c2FibGUg aW5xdWlyeSByZWZlcmVuY2UsIGlmIHRoZSBzeW1ib2wgaXMgYWxyZWFkeSBr bm93bgogCSB0byBoYXZlIGEgdHlwZSBvciBubyBkZXJpdmVkIHR5cGVzIHdp dGggYSBjb21wb25lbnQgb2YgdGhpcyBuYW1lCiAJIGNhbiBiZSBmb3VuZC4g IElmIHRoaXMgd2FzIGFuIGlucXVpcnkgcmVmZXJlbmNlIHdpdGggdGhlIHNh bWUgbmFtZQpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5k Zy9kZXJpdmVkX2NvbXBfYXJyYXlfcmVmXzguZjkwIGIvZ2NjL3Rlc3RzdWl0 ZS9nZm9ydHJhbi5kZy9kZXJpdmVkX2NvbXBfYXJyYXlfcmVmXzguZjkwCmlu ZGV4IDczOWY0YWRmYjc4Li4yMmRmZGM2NjhhNiAxMDA2NDQKLS0tIGEvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9kZXJpdmVkX2NvbXBfYXJyYXlfcmVm XzguZjkwCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvZGVyaXZl ZF9jb21wX2FycmF5X3JlZl84LmY5MApAQCAtMiw2ICsyLDcgQEAKICEKICEg UFIgZm9ydHJhbi81MjMyNQogIQoraW1wbGljaXQgbm9uZQogcmVhbCA6OiBm CiBjYyVhID0gNSAhIHsgZGctZXJyb3IgIlN5bWJvbCAnY2MnIGF0IC4xLiBo YXMgbm8gSU1QTElDSVQgdHlwZSIgfQogZiVhID0gNSAgISB7IGRnLWVycm9y ICJVbmV4cGVjdGVkICclJyBmb3Igbm9uZGVyaXZlZC10eXBlIHZhcmlhYmxl ICdmJyBhdCIgfQpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9udWxsaWZ5XzQuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5k Zy9udWxsaWZ5XzQuZjkwCmluZGV4IDBmZDUwNTZlZTA3Li4yNDAxMTBmYWJm OCAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9udWxs aWZ5XzQuZjkwCisrKyBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvbnVs bGlmeV80LmY5MApAQCAtMyw2ICszLDcgQEAKICEKICEgQ2hlY2sgZXJyb3Ig cmVjb3Zlcnk7IHdhcyBjcmFzaGluZyBiZWZvcmUuCiAhCitpbXBsaWNpdCBu b25lCiByZWFsLCBwb2ludGVyIDo6IHB0cgogbnVsbGlmeShwdHIsIG1lc2gl Y29hcnNlcikgISB7IGRnLWVycm9yICJTeW1ib2wgJ21lc2gnIGF0IC4xLiBo YXMgbm8gSU1QTElDSVQgdHlwZSIgfQogZW5kCmRpZmYgLS1naXQgYS9nY2Mv dGVzdHN1aXRlL2dmb3J0cmFuLmRnL3BvaW50ZXJfaW5pdF82LmY5MCBiL2dj Yy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcG9pbnRlcl9pbml0XzYuZjkwCmlu ZGV4IDNhYmFkNGFlMTc5Li40Nzc2MjZlNjZiYiAxMDA2NDQKLS0tIGEvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wb2ludGVyX2luaXRfNi5mOTAKKysr IGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wb2ludGVyX2luaXRfNi5m OTAKQEAgLTIxLDcgKzIxLDcgQEAgZW5kIG1vZHVsZSBtMQoKCiBtb2R1bGUg bTIKLQorIGltcGxpY2l0IG5vbmUKICB0eXBlIDo6IHQKICAgIHByb2NlZHVy ZShzKSwgcG9pbnRlciwgbm9wYXNzIDo6IHBwYwogIGVuZCB0eXBlCmRpZmYg LS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL3ByMTA3Mzk3LmY5 MCBiL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHIxMDczOTcuZjkwCmlu ZGV4IGZkNTliZjE2MDA3Li5mNzdiNGIwMGQwMCAxMDA2NDQKLS0tIGEvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjEwNzM5Ny5mOTAKKysrIGIvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjEwNzM5Ny5mOTAKQEAgLTEsNiAr MSw3IEBACiAheyBkZy1kbyBjb21waWxlIH0KICEKIHByb2dyYW0gcAorICBp bXBsaWNpdCBub25lCiAgIHR5cGUgdAogICAgIHJlYWwgOjogYSA9IDEuMAog ICBlbmQgdHlwZQpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9wcjExNDczOS5mOTAgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L3ByMTE0NzM5LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMC4uZWI4MmNiM2Y2NWIKLS0tIC9kZXYvbnVsbAorKysgYi9nY2Mv dGVzdHN1aXRlL2dmb3J0cmFuLmRnL3ByMTE0NzM5LmY5MApAQCAtMCwwICsx LDExIEBACishIHsgZGctZG8gY29tcGlsZSB9CishIFRoZSBmaXggaGVyZSB3 YXMgdHJpZ2dlcmVkIGJ5IGFuIElDRSBwcmlvciB0byByMTQtOTQ4OS1nM2Zk NDZkODU5Y2RhMTAKKyEgQmVmb3JlIHRoYXQgZ2ZvcnRyYW4gZ2F2ZSBhbiBp bmNvcnJlY3QgIm5vIGltcGxpY2l0IHR5cGUiIGVycm9yIGZvciBhbGwKKyEg dGhyZWUgc3RhdGVtZW50cy4KK3Byb2dyYW0gbWFpbgorICBpbXBsaWNpdCBj b21wbGV4KHopCisgIGltcGxpY2l0IGNoYXJhY3RlcihjKQorICB6MiVyZSA9 IDEuCisgIHoyJWltID0gMi4KKyAgcHJpbnQgKiwgejIsIGMla2luZAorZW5k CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL3ByODgx MzguZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjg4MTM4LmY5 MAppbmRleCBjNDAxOWE2Y2EyZS4uZjExMzBjZjJiYWIgMTAwNjQ0Ci0tLSBh L2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHI4ODEzOC5mOTAKKysrIGIv Z2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9wcjg4MTM4LmY5MApAQCAtMSw1 ICsxLDYgQEAKICEgeyBkZy1kbyBjb21waWxlIH0KIHByb2dyYW0gcAorICAg aW1wbGljaXQgbm9uZQogICAgdHlwZSB0CiAgICAgICBjaGFyYWN0ZXIgOjog YyA9ICdjJwogICAgZW5kIHR5cGUK --000000000000dd1d6d06164d8e2e--