From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 69F0D3858025; Wed, 11 Oct 2023 08:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69F0D3858025 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5859b2eaa67so3742794a12.0; Wed, 11 Oct 2023 01:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697014109; x=1697618909; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=4zuy7a4kkg/nozhkqUcNqxJXG+0jSCCREQWcvvhtwAU=; b=SgLUuPeoQUj2WpLmo4qJLc0ykCIg3VsQmWWTlRfVqxNtcnPRGT+ziGorYUEfd1r6pu 8BkGzYeMO02mS4p8TA6g31w0yJA5cPcnIM6R9vfV4QGnbJgySoRHx17EGabd/RpJzoD1 XRlzRtUqCjAPziUcNYnhw5fCVdN27dp1zwesDAXi1E1niuHs8Q6bkXx+tBVQAQQ4WRf3 XATS+mxPiDwQ8tpbue8uvWnimmd2exWMNFFRZbQI9o3Ly1ErbpwWKqqZYNP+dqVJ2Rgo KccewM2hYsyPKZ0HKUTJt+6/LvJmUoIPo0sV5iYsswKDhrDD3Pcx0gsPsWGP29hKoYVf hxrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697014109; x=1697618909; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4zuy7a4kkg/nozhkqUcNqxJXG+0jSCCREQWcvvhtwAU=; b=HFyVwFtCh8Ze25kfsaaSpTSicbV7IAXwaVxwhAi9qyHD5U4tDdC49P/IKKCaV9MuJz XCbPqBTxekje07oYMYt1ZjLrvPN/IVvfmPjNwMeBeSNPM9jRHVUMcg9i0SCu7mR86bBm uAp4Nta3IresaveVUBnz5nKaJ1DmpP7QKoxfT0/MBTDDcTDUifUSZhFXfoIMXHbvQwXr RwPasY9Etpj/aLshUEKvky+6SXdnAsHdW4UTCsVMSUHdnbheSLQ/c186szEBMjXx/X05 GoOWhKg4Y/h5V1vNYGmvW/jl9XzJqiLENFdrmBCP8RgROJ2ylnzLWnjLXt8GnQo+yt7E 3MgA== X-Gm-Message-State: AOJu0YzZ8d5vIElMxlkizsh/p6jdnP5BBjMnl/FcNf9LWCdO7zwcyTA8 v/QuiJV8vJWXy33qQCn7Sm57c3v0nYDodjsNRRFgs61O5bA= X-Google-Smtp-Source: AGHT+IF95b5ufzNQSXYgDQ/nf63u9Jf9/OiChHAV9nSfr1bgvqAhJbg1jjwAcx/icEa4Dl68Ni5HxK4vQK/MC9H9WJw= X-Received: by 2002:a17:90a:1541:b0:268:1355:b03e with SMTP id y1-20020a17090a154100b002681355b03emr18184693pja.38.1697014108903; Wed, 11 Oct 2023 01:48:28 -0700 (PDT) MIME-Version: 1.0 From: Paul Richard Thomas Date: Wed, 11 Oct 2023 09:48:17 +0100 Message-ID: Subject: [Patch, fortran] PR67740 - Wrong association status of allocatable character pointer in derived types To: "fortran@gcc.gnu.org" , gcc-patches Content-Type: multipart/mixed; boundary="00000000000024486c06076ce372" X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000024486c06076ce372 Content-Type: multipart/alternative; boundary="00000000000024486a06076ce370" --00000000000024486a06076ce370 Content-Type: text/plain; charset="UTF-8" Hi All, The title line of the PR should have been changed a long time since. As noted in comment 5, the original problem was fixed in 10.5. This patch fixes the problem described in comments 4 and 6, where the hidden string length component was not being set in pointer assignment of character arrays. The fix regtests. OK for trunk and 13-branch? Thanks are due to Harald for bringing this to my attention. Paul Fortran: Set hidden string length for pointer components [PR67440] 2023-10-11 Paul Thomas gcc/fortran PR fortran/pr67740 * trans-expr.cc (gfc_trans_pointer_assignment): Set the hidden string length component for pointer assignment to character pointer components. gcc/testsuite/ PR fortran/87477 * gfortran.dg/pr67740.f90: New test --00000000000024486a06076ce370-- --00000000000024486c06076ce372 Content-Type: text/x-fortran; charset="US-ASCII"; name="pr67740.f90" Content-Disposition: attachment; filename="pr67740.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnlibjrm0 ISB7ZGctZG8gY29tcGlsZSB9CiEgeyBkZy1vcHRpb25zICItZmR1bXAtdHJl ZS1vcmlnaW5hbCIgfQohCiEgQ2hlY2sgdGhlIGZpeCBmb3IgdGhlIHRlc3Rj YXNlIGluIGNvbW1lbnQgNCwgd2hlcmUgdGhlIGhpZGRlbiBzdHJpbmcgbGVu Z3RoCiEgY29tcG9uZW50IG9mIHRoZSBhcnJheSBwb2ludGVyIGNvbXBvbmVu dCB3YXMgbm90IHNldC4KIQohIENvbnRyaWJ1dGVkIGJ5IFNlYmFzdGllbiBC YXJkZWF1ICA8YmFyZGVhdUBpcmFtLmZyPgohCnByb2dyYW0gdGVzdDIKICBp bXBsaWNpdCBub25lCiAgY2hhcmFjdGVyKGxlbj0xMCksIGFsbG9jYXRhYmxl LCB0YXJnZXQgOjogcyg6KQogIGNoYXJhY3RlcihsZW49OiksICBwb2ludGVy ICAgICAgICAgICAgIDo6IHNwdHIoOikKICB0eXBlIDo6IHBvaW50ZXJfdHlw ZWMwX3QKICAgIGNoYXJhY3RlcihsZW49OiksIHBvaW50ZXIgOjogZGF0YTAK ICAgIGNoYXJhY3RlcihsZW49OiksIHBvaW50ZXIgOjogZGF0YTEoOikKICBl bmQgdHlwZSBwb2ludGVyX3R5cGVjMF90CiAgdHlwZShwb2ludGVyX3R5cGVj MF90KSA6OiBjbwogICEKICBhbGxvY2F0ZShzKDMpKQogIHMoMSkgPSAnMTIz NDU2Nzg5MCcKICBzKDIpID0gJ3F3ZXJ0eXVpbyAnCiAgcygzKSA9ICdhc2Rm Z2hqayAgJwogICEKICBzcHRyID0+IHMKICBjbyVkYXRhMCA9PiBzKDEpCiAg Y28lZGF0YTEgPT4gcwogICEKICBpZiAoYW55IChzcHRyIC5uZS4gcykpIHN0 b3AgMQogIGlmIChjbyVkYXRhMCAubmUuIHMoMSkpIHN0b3AgMgogIGlmIChh bnkgKGNvJWRhdGExIC5uZS4gcykpIHN0b3AgMyAhIEhpZGRlbiBzdHJpbmcg bGVuZ3RoIHdhcyBub3Qgc2V0CmVuZCBwcm9ncmFtIHRlc3QyCiEgeyBkZy1m aW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJjby5fZGF0YTFfbGVuZ3Ro ID0gMTA7IiAxICJvcmlnaW5hbCIgfSB9 --00000000000024486c06076ce372 Content-Type: text/x-patch; charset="US-ASCII"; name="submit.diff" Content-Disposition: attachment; filename="submit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnlicw2x1 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL3RyYW5zLWV4cHIuY2MgYi9nY2Mv Zm9ydHJhbi90cmFucy1leHByLmNjCmluZGV4IDg2MGI3M2M0OTY4Li43YmVl ZmEyZTY5YyAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vdHJhbnMtZXhwci5j YworKysgYi9nY2MvZm9ydHJhbi90cmFucy1leHByLmNjCkBAIC0xMDQwMywx MSArMTA0MDMsMzYgQEAgZ2ZjX3RyYW5zX3BvaW50ZXJfYXNzaWdubWVudCAo Z2ZjX2V4cHIgKiBleHByMSwgZ2ZjX2V4cHIgKiBleHByMikKIAl9CiAKICAg ICAgIGlmIChleHByMS0+dHMudHlwZSA9PSBCVF9DSEFSQUNURVIKLQkgICYm IGV4cHIxLT5zeW10cmVlLT5uLnN5bS0+dHMuZGVmZXJyZWQKLQkgICYmIGV4 cHIxLT5zeW10cmVlLT5uLnN5bS0+dHMudS5jbC0+YmFja2VuZF9kZWNsCi0J ICAmJiBWQVJfUCAoZXhwcjEtPnN5bXRyZWUtPm4uc3ltLT50cy51LmNsLT5i YWNrZW5kX2RlY2wpKQorCSAgJiYgZXhwcjEtPnRzLmRlZmVycmVkKQogCXsK LQkgIHRtcCA9IGV4cHIxLT5zeW10cmVlLT5uLnN5bS0+dHMudS5jbC0+YmFj a2VuZF9kZWNsOworCSAgZ2ZjX3N5bWJvbCAqcHN5bSA9IGV4cHIxLT5zeW10 cmVlLT5uLnN5bTsKKwkgIHRtcCA9IE5VTExfVFJFRTsKKwkgIGlmIChwc3lt LT50cy50eXBlID09IEJUX0NIQVJBQ1RFUikKKwkgICAgeworCSAgICAgIGdj Y19hc3NlcnQgKHBzeW0tPnRzLnUuY2wtPmJhY2tlbmRfZGVjbAorCQkJICAm JiBWQVJfUCAocHN5bS0+dHMudS5jbC0+YmFja2VuZF9kZWNsKSk7CisJICAg ICAgdG1wID0gcHN5bS0+dHMudS5jbC0+YmFja2VuZF9kZWNsOworCSAgICB9 CisJICBlbHNlIGlmIChleHByMS0+dHMudS5jbC0+YmFja2VuZF9kZWNsCisJ CSAgICYmIFZBUl9QIChleHByMS0+dHMudS5jbC0+YmFja2VuZF9kZWNsKSkK KwkgICAgdG1wID0gZXhwcjEtPnRzLnUuY2wtPmJhY2tlbmRfZGVjbDsKKwkg IGVsc2UgaWYgKFRSRUVfQ09ERSAobHNlLmV4cHIpID09IENPTVBPTkVOVF9S RUYpCisJICAgIHsKKwkgICAgICBnZmNfcmVmICpyZWYgPSBleHByMS0+cmVm OworCSAgICAgIGZvciAoO3JlZjsgcmVmID0gcmVmLT5uZXh0KQorCQl7CisJ CSAgaWYgKHJlZi0+dHlwZSA9PSBSRUZfQ09NUE9ORU5UCisJCSAgICAgICYm IHJlZi0+dS5jLmNvbXBvbmVudC0+dHMudHlwZSA9PSBCVF9DSEFSQUNURVIK KwkJICAgICAgJiYgZ2ZjX2RlZmVycmVkX3N0cmxlbiAocmVmLT51LmMuY29t cG9uZW50LCAmdG1wKSkKKwkJICAgIHRtcCA9IGZvbGRfYnVpbGQzX2xvYyAo aW5wdXRfbG9jYXRpb24sIENPTVBPTkVOVF9SRUYsCisJCQkJCSAgIFRSRUVf VFlQRSAodG1wKSwKKwkJCQkJICAgVFJFRV9PUEVSQU5EIChsc2UuZXhwciwg MCksCisJCQkJCSAgIHRtcCwgTlVMTF9UUkVFKTsKKwkJfQorCSAgICB9CisK KwkgIGdjY19hc3NlcnQgKHRtcCk7CisKIAkgIGlmIChleHByMi0+ZXhwcl90 eXBlICE9IEVYUFJfTlVMTCkKIAkgICAgZ2ZjX2FkZF9tb2RpZnkgKCZibG9j aywgdG1wLAogCQkJICAgIGZvbGRfY29udmVydCAoVFJFRV9UWVBFICh0bXAp LCBzdHJsZW5fcmhzKSk7Cg== --00000000000024486c06076ce372--