From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Andre Vehreschild <vehre@gmx.de>
Cc: GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Subject: Re: [Patch, fortran, pr67451, v1] [5/6 Regression] ICE with sourced allocation from coarray
Date: Wed, 17 Feb 2016 13:13:00 -0000 [thread overview]
Message-ID: <CAGkQGi+QapaPeCTniZNbzUKV6Fnjua7MzY6yUgF1BSNOQhbnMw@mail.gmail.com> (raw)
In-Reply-To: <20160210122624.2114b57d@vepi2>
Dear Andre,
I had left this to somebody else, since I am travelling!
The patch is verging on 'obvious' and so it is OK for trunk.
Could you check the line terminators please? I am seeing CR-LFs but
this might be an effect of transmission.
Thanks for the patch.
Paul
On 10 February 2016 at 12:26, Andre Vehreschild <vehre@gmx.de> wrote:
> Hi all,
>
> unfortunately was my last patch for pr67451 not perfect and introduced
> regressions occurring on s390(x) and with the sanitizer. These were
> caused, because when taking the array specs from the source=-expression
> also its attributes, like coarray state and so on where taken from
> there. This additionally added a corank to local objects to allocate,
> that were no coarrays overwriting data in the array handle. The attached
> patch fixes both issues.
>
> The patch for gcc-5 is not affected, because in gcc-5 the feature of
> taking the array spec from the source=-expression is not implemented.
>
> Bootstrapped and regtested ok on x86_64-linux-gnu/F23.
>
> Ok for trunk?
>
> Regards,
> Andre
>
> On Tue, 2 Feb 2016 19:24:46 +0100
> Paul Richard Thomas <paul.richard.thomas@gmail.com> wrote:
>
>> Hi Andre,
>>
>> This looks to be OK for trunk.
>>
>> I'll move to the 5-branch patch right away.
>>
>> Thanks
>>
>> Paul
>>
>> On 29 January 2016 at 19:17, Andre Vehreschild <vehre@gmx.de> wrote:
>> > Hi all,
>> >
>> > attached is a patch to fix a regression in current gfortran when a
>> > coarray is used in the source=-expression of an allocate(). The ICE was
>> > caused by the class information, i.e., _vptr and so on, not at the
>> > expected place. The patch fixes this.
>> >
>> > The patch also fixes pr69418, which I will flag as a duplicate in a
>> > second.
>> >
>> > Bootstrapped and regtested ok on x86_64-linux-gnu/F23.
>> >
>> > Ok for trunk?
>> >
>> > Backport to gcc-5 is pending, albeit more difficult, because the
>> > allocate() implementation on 5 is not as advanced the one in 6.
>> >
>> > Regards,
>> > Andre
>> > --
>> > Andre Vehreschild * Email: vehre ad gmx dot de
>>
>>
>>
>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein
next prev parent reply other threads:[~2016-02-17 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 18:17 Andre Vehreschild
2016-02-01 12:20 ` [Patch, fortran, pr67451, gcc-5, " Andre Vehreschild
2016-02-01 12:35 ` Andre Vehreschild
2016-02-02 18:44 ` Paul Richard Thomas
2016-02-03 10:39 ` Andre Vehreschild
2016-02-02 18:24 ` [Patch, fortran, pr67451, " Paul Richard Thomas
2016-02-10 11:26 ` Andre Vehreschild
2016-02-17 9:17 ` [PING, Patch, " Andre Vehreschild
2016-02-17 13:13 ` Paul Richard Thomas [this message]
2016-02-23 10:30 ` [Patch, " Andre Vehreschild
2016-02-10 16:48 Dominique d'Humières
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGkQGi+QapaPeCTniZNbzUKV6Fnjua7MzY6yUgF1BSNOQhbnMw@mail.gmail.com \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).