From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 2166C3858D37; Tue, 9 May 2023 15:52:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2166C3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-64115eef620so43492106b3a.1; Tue, 09 May 2023 08:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683647528; x=1686239528; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=+bMPNA78GHFjQH0DqS3OM1N3fdqN04aPOEr7mv2ygQg=; b=Zp+NvVJ2iBqT2wJG+0jEzDKH/LLMRGblaLX4lYPqw6xgDqSP0yR8H51C5TIxarZZz/ I4qCGoq6yBgy9aEgla/0huIj6B9gmktlMZreVi61RlCiYgp5k8zUohD2AftJNppMMjly cfXbB9/PFPAeUKNaBfCiKBpVNEF8zDycDkwrAAq5uwd4wOiNkgS+IWNHO6oxAHl3jdEy aZDLfXf40Up1V1XXx5P0ev2csSQ1ZfH96xLlrQC5aGLjzDt3NNvSFBQYHrAycCpw9J9G 3qEqd/BjQ6uVY/Wx5aMCxHpWhPW2Pz7sPNvJzb0LEeB/zdGoasdgIfjex89HQzBT5yhk kFfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683647528; x=1686239528; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+bMPNA78GHFjQH0DqS3OM1N3fdqN04aPOEr7mv2ygQg=; b=efhHKnbfDavMXLK6di/77ATBSrbpM+x/9TqIkERTxUHvl3TykMgAMlwYmsqz/ZI6QM Ql8Uw2AJE6S+o/cMqjHLlAbdUmuAZixYitmE2oFYYdKemwCJKGFu5EU5Ieaet6MWdxCd c5vW0/BuI8S8WXNziZOUNbNNTV2TLn8xPkkBIGJLIWXHVvF5YsHxR8Bj0SL0Q5U0Ltxp g2F3RGlcexVI5scQKc1pBRQy9EvQ4jrECRAbb6hjaUZk0MA2jk6FoHplyYKv5mbdx/ki xqbxzh2dbP8pQxaKdmmUTA0blVfIIRhdB8ms/AMvqyHqdc0YMCLJo+Iq6vsijmNB5NhL WjQQ== X-Gm-Message-State: AC+VfDwHoDRPHerPrgNdLfoFF0qAvYMsnH2QpDcyt+7KrtEZg9fSqH67 w+CegYCXwKHvDw5tZkN209KL/2JZ94Zu1gzrgcrK8Qe6gkezEA== X-Google-Smtp-Source: ACHHUZ49LrETUapbtOUG2b3ofBPN4orgNCqg6rVoTId3rlJA6rUSgqCVX1mrVvNE981DwTW59XB3Iz6Un2Ol96IXEHg= X-Received: by 2002:a17:903:2343:b0:1ac:85b0:1bd8 with SMTP id c3-20020a170903234300b001ac85b01bd8mr5613262plh.34.1683647527547; Tue, 09 May 2023 08:52:07 -0700 (PDT) MIME-Version: 1.0 From: Paul Richard Thomas Date: Tue, 9 May 2023 16:51:56 +0100 Message-ID: Subject: [Patch, fortran] PR97122 - Spurious FINAL ... must be in the specification part of a MODULE To: "fortran@gcc.gnu.org" , gcc-patches Cc: "Steven G. Kargl" Content-Type: multipart/mixed; boundary="000000000000cea2d905fb44bc44" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000cea2d905fb44bc44 Content-Type: multipart/alternative; boundary="000000000000cea2d705fb44bc42" --000000000000cea2d705fb44bc42 Content-Type: text/plain; charset="UTF-8" Hi All, Thanks to Steve Kargl for the fix. It caused finalize_8.f03 to fail because this testcase checked that finalizable derived types could not be specified in a submodule. I have replaced the original test with a test of the patch. Thanks also to Malcolm Cohen for guidance on this. OK for trunk? Paul Fortran: Allow declaration of finalizable DT in a submodule [PR97122] 2023-05-09 Paul Thomas Steven G. Kargl gcc/fortran PR fortran/97122 * decl.cc (variable_decl): Clean up white space issues. (gfc_match_final_decl): Declaration of finalizable derived type is allowed in a submodule. gcc/testsuite/ PR fortran/97122 * gfortran.dg/finalize_8.f03 : Replace testcase that checks declaration of finalizable derived types in submodules works. --000000000000cea2d705fb44bc42-- --000000000000cea2d905fb44bc44 Content-Type: text/x-patch; charset="US-ASCII"; name="pr97122.diff" Content-Disposition: attachment; filename="pr97122.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhgg7caf0 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RlY2wuY2MgYi9nY2MvZm9ydHJh bi9kZWNsLmNjCmluZGV4IDIzM2JmMjQ0ZDYyLi42ZDZjZTA4NTRkZSAxMDA2 NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vZGVjbC5jYworKysgYi9nY2MvZm9ydHJh bi9kZWNsLmNjCkBAIC0yNjk4LDcgKzI2OTgsNyBAQCB2YXJpYWJsZV9kZWNs IChpbnQgZWxlbSkKIAl9CiAKICAgICAgIGdmY19zZWVuX2RpdjAgPSBmYWxz ZTsKLSAgICAgIAorCiAgICAgICAvKiBGMjAxODpDODMwIChSODE2KSBBbiBl eHBsaWNpdC1zaGFwZS1zcGVjIHdob3NlIGJvdW5kcyBhcmUgbm90CiAJIGNv bnN0YW50IGV4cHJlc3Npb25zIHNoYWxsIGFwcGVhciBvbmx5IGluIGEgc3Vi cHJvZ3JhbSwgZGVyaXZlZAogCSB0eXBlIGRlZmluaXRpb24sIEJMT0NLIGNv bnN0cnVjdCwgb3IgaW50ZXJmYWNlIGJvZHkuICAqLwpAQCAtMjc2OSw3ICsy NzY5LDcgQEAgdmFyaWFibGVfZGVjbCAoaW50IGVsZW0pCiAJICAgICAgaWYg KGUtPmV4cHJfdHlwZSAhPSBFWFBSX0NPTlNUQU5UKQogCQl7CiAJCSAgbiA9 IGdmY19jb3B5X2V4cHIgKGUpOwotCQkgIGlmICghZ2ZjX3NpbXBsaWZ5X2V4 cHIgKG4sIDEpICAmJiBnZmNfc2Vlbl9kaXYwKSAKKwkJICBpZiAoIWdmY19z aW1wbGlmeV9leHByIChuLCAxKSAgJiYgZ2ZjX3NlZW5fZGl2MCkKIAkJICAg IHsKIAkJICAgICAgbSA9IE1BVENIX0VSUk9SOwogCQkgICAgICBnb3RvIGNs ZWFudXA7CkBAIC0yNzg0LDEyICsyNzg0LDEyIEBAIHZhcmlhYmxlX2RlY2wg KGludCBlbGVtKQogCSAgICAgIGlmIChlLT5leHByX3R5cGUgIT0gRVhQUl9D T05TVEFOVCkKIAkJewogCQkgIG4gPSBnZmNfY29weV9leHByIChlKTsKLQkJ ICBpZiAoIWdmY19zaW1wbGlmeV9leHByIChuLCAxKSAgJiYgZ2ZjX3NlZW5f ZGl2MCkgCisJCSAgaWYgKCFnZmNfc2ltcGxpZnlfZXhwciAobiwgMSkgICYm IGdmY19zZWVuX2RpdjApCiAJCSAgICB7CiAJCSAgICAgIG0gPSBNQVRDSF9F UlJPUjsKIAkJICAgICAgZ290byBjbGVhbnVwOwogCQkgICAgfQotCQkgIAor CiAJCSAgaWYgKG4tPmV4cHJfdHlwZSA9PSBFWFBSX0NPTlNUQU5UKQogCQkg ICAgZ2ZjX3JlcGxhY2VfZXhwciAoZSwgbik7CiAJCSAgZWxzZQpAQCAtMTE2 MzcsOCArMTE2MzcsOSBAQCBnZmNfbWF0Y2hfZmluYWxfZGVjbCAodm9pZCkK ICAgYmxvY2sgPSBnZmNfc3RhdGVfc3RhY2stPnByZXZpb3VzLT5zeW07CiAg IGdjY19hc3NlcnQgKGJsb2NrKTsKIAotICBpZiAoIWdmY19zdGF0ZV9zdGFj ay0+cHJldmlvdXMgfHwgIWdmY19zdGF0ZV9zdGFjay0+cHJldmlvdXMtPnBy ZXZpb3VzCi0gICAgICB8fCBnZmNfc3RhdGVfc3RhY2stPnByZXZpb3VzLT5w cmV2aW91cy0+c3RhdGUgIT0gQ09NUF9NT0RVTEUpCisgIGlmIChnZmNfc3Rh dGVfc3RhY2stPnByZXZpb3VzLT5wcmV2aW91cworICAgICAgJiYgZ2ZjX3N0 YXRlX3N0YWNrLT5wcmV2aW91cy0+cHJldmlvdXMtPnN0YXRlICE9IENPTVBf TU9EVUxFCisgICAgICAmJiBnZmNfc3RhdGVfc3RhY2stPnByZXZpb3VzLT5w cmV2aW91cy0+c3RhdGUgIT0gQ09NUF9TVUJNT0RVTEUpCiAgICAgewogICAg ICAgZ2ZjX2Vycm9yICgiRGVyaXZlZCB0eXBlIGRlY2xhcmF0aW9uIHdpdGgg RklOQUwgYXQgJUMgbXVzdCBiZSBpbiB0aGUiCiAJCSAiIHNwZWNpZmljYXRp b24gcGFydCBvZiBhIE1PRFVMRSIpOwpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3Rz dWl0ZS9nZm9ydHJhbi5kZy9maW5hbGl6ZV84LmYwMyBiL2djYy90ZXN0c3Vp dGUvZ2ZvcnRyYW4uZGcvZmluYWxpemVfOC5mMDMKaW5kZXggYjIwMjdhMGJh NmQuLmI3ZmExMGRkYTMxIDEwMDY0NAotLS0gYS9nY2MvdGVzdHN1aXRlL2dm b3J0cmFuLmRnL2ZpbmFsaXplXzguZjAzCisrKyBiL2djYy90ZXN0c3VpdGUv Z2ZvcnRyYW4uZGcvZmluYWxpemVfOC5mMDMKQEAgLTEsMzUgKzEsNDkgQEAK LSEgeyBkZy1kbyBjb21waWxlIH0KLQotISBQYXJzaW5nIG9mIGZpbmFsaXpl ciBwcm9jZWR1cmUgZGVmaW5pdGlvbnMuCi0hIENoZWNrIHRoYXQgRklOQUwt ZGVjbGFyYXRpb25zIGFyZSBvbmx5IGFsbG93ZWQgb24gdHlwZXMgZGVmaW5l ZCBpbiB0aGUKLSEgc3BlY2lmaWNhdGlvbiBwYXJ0IG9mIGEgbW9kdWxlLgot Ci1NT0RVTEUgZmluYWxfdHlwZQorISB7IGRnLWRvIHJ1biB9CishCishIFBS OTcxMjI6IERlY2xhcmF0aW9uIG9mIGEgZmluYWxpemFibGUgZGVyaXZlZCB0 eXBlIGluIGEgc3VibW9kdWxlCishIElTIGFsbG93ZWQuCishCishIENvbnRy aWJ1dGVkIGJ5IElhbiBIYXJ2ZXkgIDxpYW5faGFydmV5QGJpZ3BvbmQuY29t PgorIQorTU9EVUxFIG0KICAgSU1QTElDSVQgTk9ORQogCi1DT05UQUlOUwor ICBJTlRFUkZBQ0UKKyAgICBNT0RVTEUgU1VCUk9VVElORSBvdGhlcihpKQor ICAgICAgSU1QTElDSVQgTk9ORQorICAgICAgaW50ZWdlciwgaW50ZW50KGlu b3V0KSA6OiBpCisgICAgRU5EIFNVQlJPVVRJTkUgb3RoZXIKKyAgRU5EIElO VEVSRkFDRQogCi0gIFNVQlJPVVRJTkUgYmFyCi0gICAgSU1QTElDSVQgTk9O RQorICBpbnRlZ2VyIDo6IG1pCiAKLSAgICBUWVBFIDo6IG15dHlwZQotICAg ICAgSU5URUdFUiwgQUxMT0NBVEFCTEUgOjogZm9vYXJyKDopCi0gICAgICBS RUFMIDo6IGZvb2JhcgotICAgIENPTlRBSU5TCi0gICAgICBGSU5BTCA6OiBt eWZpbmFsICEgeyBkZy1lcnJvciAiaW4gdGhlIHNwZWNpZmljYXRpb24gcGFy dCBvZiBhIE1PRFVMRSIgfQotICAgIEVORCBUWVBFIG15dHlwZQotCi0gIENP TlRBSU5TCitFTkQgTU9EVUxFIG0KIAotICAgIFNVQlJPVVRJTkUgbXlmaW5h bCAoZWwpCi0gICAgICBUWVBFKG15dHlwZSkgOjogZWwKLSAgICBFTkQgU1VC Uk9VVElORSBteWZpbmFsCitTVUJNT0RVTEUgKG0pIHMKKyAgSU1QTElDSVQg Tk9ORQogCi0gIEVORCBTVUJST1VUSU5FIGJhcgorICBUWVBFIDo6IHQKKyAg ICBpbnRlZ2VyIDo6IGkKKyAgQ09OVEFJTlMKKyAgICBGSU5BTCA6OiBmaW5h bF90ICAhIFVzZWQgdG8gYmUgYW4gZXJyb3IgaGVyZQorICBFTkQgVFlQRSB0 CiAKLUVORCBNT0RVTEUgZmluYWxfdHlwZQorQ09OVEFJTlMKIAotUFJPR1JB TSBmaW5hbGl6ZXIKLSAgSU1QTElDSVQgTk9ORQotICAhIERvIG5vdGhpbmcg aGVyZQotRU5EIFBST0dSQU0gZmluYWxpemVyCisgIFNVQlJPVVRJTkUgZmlu YWxfdChhcmcpCisgICAgVFlQRSh0KSwgSU5URU5UKElOT1VUKSA6OiBhcmcK KyAgICBtaSA9IC1hcmclaQorICBFTkQgU1VCUk9VVElORSBmaW5hbF90CisK KyAgbW9kdWxlIHN1YnJvdXRpbmUgb3RoZXIoaSkgICEgJ3RpJyBpcyBmaW5h bGl6ZWQKKyAgICBpbnRlZ2VyLCBpbnRlbnQoaW5vdXQpIDo6IGkKKyAgICB0 eXBlKHQpIDo6IHRpCisgICAgdGklaSA9IGkKKyAgRU5EIHN1YnJvdXRpbmUg b3RoZXIKK0VORCBTVUJNT0RVTEUgcworCisgIHVzZSBtCisgIGludGVnZXIg OjogaSA9IDQyCisgIGNhbGwgb3RoZXIoaSkKKyAgaWYgKG1pIC5uZS4gLWkp IHN0b3AgMQorZW5kCg== --000000000000cea2d905fb44bc44--