From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98079 invoked by alias); 16 Oct 2018 09:12:16 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 98017 invoked by uid 89); 16 Oct 2018 09:12:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=3.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GARBLED_SUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HTo:U*burnus, exchange, states, our X-HELO: mail-yw1-f43.google.com Received: from mail-yw1-f43.google.com (HELO mail-yw1-f43.google.com) (209.85.161.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Oct 2018 09:12:10 +0000 Received: by mail-yw1-f43.google.com with SMTP id e201-v6so8628339ywa.3; Tue, 16 Oct 2018 02:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oVFtz4RvglwZwxZGzYIClkeidlSdEw60El6Tb0U+gyw=; b=IR1NOAE/T+6fVHI+EJMcYq1pW0CFYrW4lUN7+6eJw3padTcvEiSEnLU4GufacxVTSn oQMHCjWMjEwQCJb2fcZ1FaqgzMEnKqU7MEyiKzNJ4hKbBFgpOsqC2ttPVVwdKofjRC0G ldJjCj6m9PLX5YFaycb9Kn3icriTvpD6HtPLOJl0ufeU07d2lA897CsKTHIHNAb7X7wy ITN0AbGQRGuGl91/3EpcNMCh/CefNrrrVlsmLW1iGkzezFqVC/UV8UintGCoG1WiUgqP G08IIXeybiBiAYI4kLuShAD5mbt9PEuL/+E9SHHjuZQGcHS8BW6LANshdPq5RC/lZOm3 405Q== MIME-Version: 1.0 References: <41c30dc9-2f8c-19b3-3228-4dc5d22281df@net-b.de> In-Reply-To: <41c30dc9-2f8c-19b3-3228-4dc5d22281df@net-b.de> From: Paul Richard Thomas Date: Tue, 16 Oct 2018 09:12:00 -0000 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BPatch=2C_Fortran=5D_PR87556_=E2=80=93_for_FORM_TEAM_also_?= =?UTF-8?Q?use_argse=2Epre=2Fpost?= To: Tobias Burnus Cc: gcc-patches , "fortran@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00075.txt.bz2 Hi Tobias, Following our exchange off-list, I rather agree with you that a testcase is pointless. Besides which, I do not see this regressing :-) OK for trunk and, if you are feeling strong, 8-branch. Thanks and welcome back. Paul On Mon, 15 Oct 2018 at 20:46, Tobias Burnus wrote: > > as the subject states, FORM TEAM was only using the resulting tree > expression, ignoring code which was generated before (or afterward). > > I am not sure how to best convert it to a test-suite test case. For > > form team (team(this_image()), my_team2) > > the old dump was: > > integer(kind=3D4) D.3829; > =E2=80=A6 > _gfortran_caf_form_team (team (&D.3829), &my_team2, 0); > > the new one is: > > { > integer(kind=3D4) D.3822; > > D.3822 =3D _gfortran_caf_this_image (0); > _gfortran_caf_form_team (team (&D.3822), &my_team2, 0); > } > > [Does it make sense to check for 5 "this_image (0)" calls? or for 4 > "D.\[0-9\]+ =3D _gfortran_caf_this_image (0);" calls?] > > > Build and on-going regtesting on x86-64-gnu-linux. > > OK for the trunk? > > Tobias > --=20 "If you can't explain it simply, you don't understand it well enough" - Albert Einstein