From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 2C678385772F; Tue, 9 May 2023 20:25:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C678385772F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1aaff9c93a5so44211505ad.2; Tue, 09 May 2023 13:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683663914; x=1686255914; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=mDpwjOhcYE96Kr4+mvy/2yLDQrXwCLmTiR+hYlBwjXM=; b=Lo7Jwh3ksgXKrTSrdMA9E9BQlgZA6zMoAJJs61Lq+3GMySMKsXfFSaT1guzXEkfOtF H00JW/wcUoa9KrvcfGkMCbXdvmTcDqMMrBBbH+a4y/SEaY9nt48XSHOlYKaaKhE4uJT8 7xjiRdnSQT/m6TPSiYj4I3iPhFjsn7iEVHVlLorPmSHF/0czcv3oWbZ2nFvAe1OqdAue KexoQrn66ez83FF3C7V6DtSOdTOmJUZ10DUJvlQKBrZ6cd2xgiCqUxQOjrrIY/2+2Kj+ UGtKOn81uy850Sf2emM7QS5KaKaQREGQjsGn7/uoS6J+D/UiKmDvxz51baTGT+eheleI Y3Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683663914; x=1686255914; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mDpwjOhcYE96Kr4+mvy/2yLDQrXwCLmTiR+hYlBwjXM=; b=RZuVrqRBIDeYzCaQOpBbRV5RQu9qmfcnTQqB6EPrrCQFtwlvwXvu+kP7B4gacCvS7E cv6ugwko8r1F5qsiykBMUx/dWWYkB3Z6ad0mhU/hN0CZSSKXaNrb8gfiJJ9Rk9N4l4TS 2U1PDkTeEuNnC0bUmURCVf3oF9jh39IUl79OvqRSmFqx4o9qg4B8t4qb+Qt6kPc1Sf5+ ZpJgb3ZuMyiDwZGNdPQVcT2z4QGjT9ZMXg4scsSskpRdErnOFrfDiqohk0pxReyeuujy sTqQLbr7xjfPHiVDUJsEJv1tVItRx5QgQRXi+2pSt+7IeWqTGZQbRzLGA70oY+B4Owio ro7A== X-Gm-Message-State: AC+VfDxToC2UR2oG99EEkfvDQ27jKi+vawdqAh3FKx69+Z3MQZ3uBPFs JnObZ3XRS4IxZDtGK6CudCde5sf6leeNDXZsWOY= X-Google-Smtp-Source: ACHHUZ7HnfbCZJEKnrqD0IML3Jo9lBb5aNVGfjTxBC68dypmXuwDoORLyXDpkOOaMxfp5yaXJbbIfVqtRX74gzGZ7Zw= X-Received: by 2002:a17:903:24c:b0:1aa:fea6:f85b with SMTP id j12-20020a170903024c00b001aafea6f85bmr18844374plh.12.1683663913794; Tue, 09 May 2023 13:25:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Tue, 9 May 2023 21:25:02 +0100 Message-ID: Subject: Re: [Patch, fortran] PR103716 - [10/11/12/13/14 Regression] ICE in gimplify_expr, at gimplify.c:15964 To: Harald Anlauf Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: multipart/mixed; boundary="00000000000081a4d605fb488d80" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000081a4d605fb488d80 Content-Type: multipart/alternative; boundary="00000000000081a4d305fb488d7e" --00000000000081a4d305fb488d7e Content-Type: text/plain; charset="UTF-8" Duuh! There's even a choice :-) Paul On Tue, 9 May 2023 at 19:29, Harald Anlauf wrote: > Hi Paul, > > On 5/9/23 18:00, Paul Richard Thomas via Gcc-patches wrote: > > Hi All, > > > > This problem caused the gimplifier failure because the reference chain > > ending in an inquiry_len still retained a full array reference. This had > > already been corrected for deferred character lengths but the fix extends > > this to all characters without a length expression and integer > expressions, > > which is the correct type of course, that retain a full array_spec. The > > nullification of the se->string length in conv_inquiry is a > > belts-and-braces measure to stop it from winding up as a hidden argument > in > > procedure calls. > > > > OK for trunk and, after a decent delay, backporting? > > ENOTESTCASE. > > Nevertheless the patch LGTM and is also OK for backporting. > > Thanks for fixing this! > > Harald > > > > Cheers > > > > Paul > > > > Fortran: Fix assumed length chars and len inquiry [PR103716] > > > > 2023-05-09 Paul Thomas > > > > gcc/fortran > > PR fortran/103716 > > * resolve.cc (gfc_resolve_ref): Conversion of array_ref into an > > element should be done for all characters without a len expr, > > not just deferred lens, and for integer expressions. > > * trans-expr.cc (conv_inquiry): For len and kind inquiry refs, > > set the se string_length to NULL_TREE. > > > > gcc/testsuite/ > > PR fortran/103716 > > * gfortran.dg/pr103716 : New test. > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein --00000000000081a4d305fb488d7e-- --00000000000081a4d605fb488d80 Content-Type: text/x-fortran; charset="US-ASCII"; name="pr103716b.f90" Content-Disposition: attachment; filename="pr103716b.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhgpzzlk3 ISB7IGRnLWRvIHJ1biB9CiEKISBUaGUgZ2ltcGxpZmllciB1c2VkIHRvIHRo cm93IGEgZml0IG9uIHRoZSB3cml0ZSBzdGF0ZW1lbnRzIGluIGYxIGFuZCBm Mi4KIQohIENvbnRyaWJ1dGVkIGJ5IEdlcmhhcmQgU3RlaW5tZXR6ICA8Z3Nj ZnFAdC1vbmxpbmUuZGU+CiEKbW9kdWxlIG0KICBjaGFyYWN0ZXIoNikgOjog YnVmZmVyCmNvbnRhaW5zCiAgaW50ZWdlciBmdW5jdGlvbiBnKHgpCiAgICBp bnRlZ2VyIDo6IHgKICAgIGcgPSB4CiAgZW5kCiAgaW50ZWdlciBmdW5jdGlv biBmMSh4KQogICAgY2hhcmFjdGVyKCopIDo6IHgoKikKICAgIHdyaXRlIChi dWZmZXIoMTozKSwnKGkyKScpIGcoeCVsZW4pCiAgZW5kCiAgaW50ZWdlciBm dW5jdGlvbiBmMih4KQogICAgY2hhcmFjdGVyKCopIDo6IHgoMykKICAgIHdy aXRlIChidWZmZXIoNDo2KSwnKGkyKScpIGcoeCVsZW4pCiAgZW5kCmVuZCBt b2R1bGUgbQoKICB1c2UgbQogIGludGVnZXIgOjogaSgyKSwgagogIGNoYXJh Y3RlcigyKSwgZGltZW5zaW9uKDMpIDo6IGNociA9IFsnYWInLCdjZCcsJ2Vm J10KICBpKDEpID0gZjEoY2hyKQogIGkoMikgPSBmMihjaHIpCiAgaWYgKGFu eSAoaSAuZXEuMikpIHN0b3AgMQogIGlmICh0cmltKGJ1ZmZlcikgLm5lLiAn IDIgIDInKSBzdG9wIDIKZW5kCg== --00000000000081a4d605fb488d80 Content-Type: text/x-fortran; charset="US-ASCII"; name="pr103716.f90" Content-Disposition: attachment; filename="pr103716.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhgpzzl30 ISB7IGRnLWRvIGNvbXBpbGUgfQohCiEgVGhlIGdpbXBsaWZpZXIgdXNlZCB0 byB0aHJvdyBhIGZpdCBvbiB0aGVzIHR3byBmdW5jdGlvbnMuCiEKISBDb250 cmlidXRlZCBieSBHZXJoYXJkIFN0ZWlubWV0eiAgPGdzY2ZxQHQtb25saW5l LmRlPgohCmZ1bmN0aW9uIGYxKHgpCiAgIGNoYXJhY3RlcigqKSA6OiB4KCop CiAgIHByaW50ICosIGcoeCVsZW4pCmVuZAoKZnVuY3Rpb24gZjIoeCkKICAg Y2hhcmFjdGVyKCopIDo6IHgoMykKICAgcHJpbnQgKiwgZyh4JWxlbikKZW5k --00000000000081a4d605fb488d80--