From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
"Dominique d'Humières" <dominiq@tournesol.lps.ens.fr>
Subject: Re: [Patch, fortran] PR 56691 - [OOP] Allocatable array: wrong offset when passing to CLASS dummy
Date: Sat, 10 Feb 2018 18:33:00 -0000 [thread overview]
Message-ID: <CAGkQGiJ=D=tqz3iBHeuy9JOK8emAuJBn_ciYN34CRgVshxB3kQ@mail.gmail.com> (raw)
In-Reply-To: <CAGkQGiJzNYw2QFKvGYj76VjdiLPDk2zmrZQ2Bwi5DgXDaD5Tqw@mail.gmail.com>
Hi All,
Committed as revision 257550. In the course of testing this patch,
Dominique found some problems that turned out to be due to revision
r257065. These latter were encapsulated in PR84155, which was fixed
257356. However, Richi pointed me in the direction of a much cleaner
fix to this PR and it seems that the failing tests that Dominique
found survive this patch :-)
Paul
2018-02-10 Paul Thomas <pault@gcc.gnu.org>
PR fortran/84141
PR fortran/84155
* trans-array.c (gfc_array_init_size): Revert the change made
in revision 257356 setting the dtype.
* trans-types.c (gfc_get_dtype): Do not use the cached dtype.
Call gfc_get_dtype_rank_type every time.
PR fortran/56691
* trans-array.c (gfc_conv_expr_descriptor): If the source array
is a descriptor type, use its offset, removing the condition
that is be a class expression.
2018-02-10 Paul Thomas <pault@gcc.gnu.org>
PR fortran/56691
* gfortran.dg/type_to_class_4.f03: New test.
On 27 January 2018 at 12:41, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> I am worried that this fix seems to easy by half and so I am posting
> it for approval, rather than committing it as obvious. I would be
> obliged if somebody would test it thoroughly.
>
> Bootstraps and regtests on FC23/x86_64 - OK for trunk and 7 branch?
>
> Paul
>
> 2018-27-01 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/56691
> * trans-array.c (gfc_conv_expr_descriptor): If the source array
> is a descriptor type, use its offset, removing the condition
> that is be a class expression.
>
> 2018-27-01 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/56691
> * gfortran.dg/type_to_class_4.f03: New test.
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
prev parent reply other threads:[~2018-02-10 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 12:41 Paul Richard Thomas
2018-02-10 18:33 ` Paul Richard Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGkQGiJ=D=tqz3iBHeuy9JOK8emAuJBn_ciYN34CRgVshxB3kQ@mail.gmail.com' \
--to=paul.richard.thomas@gmail.com \
--cc=dominiq@tournesol.lps.ens.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).