From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Janus Weil <janus@gcc.gnu.org>, gfortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
Date: Sat, 10 Feb 2018 11:46:00 -0000 [thread overview]
Message-ID: <CAGkQGiJQ-xjLKHmnEtY1xALzh5ORyBg_EXcFW9aLfyzKpvRSpA@mail.gmail.com> (raw)
In-Reply-To: <20180209232116.GA41530@troutmask.apl.washington.edu>
Hi Janus,
As Steve said, welcome back!
I hope that you will post the news of this fix and the correction of
the testcases on clf. Talking of which, have you posted the problems
that others have found as PRs?
It was one of my long deferred tasks to make a start on validating the
testsuite and to remove non-standard features.
Thanks for the patch.
Paul
On 9 February 2018 at 23:21, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote:
>>
>> the attached patch fixes some checking code for PASS arguments in
>> procedure-pointer components, which does not properly account for the
>> fact that the PASS argument needs to be polymorphic.
>>
>> [The reason for this issue is probably that PPCs were mostly
>> implemented before polymorphism was available. The corresponding
>> pass-arg checks for TBPs are ok.]
>>
>> The patch also fixes an invalid test case (which was detected thanks
>> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for
>> trunk?
>
> Janus,
>
> The patch looks ok to me. Trunk is in regression and doc
> fixes only mode, so you'll probably need to ping Jakub or
> Richard (ie., release engineer) for an ok.
>
> PS: Welcome back! We can definitely use your talent.
>
> --
> Steve
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
next prev parent reply other threads:[~2018-02-10 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 17:13 Janus Weil
2018-02-09 23:21 ` Steve Kargl
2018-02-10 11:46 ` Paul Richard Thomas [this message]
2018-02-11 13:42 ` Janus Weil
2018-02-11 21:44 ` Janus Weil
2018-02-12 7:22 ` Richard Biener
2018-02-12 17:14 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGkQGiJQ-xjLKHmnEtY1xALzh5ORyBg_EXcFW9aLfyzKpvRSpA@mail.gmail.com \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).