From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: [Patch, fortran] PR96320 - gfortran 8-10 shape mismatch in assumed-length dummy argument character array
Date: Wed, 6 Jan 2021 20:23:38 +0000 [thread overview]
Message-ID: <CAGkQGiJbDd00jn15MsKGPj8sh43h=TM8X9q4CgzYDBABdZZ-nw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
This patch fixes the problems in comments 23 and 24 of the PR.
Comment 23 is fixed by the chunk in expr.c. The chunks in decl.c and
resolve.c fix #24. To be quite honest, I am not sure why they were not
needed in the first place! However, the changes don't cause any problems.
Removing the interface bodies causes the expected error cascade.
Regtests on FC33/x86_64 - OK for master and, after a decent delay 9- and
10- branches?
Paul
Fortran: This patch fixes comments 23 and 24 of PR96320.
2021-01-06 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/96320
* decl.c (gfc_match_modproc): It is not an error to find a
module procedure declaration within a contains block.
* expr.c (gfc_check_vardef_context): Pure procedure result is
assignable. Change 'own_scope' accordingly.
* resolve.c (resolve_typebound_procedure): A procedure that
has the module procedure attribute is almost certainly a
module procedure, whatever its interface.
gcc/testsuite/
PR fortran/96320
* gfortran.dg/module_procedure_5.f90 : New test.
* gfortran.dg/module_procedure_6.f90 : New test.
[-- Attachment #2: Change2.Logs --]
[-- Type: application/octet-stream, Size: 653 bytes --]
Fortran: This patch fixes comments 23 and 24 of PR96320.
2021-01-06 Paul Thomas <pault@gcc.gnu.org>
gcc/fortran
PR fortran/96320
* decl.c (gfc_match_modproc): It is not an error to find a
module procedure declaration within a contains block.
* expr.c (gfc_check_vardef_context): Pure procedure result is
assignable. Change 'own_scope' accordingly.
* resolve.c (resolve_typebound_procedure): A procedure that
has the module procedure attribute is almost certainly a
module procedure, whatever its interface.
gcc/testsuite/
PR fortran/96320
* gfortran.dg/module_procedure_5.f90 : New test.
* gfortran.dg/module_procedure_6.f90 : New test.
next reply other threads:[~2021-01-06 20:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 20:23 Paul Richard Thomas [this message]
2021-01-06 20:24 ` Paul Richard Thomas
2021-01-14 21:45 ` Ping: " Paul Richard Thomas
2021-01-15 9:03 ` Un-Ping: " Paul Richard Thomas
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 15:44 Paul Richard Thomas
2020-08-01 9:54 ` Thomas Koenig
2020-08-01 10:16 ` Paul Richard Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGkQGiJbDd00jn15MsKGPj8sh43h=TM8X9q4CgzYDBABdZZ-nw@mail.gmail.com' \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).