From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id D43BD3850410 for ; Wed, 6 Jan 2021 20:23:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D43BD3850410 Received: by mail-lf1-x132.google.com with SMTP id 23so9415706lfg.10 for ; Wed, 06 Jan 2021 12:23:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=/yPdj4pan/eulXbck0LJ465Pm41ZECJjTbOZ8DUpp3Q=; b=RZj/mPl7tZb5HbbyV8zQ8bVilIiv3rJzg9W5rPYEfg3jyZebk4BggwOfLCUn5h4RdP 74jAIz/ezuv0A0UGOY9e5qf5wfoiIyY8Kuu18X1g5O9iunRnAtsSm4aOZsb4oErdul3U 3dpFjzfRzYd0iTeI0I70DvWNXFqNP6+jGPSsiSraczTN4FjDq6bge9SkssdDBe7WoK42 EysWGG2vX2eOIKPHoxasj1PO7K6CJOAp5rrZXKgQ1OsNdv19sKX6EytIxTZeLCcT5bGD u/hi93+5uGg1DlVm1uJ97tgoFNPsZHjjdlce0Oj2hlw4al5USZ2xZ8GTpJiyhEDS2Yue vlaw== X-Gm-Message-State: AOAM533z1uOmZBQFXQF8IpO2J8UbqrFdmBItUJBDFDhpZlIk4kVOhvTj VfUYIEJtQpkoc9PTClY+5eq77dfgJqedlsSLWbKnCnbLhGApCgAx X-Google-Smtp-Source: ABdhPJy8nxd148QY/in8uV2fCLgE821kd6J1Xq2v97IS3uzDbK0FLv1BJjA8qrFOpxklQa94naR2gHVIcFYtbhevZ+U= X-Received: by 2002:a19:589:: with SMTP id 131mr2743703lff.525.1609964629882; Wed, 06 Jan 2021 12:23:49 -0800 (PST) MIME-Version: 1.0 From: Paul Richard Thomas Date: Wed, 6 Jan 2021 20:23:38 +0000 Message-ID: Subject: [Patch, fortran] PR96320 - gfortran 8-10 shape mismatch in assumed-length dummy argument character array To: "fortran@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000dd97c205b841195b" X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 20:23:54 -0000 --000000000000dd97c205b841195b Content-Type: text/plain; charset="UTF-8" This patch fixes the problems in comments 23 and 24 of the PR. Comment 23 is fixed by the chunk in expr.c. The chunks in decl.c and resolve.c fix #24. To be quite honest, I am not sure why they were not needed in the first place! However, the changes don't cause any problems. Removing the interface bodies causes the expected error cascade. Regtests on FC33/x86_64 - OK for master and, after a decent delay 9- and 10- branches? Paul Fortran: This patch fixes comments 23 and 24 of PR96320. 2021-01-06 Paul Thomas gcc/fortran PR fortran/96320 * decl.c (gfc_match_modproc): It is not an error to find a module procedure declaration within a contains block. * expr.c (gfc_check_vardef_context): Pure procedure result is assignable. Change 'own_scope' accordingly. * resolve.c (resolve_typebound_procedure): A procedure that has the module procedure attribute is almost certainly a module procedure, whatever its interface. gcc/testsuite/ PR fortran/96320 * gfortran.dg/module_procedure_5.f90 : New test. * gfortran.dg/module_procedure_6.f90 : New test. --000000000000dd97c205b841195b Content-Type: application/octet-stream; name="Change2.Logs" Content-Disposition: attachment; filename="Change2.Logs" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjlvct6t0 Rm9ydHJhbjogVGhpcyBwYXRjaCBmaXhlcyBjb21tZW50cyAyMyBhbmQgMjQgb2YgUFI5NjMyMC4K CjIwMjEtMDEtMDYgIFBhdWwgVGhvbWFzICA8cGF1bHRAZ2NjLmdudS5vcmc+CgpnY2MvZm9ydHJh bgoJUFIgZm9ydHJhbi85NjMyMAoJKiBkZWNsLmMgKGdmY19tYXRjaF9tb2Rwcm9jKTogSXQgaXMg bm90IGFuIGVycm9yIHRvIGZpbmQgYQoJbW9kdWxlIHByb2NlZHVyZSBkZWNsYXJhdGlvbiB3aXRo aW4gYSBjb250YWlucyBibG9jay4KCSogZXhwci5jIChnZmNfY2hlY2tfdmFyZGVmX2NvbnRleHQp OiBQdXJlIHByb2NlZHVyZSByZXN1bHQgaXMKCWFzc2lnbmFibGUuIENoYW5nZSAnb3duX3Njb3Bl JyBhY2NvcmRpbmdseS4KCSogcmVzb2x2ZS5jIChyZXNvbHZlX3R5cGVib3VuZF9wcm9jZWR1cmUp OiBBIHByb2NlZHVyZSB0aGF0CgloYXMgdGhlIG1vZHVsZSBwcm9jZWR1cmUgYXR0cmlidXRlIGlz IGFsbW9zdCBjZXJ0YWlubHkgYQoJbW9kdWxlIHByb2NlZHVyZSwgd2hhdGV2ZXIgaXRzIGludGVy ZmFjZS4KCmdjYy90ZXN0c3VpdGUvCglQUiBmb3J0cmFuLzk2MzIwCgkqIGdmb3J0cmFuLmRnL21v ZHVsZV9wcm9jZWR1cmVfNS5mOTAgOiBOZXcgdGVzdC4KCSogZ2ZvcnRyYW4uZGcvbW9kdWxlX3By b2NlZHVyZV82LmY5MCA6IE5ldyB0ZXN0Lgo= --000000000000dd97c205b841195b--